2011/1/7 Stefan Behnel stefan...@behnel.de:
Robert Bradshaw, 07.01.2011 19:17:
On Fri, Jan 7, 2011 at 4:27 AM, Vitja Makarov wrote:
I've added GenerartorDefNode and GeneratorBodyDefNode now all the
generators stuff is handled there.
Yay! I'm pretty busy this weekend, but have been following
2010/12/31 Robert Bradshaw rober...@math.washington.edu:
On Thu, Dec 30, 2010 at 10:05 AM, Stefan Behnel stefan...@behnel.de wrote:
Vitja Makarov, 30.12.2010 18:53:
Why did you reverted decorators stuff?
https://github.com/vitek/cython/commit/e0d366d9409680849e6f429992ac9724e2ad1016
Because
On Fri, Jan 7, 2011 at 4:27 AM, Vitja Makarov vitja.maka...@gmail.com wrote:
2010/12/31 Robert Bradshaw rober...@math.washington.edu:
On Thu, Dec 30, 2010 at 10:05 AM, Stefan Behnel stefan...@behnel.de wrote:
Vitja Makarov, 30.12.2010 18:53:
Why did you reverted decorators stuff?
Robert Bradshaw, 07.01.2011 19:17:
On Fri, Jan 7, 2011 at 4:27 AM, Vitja Makarov wrote:
I've added GenerartorDefNode and GeneratorBodyDefNode now all the
generators stuff is handled there.
Yay! I'm pretty busy this weekend, but have been following your branch
from a distance and so reviewing
2010/12/14 Vitja Makarov vitja.maka...@gmail.com:
2010/12/14 Stefan Behnel stefan...@behnel.de:
Vitja Makarov, 14.12.2010 15:49:
2010/12/14 Stefan Behnelstefan...@behnel.de:
Vitja Makarov, 14.12.2010 14:45:
2010/12/14 Stefan Behnel:
Stefan Behnel, 13.12.2010 06:37:
Vitja Makarov, 12.12.2010
Vitja Makarov, 30.12.2010 18:53:
Why did you reverted decorators stuff?
https://github.com/vitek/cython/commit/e0d366d9409680849e6f429992ac9724e2ad1016
Because I didn't get it finished, it broke the Sage build and cython-devel
should stay cleanly working before the release. I added a link to
On Thu, Dec 30, 2010 at 10:05 AM, Stefan Behnel stefan...@behnel.de wrote:
Vitja Makarov, 30.12.2010 18:53:
Why did you reverted decorators stuff?
https://github.com/vitek/cython/commit/e0d366d9409680849e6f429992ac9724e2ad1016
Because I didn't get it finished, it broke the Sage build and
Vitja Makarov, 14.12.2010 14:45:
2010/12/14 Stefan Behnel:
Stefan Behnel, 13.12.2010 06:37:
Vitja Makarov, 12.12.2010 20:23:
What do you think about GeneratorWrapperNode?
It seems ok. I'll give it a deeper look ASAP.
Actually, after looking through it, I think it's an ugly hack. It tries
2010/12/14 Stefan Behnel stefan...@behnel.de:
Vitja Makarov, 14.12.2010 14:45:
2010/12/14 Stefan Behnel:
Stefan Behnel, 13.12.2010 06:37:
Vitja Makarov, 12.12.2010 20:23:
What do you think about GeneratorWrapperNode?
It seems ok. I'll give it a deeper look ASAP.
Actually, after looking
Vitja Makarov, 14.12.2010 15:49:
2010/12/14 Stefan Behnelstefan...@behnel.de:
Vitja Makarov, 14.12.2010 14:45:
2010/12/14 Stefan Behnel:
Stefan Behnel, 13.12.2010 06:37:
Vitja Makarov, 12.12.2010 20:23:
What do you think about GeneratorWrapperNode?
It seems ok. I'll give it a deeper look
2010/12/14 Stefan Behnel stefan...@behnel.de:
Vitja Makarov, 14.12.2010 15:49:
2010/12/14 Stefan Behnelstefan...@behnel.de:
Vitja Makarov, 14.12.2010 14:45:
2010/12/14 Stefan Behnel:
Stefan Behnel, 13.12.2010 06:37:
Vitja Makarov, 12.12.2010 20:23:
What do you think about
Vitja Makarov, 12.12.2010 20:23:
It seems that there is no major issues with generators, refleaks and so on.
I know what the refcounting problem is now. It's a bug that has already
been (mostly) fixed in Haoyu's branch. So far, we didn't have nonlocal,
so there was no way to test how closure
Vitja Makarov, 13.12.2010 07:49:
2010/12/13 Stefan Behnel:
Vitja Makarov, 12.12.2010 20:23:
I've cleaned generators stuff a little:
* Turn YieldNodeCollector into TreeVisitor
I think that's ok. It's a bit redundant with the tree traversal that
happens anyway, but it also keeps the code
2010/12/13 Stefan Behnel stefan...@behnel.de:
Vitja Makarov, 12.12.2010 20:23:
It seems that there is no major issues with generators, refleaks and so on.
I know what the refcounting problem is now. It's a bug that has already
been (mostly) fixed in Haoyu's branch. So far, we didn't have
2010/12/13 Stefan Behnel stefan...@behnel.de:
Vitja Makarov, 13.12.2010 13:54:
2010/12/13 Stefan Behnelstefan...@behnel.de:
Vitja Makarov, 12.12.2010 20:23:
It seems that there is no major issues with generators, refleaks and so on.
I know what the refcounting problem is now. It's a bug that
Stefan Behnel, 13.12.2010 06:37:
Vitja Makarov, 12.12.2010 20:23:
What do you think about GeneratorWrapperNode?
It seems ok. I'll give it a deeper look ASAP.
Actually, after looking through it, I think it's an ugly hack. It tries to
hide the fact that the DefNode does the wrong thing for the
2010/12/11 Vitja Makarov vitja.maka...@gmail.com:
2010/12/11 Stefan Behnel stefan...@behnel.de:
Vitja Makarov, 10.12.2010 09:22:
2010/12/10 Stefan Behnel:
Stefan Behnel, 09.12.2010 10:46:
Vitja Makarov, 08.12.2010 22:45:
Please review this patch. It's not yet finished, and mostly doesn't
2010/12/13 Stefan Behnel stefan...@behnel.de:
Vitja Makarov, 12.12.2010 20:23:
I've cleaned generators stuff a little:
* Turn YieldNodeCollector into TreeVisitor
I think that's ok. It's a bit redundant with the tree traversal that
happens anyway, but it also keeps the code more compact
2010/12/10 Stefan Behnel stefan...@behnel.de:
Stefan Behnel, 09.12.2010 10:46:
Vitja Makarov, 08.12.2010 22:45:
Please review this patch. It's not yet finished, and mostly doesn't work.
But you can take a look at patch and generated code.
I'll take a close look ASAP.
- Temps are
On Fri, Dec 10, 2010 at 12:22 AM, Vitja Makarov vitja.maka...@gmail.com wrote:
2010/12/10 Stefan Behnel stefan...@behnel.de:
Stefan Behnel, 09.12.2010 10:46:
Vitja Makarov, 08.12.2010 22:45:
Please review this patch. It's not yet finished, and mostly doesn't work.
But you can take a look at
2010/12/10 Robert Bradshaw rober...@math.washington.edu:
On Fri, Dec 10, 2010 at 12:22 AM, Vitja Makarov vitja.maka...@gmail.com
wrote:
2010/12/10 Stefan Behnel stefan...@behnel.de:
Stefan Behnel, 09.12.2010 10:46:
Vitja Makarov, 08.12.2010 22:45:
Please review this patch. It's not yet
On Fri, Dec 10, 2010 at 11:15 AM, Vitja Makarov vitja.maka...@gmail.com wrote:
2010/12/10 Robert Bradshaw rober...@math.washington.edu:
On Fri, Dec 10, 2010 at 12:22 AM, Vitja Makarov vitja.maka...@gmail.com
wrote:
2010/12/10 Stefan Behnel stefan...@behnel.de:
Stefan Behnel, 09.12.2010
Robert Bradshaw, 10.12.2010 20:35:
On Fri, Dec 10, 2010 at 11:15 AM, Vitja Makarov wrote:
2010/12/10 Robert Bradshaw:
On Fri, Dec 10, 2010 at 12:22 AM, Vitja Makarov wrote:
2010/12/10 Stefan Behnel:
I could also add Hudson jobs for it. Robert, would it be ok to add them
for
all Python
2010/12/10 Robert Bradshaw rober...@math.washington.edu:
On Fri, Dec 10, 2010 at 11:51 AM, Stefan Behnel stefan...@behnel.de wrote:
Robert Bradshaw, 10.12.2010 20:35:
On Fri, Dec 10, 2010 at 11:15 AM, Vitja Makarov wrote:
2010/12/10 Robert Bradshaw:
On Fri, Dec 10, 2010 at 12:22 AM, Vitja
Vitja Makarov, 10.12.2010 22:01:
I've pushed commit that moves exc_save_vars into temps
Yes, I think that makes good sense and should simplify things a lot.
(now it's declared with type=py_object_type and manage_refs=False)
Sounds right.
Stefan
2010/12/11 Stefan Behnel stefan...@behnel.de:
Vitja Makarov, 10.12.2010 22:01:
I've pushed commit that moves exc_save_vars into temps
Yes, I think that makes good sense and should simplify things a lot.
Here is commit for it
On Fri, Dec 10, 2010 at 2:38 PM, Stefan Behnel stefan...@behnel.de wrote:
Vitja Makarov, 10.12.2010 22:01:
I've pushed commit that moves exc_save_vars into temps
Yes, I think that makes good sense and should simplify things a lot.
(now it's declared with type=py_object_type and
2010/12/11 Robert Bradshaw rober...@math.washington.edu:
On Fri, Dec 10, 2010 at 2:38 PM, Stefan Behnel stefan...@behnel.de wrote:
Vitja Makarov, 10.12.2010 22:01:
I've pushed commit that moves exc_save_vars into temps
Yes, I think that makes good sense and should simplify things a lot.
Vitja Makarov, 10.12.2010 09:22:
2010/12/10 Stefan Behnel:
Stefan Behnel, 09.12.2010 10:46:
Vitja Makarov, 08.12.2010 22:45:
Please review this patch. It's not yet finished, and mostly doesn't work.
But you can take a look at patch and generated code.
I'll take a close look ASAP.
-
Vitja Makarov, 10.12.2010 23:42:
Pyregr tests works now on hudson but there is still problem with heapq
don't understand is that related to generators or not
Not sure either. It works for me in Py3 but not in Py2.7.
Stefan
___
Cython-dev mailing list
Stefan Behnel, 11.12.2010 00:46:
Vitja Makarov, 10.12.2010 23:42:
Pyregr tests works now on hudson but there is still problem with heapq
don't understand is that related to generators or not
Not sure either. It works for me in Py3 but not in Py2.7.
It seems to be generator related and it
2010/12/11 Stefan Behnel stefan...@behnel.de:
Vitja Makarov, 10.12.2010 09:22:
2010/12/10 Stefan Behnel:
Stefan Behnel, 09.12.2010 10:46:
Vitja Makarov, 08.12.2010 22:45:
Please review this patch. It's not yet finished, and mostly doesn't work.
But you can take a look at patch and generated
Vitja Makarov, 08.12.2010 22:45:
Please review this patch. It's not yet finished, and mostly doesn't work.
But you can take a look at patch and generated code.
*Way* cool, thanks! I'll take a close look ASAP. Please feel free to send
in a new patch when you have it. If you use hg, you can use
On Thu, Dec 9, 2010 at 1:46 AM, Stefan Behnel stefan...@behnel.de wrote:
Vitja Makarov, 08.12.2010 22:45:
Please review this patch. It's not yet finished, and mostly doesn't work.
But you can take a look at patch and generated code.
*Way* cool, thanks! I'll take a close look ASAP. Please feel
Robert Bradshaw, 09.12.2010 11:00:
On Thu, Dec 9, 2010 at 1:46 AM, Stefan Behnel wrote:
Vitja Makarov, 08.12.2010 22:45:
Please review this patch. It's not yet finished, and mostly doesn't work.
But you can take a look at patch and generated code.
*Way* cool, thanks! I'll take a close look
On Thu, Dec 9, 2010 at 2:10 AM, Stefan Behnel stefan...@behnel.de wrote:
Robert Bradshaw, 09.12.2010 11:00:
On Thu, Dec 9, 2010 at 1:46 AM, Stefan Behnel wrote:
Vitja Makarov, 08.12.2010 22:45:
Please review this patch. It's not yet finished, and mostly doesn't work.
But you can take a look
2010/12/9 Robert Bradshaw rober...@math.washington.edu:
On Thu, Dec 9, 2010 at 2:10 AM, Stefan Behnel stefan...@behnel.de wrote:
Robert Bradshaw, 09.12.2010 11:00:
On Thu, Dec 9, 2010 at 1:46 AM, Stefan Behnel wrote:
Vitja Makarov, 08.12.2010 22:45:
Please review this patch. It's not yet
On Thu, Dec 9, 2010 at 2:50 AM, Vitja Makarov vitja.maka...@gmail.com wrote:
2010/12/9 Robert Bradshaw rober...@math.washington.edu:
On Thu, Dec 9, 2010 at 2:10 AM, Stefan Behnel stefan...@behnel.de wrote:
Robert Bradshaw, 09.12.2010 11:00:
On Thu, Dec 9, 2010 at 1:46 AM, Stefan Behnel wrote:
2010/12/9 Robert Bradshaw rober...@math.washington.edu:
On Thu, Dec 9, 2010 at 2:50 AM, Vitja Makarov vitja.maka...@gmail.com wrote:
2010/12/9 Robert Bradshaw rober...@math.washington.edu:
On Thu, Dec 9, 2010 at 2:10 AM, Stefan Behnel stefan...@behnel.de wrote:
Robert Bradshaw, 09.12.2010
2010/12/9 Vitja Makarov vitja.maka...@gmail.com:
2010/12/9 Robert Bradshaw rober...@math.washington.edu:
On Thu, Dec 9, 2010 at 2:50 AM, Vitja Makarov vitja.maka...@gmail.com
wrote:
2010/12/9 Robert Bradshaw rober...@math.washington.edu:
On Thu, Dec 9, 2010 at 2:10 AM, Stefan Behnel
On Thu, Dec 9, 2010 at 12:45 PM, Vitja Makarov vitja.maka...@gmail.com wrote:
2010/12/9 Vitja Makarov vitja.maka...@gmail.com:
2010/12/9 Robert Bradshaw rober...@math.washington.edu:
On Thu, Dec 9, 2010 at 2:50 AM, Vitja Makarov vitja.maka...@gmail.com
wrote:
2010/12/9 Robert Bradshaw
Stefan Behnel, 09.12.2010 10:46:
Vitja Makarov, 08.12.2010 22:45:
Please review this patch. It's not yet finished, and mostly doesn't work.
But you can take a look at patch and generated code.
I'll take a close look ASAP.
- Temps are saved/restored/allocated inside YieldExprNode using
2010/12/7 Vitja Makarov vitja.maka...@gmail.com:
2010/12/7 Vitja Makarov vitja.maka...@gmail.com:
2010/12/7 Robert Bradshaw rober...@math.washington.edu:
First off, great to hear you're working on this. I've wanted to do it
for a while (well, essentially ever since I got closures done), but
2010/12/8 Vitja Makarov vitja.maka...@gmail.com:
2010/12/7 Vitja Makarov vitja.maka...@gmail.com:
2010/12/7 Vitja Makarov vitja.maka...@gmail.com:
2010/12/7 Robert Bradshaw rober...@math.washington.edu:
First off, great to hear you're working on this. I've wanted to do it
for a while (well,
2010/12/6 Stefan Behnel stefan...@behnel.de:
Vitja Makarov, 05.12.2010 20:12:
I've started woring on generators on friday.
Cool. This sounds like a larger code change, though. Try not to submit it
as a single patch as that would likely be hard to review. Instead, put up a
repo somewhere that
2010/12/6 Stefan Behnel stefan...@behnel.de:
Vitja Makarov, 06.12.2010 09:56:
2010/12/6 Stefan Behnel:
Vitja Makarov, 05.12.2010 20:12:
def my_generator(self, args, kwargs):
closure = my_generator_closure_new()
closure.is_running = 0
closure.resume_label = 0
On 12/06/2010 11:35 AM, Stefan Behnel wrote:
Vitja Makarov, 06.12.2010 10:56:
2010/12/6 Stefan Behnel:
Vitja Makarov, 06.12.2010 09:56:
2010/12/6 Stefan Behnel:
Vitja Makarov, 05.12.2010 20:12:
About temps:
now temps are allocated in closure
Stefan Behnel, 06.12.2010 11:35:
I think it would be best to generate the straight assignment code from
within of the YieldExprNode:
closure-place_for_int_temp[0] = __pyx_t_2
closure-place_for_int_temp[1] = __pyx_t_5
closure-place_for_object_temp[0] = __pyx_t_9
First off, great to hear you're working on this. I've wanted to do it
for a while (well, essentially ever since I got closures done), but
don't know when I'll find the time.
On Mon, Dec 6, 2010 at 12:56 AM, Vitja Makarov vitja.maka...@gmail.com wrote:
def my_generator_body(closure, value,
2010/12/7 Robert Bradshaw rober...@math.washington.edu:
First off, great to hear you're working on this. I've wanted to do it
for a while (well, essentially ever since I got closures done), but
don't know when I'll find the time.
On Mon, Dec 6, 2010 at 12:56 AM, Vitja Makarov
2010/12/7 Vitja Makarov vitja.maka...@gmail.com:
2010/12/7 Robert Bradshaw rober...@math.washington.edu:
First off, great to hear you're working on this. I've wanted to do it
for a while (well, essentially ever since I got closures done), but
don't know when I'll find the time.
On Mon, Dec
2010/12/5 Stefan Behnel stefan...@behnel.de:
Hi,
I just noticed that Vitja's closure refactoring brought us closer to
supporting generator expressions (before supporting generators and
coroutines). Here's what's missing:
1) transform a GeneratorExpressionNode into a DefNode or a subclass
Vitja Makarov, 05.12.2010 20:12:
I've started woring on generators on friday.
Cool. This sounds like a larger code change, though. Try not to submit it
as a single patch as that would likely be hard to review. Instead, put up a
repo somewhere that others can look at, or submit bundles (as hg
Stefan Behnel, 06.12.2010 08:33:
Vitja Makarov, 05.12.2010 20:12:
I have problem with closures and generators.
Now I want to implement closure structure this way:
struct abstract_generator {
PY_OBJECT_HEAD
/* generator internal vars */
PyObject *(*body)(struct closure *,
54 matches
Mail list logo
