Re: Time to Document Callbacks

2010-03-07 Thread Tim Bunce
On Sat, Mar 06, 2010 at 04:07:09PM -0800, David E. Wheeler wrote: On Mar 6, 2010, at 3:45 PM, Tim Bunce wrote: I was tempted to leave The cool thing is but opted to drop it as it doesn't match the tone of the rest of the docs - although they are rather dry :) Pity. Thought I was

Re: HTTP Authentication for Gofer

2010-03-07 Thread Tim Bunce
On Fri, Mar 05, 2010 at 01:58:52PM -0600, Stuart Johnston wrote: I am exploring a few different options for adding authentication support to Gofer::Transport::http and I would appreciate any feedback. The most straightforward option is to add several attributes (netloc, realm, http_user,

Re: Time to Document Callbacks

2010-03-07 Thread David E. Wheeler
On Mar 7, 2010, at 5:43 AM, Tim Bunce wrote: Looks good, thanks. Pity you removed the `$dbh-{private_myapp_sql_mode}` bit, though, as that's required when using Cconnect_cached(), which you almost certainly are doing if you need this hack. Are you sure it's required when using connected()?

Re: HTTP Authentication for Gofer

2010-03-07 Thread Stuart Johnston
Tim Bunce wrote: On Fri, Mar 05, 2010 at 01:58:52PM -0600, Stuart Johnston wrote: I am exploring a few different options for adding authentication support to Gofer::Transport::http and I would appreciate any feedback. The most straightforward option is to add several attributes (netloc, realm,

Re: HTTP Authentication for Gofer

2010-03-07 Thread Stuart Johnston
Henri Asseily wrote: On 3/7/2010 3:50 PM, Tim Bunce wrote: On Fri, Mar 05, 2010 at 01:58:52PM -0600, Stuart Johnston wrote: I am exploring a few different options for adding authentication support to Gofer::Transport::http and I would appreciate any feedback. The most straightforward option

Re: HTTP Authentication for Gofer

2010-03-07 Thread Stuart Johnston
Stuart Johnston wrote: Tim Bunce wrote: On Fri, Mar 05, 2010 at 01:58:52PM -0600, Stuart Johnston wrote: I am exploring a few different options for adding authentication support to Gofer::Transport::http and I would appreciate any feedback. The most straightforward option is to add several

Re: Time to Document Callbacks

2010-03-07 Thread Tim Bunce
On Sun, Mar 07, 2010 at 10:29:29AM -0800, David E. Wheeler wrote: On Mar 7, 2010, at 5:43 AM, Tim Bunce wrote: Looks good, thanks. Pity you removed the `$dbh-{private_myapp_sql_mode}` bit, though, as that's required when using Cconnect_cached(), which you almost certainly are doing if you

Re: Time to Document Callbacks

2010-03-07 Thread David E. Wheeler
On Mar 7, 2010, at 3:27 PM, Tim Bunce wrote: Uh, yeah, I just looked at the code. Sometimes I confuse myself. I think that's a bug. I always intended connected() to be used as an on-new-physical-connection-established hook. Any objections to making it so? Not from me, but you might get

Re: HTTP Authentication for Gofer

2010-03-07 Thread Henri Asseily
On 3/7/2010 11:11 PM, Stuart Johnston wrote: Pass userid and a hash of userid and password. The server uses the password to hash userid and password and tests for equality. That's something similar to what Amazon and others do. The idea here is to add support for Basic HTTP Authentication,