Re: Time to Document Callbacks

2010-03-08 Thread Martin Evans
Tim Bunce wrote: On Sun, Mar 07, 2010 at 10:29:29AM -0800, David E. Wheeler wrote: On Mar 7, 2010, at 5:43 AM, Tim Bunce wrote: Looks good, thanks. Pity you removed the `$dbh-{private_myapp_sql_mode}` bit, though, as that's required when using Cconnect_cached(), which you almost certainly

Re: Time to Document Callbacks

2010-03-07 Thread Tim Bunce
On Sat, Mar 06, 2010 at 04:07:09PM -0800, David E. Wheeler wrote: On Mar 6, 2010, at 3:45 PM, Tim Bunce wrote: I was tempted to leave The cool thing is but opted to drop it as it doesn't match the tone of the rest of the docs - although they are rather dry :) Pity. Thought I was

Re: Time to Document Callbacks

2010-03-07 Thread David E. Wheeler
On Mar 7, 2010, at 5:43 AM, Tim Bunce wrote: Looks good, thanks. Pity you removed the `$dbh-{private_myapp_sql_mode}` bit, though, as that's required when using Cconnect_cached(), which you almost certainly are doing if you need this hack. Are you sure it's required when using connected()?

Re: Time to Document Callbacks

2010-03-07 Thread Tim Bunce
On Sun, Mar 07, 2010 at 10:29:29AM -0800, David E. Wheeler wrote: On Mar 7, 2010, at 5:43 AM, Tim Bunce wrote: Looks good, thanks. Pity you removed the `$dbh-{private_myapp_sql_mode}` bit, though, as that's required when using Cconnect_cached(), which you almost certainly are doing if you

Re: Time to Document Callbacks

2010-03-07 Thread David E. Wheeler
On Mar 7, 2010, at 3:27 PM, Tim Bunce wrote: Uh, yeah, I just looked at the code. Sometimes I confuse myself. I think that's a bug. I always intended connected() to be used as an on-new-physical-connection-established hook. Any objections to making it so? Not from me, but you might get

Re: Time to Document Callbacks

2010-03-06 Thread Tim Bunce
On Tue, Mar 02, 2010 at 05:08:21PM -0800, David E. Wheeler wrote: Howdy, I've just committed r13835, which documents Callbacks. Yay! A few notes: Great. Thanks! * Tim, you earlier said: I could arrange for Callbacks to only apply to methods called by the applicationi, and not to

Re: Time to Document Callbacks

2010-03-06 Thread David E. Wheeler
On Mar 6, 2010, at 3:45 PM, Tim Bunce wrote: I was tempted to leave The cool thing is but opted to drop it as it doesn't match the tone of the rest of the docs - although they are rather dry :) Pity. Thought I was starting to change that. ;-P I've made assorted edits and added some extra

Re: Time to Document Callbacks

2010-03-02 Thread David E. Wheeler
Howdy, I've just committed r13835, which documents Callbacks. Yay! A few notes: * Tim, you earlier said: I could arrange for Callbacks to only apply to methods called by the applicationi, and not to 'nested calls'. That's a fairly major change after this length of time but given the limited

Re: Time to Document Callbacks

2009-10-30 Thread Tim Bunce
On Thu, Oct 29, 2009 at 05:10:07PM -0700, David E. Wheeler wrote: On Oct 29, 2009, at 4:24 PM, Tim Bunce wrote: I could arrange for Callbacks to only apply to methods called by the applicationi, and not to 'nested calls'. That's a fairly major change after this length of time but given the

Re: Time to Document Callbacks

2009-10-28 Thread Tim Bunce
On Tue, Oct 27, 2009 at 06:07:46PM -0700, David E. Wheeler wrote: On Oct 27, 2009, at 3:24 PM, Tim Bunce wrote: The simplest thing that could possibly work is probably: $dbh-{Callbacks} = { method_foo = sub { ... }, method_bar = sub { ... }, ChildCallbacks = {

Re: Time to Document Callbacks

2009-10-28 Thread David E. Wheeler
On Oct 28, 2009, at 2:59 AM, Tim Bunce wrote: That looks nice. Are STHs the only things that are children? DBHs are children of DRHs (but I try to avoid talking about DRHs). Yes, let's pretend they don't exist here. Here's a deal: you write some tests for ChildCallbacks in t/70callbacks.t

Re: Time to Document Callbacks

2009-10-28 Thread David E. Wheeler
On Oct 28, 2009, at 10:26 AM, David E. Wheeler wrote: Here's a deal: you write some tests for ChildCallbacks in t/70callbacks.t and I'll implement them. Deal. Done in r13445. Best, David

Re: Time to Document Callbacks

2009-10-27 Thread Tim Bunce
On Tue, Oct 27, 2009 at 12:50:15PM -0700, David E. Wheeler wrote: On Oct 26, 2009, at 1:59 PM, Tim Bunce wrote: It output nothing. When I uncommented that second-to-last line, it output Set in STH. So it seems that a callback added to the dbh for a statement method name does not end up

Re: Time to Document Callbacks

2009-10-26 Thread Tim Bunce
On Sun, Oct 25, 2009 at 10:24:57PM -0700, David E. Wheeler wrote: On Oct 24, 2009, at 2:50 PM, Tim Bunce wrote: Callbacks are handled by the method dispatcher so all method names are valid (so don't bother trying to list them in the docs :) Plus the two special cases for connect_cached:

Re: Time to Document Callbacks

2009-10-25 Thread David E. Wheeler
On Oct 24, 2009, at 2:50 PM, Tim Bunce wrote: Callbacks are handled by the method dispatcher so all method names are valid (so don't bother trying to list them in the docs :) Plus the two special cases for connect_cached: 'connect_cached.new' and 'connect_cached.reused'. (There's also '*'

Re: Time to Document Callbacks

2009-10-25 Thread David E . Wheeler
On Oct 25, 2009, at 10:24 PM, David E. Wheeler wrote: It output nothing. When I uncommented that second-to-last line, it output Set in STH. So it seems that a callback added to the dbh for a statement method name does not end up getting passed on to the statement handle. So I guess the

Re: Time to Document Callbacks

2009-10-24 Thread Tim Bunce
On Sat, Oct 24, 2009 at 08:45:42AM -0700, David E. Wheeler wrote: Tim, I think it's high time we documented callbacks. I'm pretty sure the DBIx::Class folks are going to want to make use of them shortly. I'd be happy to contribute the docs. Great! Is there a way to get a list of all