Bug#940167: Limitation on VG name in setup-storage?

2019-09-19 Thread Andrew Ruthven
Hi Thomas, Looking at the disk_config file again, I'm not actually making any LVs inside the VG (they're made later when KVM instances are spun on up on these machines). Removing \- works okay for creating a VG with a hyphen in the name. Cheers, Andrew On Fri, 2019-09-13 at 11:45 +0200, Thomas

Bug#940167: Limitation on VG name in setup-storage?

2019-09-13 Thread Thomas Lange
Hi Andrew, you've said that removing \- from the regex works for you. I cannot reproduce this. When I use a vg name like vg-ssd7 I get the error ERROR (line 13): Invalid volume: Was expecting /^vg\s+/, or /^raid([0156]|10)\s+/, or /^btrfs

Bug#940167: Limitation on VG name in setup-storage

2019-09-13 Thread Thomas Lange
Maybe this code in Parser.pm in line 936 is responsible for the limitation: name: m{^([^/,\s\-]+)} You could try to remove \- and see if setup-storage is still working. -- regards Thomas

Bug#940167: Limitation on VG name in setup-storage

2019-09-13 Thread Thomas Lange
Package: fai-setup-storage >From a FAI user: When we manually create them, we tend to name our VGs for SSDs as: vg- ssd[0-9]+ . However, setup-storage doesn't like that and ends up confused with the colums on the vg line in the disk_config file. Would it be able possible to have VG names allow