Bug#608829: dpkg-dev - dpkg-source rejects valid patch files

2011-01-04 Thread Guillem Jover
Hi! On Mon, 2011-01-03 at 21:41:57 +0100, Raphael Hertzog wrote: On Mon, 03 Jan 2011, Bastian Blank wrote: I don't know whether I'm going to accept this request. I'm rather enclined to tag it wontfix. But I welcome supplementary feedback. Okay, another nail in the cofin of the quilt

Bug#608829: dpkg-dev - dpkg-source rejects valid patch files

2011-01-03 Thread Bastian Blank
Package: dpkg-dev Version: 1.15.8.7 Severity: important dpkg-source rejects valid patch files: | dpkg-source: error: diff `xen/debian/patches/upstream-21334:993458f6c5a0+21405:ae381a864b4f' patches file xen/xen/arch/x86/mm/hap/p2m-ept.c twice Unified diff files are applied from the start to

Bug#608829: dpkg-dev - dpkg-source rejects valid patch files

2011-01-03 Thread Raphael Hertzog
severity 608829 normal thanks On Mon, 03 Jan 2011, Bastian Blank wrote: Severity: important It's not a major usability problem... dropping to normal. dpkg-source rejects valid patch files: | dpkg-source: error: diff `xen/debian/patches/upstream-21334:993458f6c5a0+21405:ae381a864b4f'

Bug#608829: dpkg-dev - dpkg-source rejects valid patch files

2011-01-03 Thread Bastian Blank
On Mon, Jan 03, 2011 at 08:52:26PM +0100, Raphael Hertzog wrote: On Mon, 03 Jan 2011, Bastian Blank wrote: dpkg-source rejects valid patch files: | dpkg-source: error: diff `xen/debian/patches/upstream-21334:993458f6c5a0+21405:ae381a864b4f' patches file xen/xen/arch/x86/mm/hap/p2m-ept.c

Bug#608829: dpkg-dev - dpkg-source rejects valid patch files

2011-01-03 Thread Raphael Hertzog
On Mon, 03 Jan 2011, Bastian Blank wrote: It is a crafted file. It consists of two appended diffs. Why not use two diffs instead? diff.gz is never hand-generated, the contents of debian/patches are. If they may not, you have to document it. True. quilt and patch applies this patch

Bug#608829: dpkg-dev - dpkg-source rejects valid patch files

2011-01-03 Thread Jonathan Nieder
Raphael Hertzog wrote: On Mon, 03 Jan 2011, Bastian Blank wrote: Unified diff files are applied from the start to the end, file by file. There is no notion of duplicate files in it. While such files are valid patch files, diff will never generate such a patch. So it's a sign either of a