Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-05-05 Thread Giulio Paci
Il 09/04/2013 12:59, Jakub Wilk ha scritto: Lintian emits: X: libmitlm0: shlib-calls-exit usr/lib/libmitlm.so.0.0.0 I believe this is true-positive. exit() is indeed called in some methods that are part of public API: NgramLM::Initialize NgramModel::LoadComputedFeatures They should

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-04-09 Thread Jakub Wilk
Lintian emits: X: libmitlm0: shlib-calls-exit usr/lib/libmitlm.so.0.0.0 I believe this is true-positive. exit() is indeed called in some methods that are part of public API: NgramLM::Initialize NgramModel::LoadComputedFeatures They should probably throw an exception instead. Also, printing

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-04-08 Thread Jakub Wilk
tests/data/test1_ref has a .svn/ subdirectory. I don't suppose this is intentional... -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-04-08 Thread Giulio Paci
Il 08/04/2013 21:43, Jakub Wilk ha scritto: tests/data/test1_ref has a .svn/ subdirectory. I don't suppose this is intentional... No it is not... Just a small error in Makefile.am. It will not be there in future releases. Thank you very much. -- To UNSUBSCRIBE, email to

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-04-07 Thread Giulio Paci
Il 06/04/2013 23:47, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2013-03-27, 12:18: - there is no need to run autotools anymore Please do run them anyway. Done. - a very basic test suite is run Use LC_ALL instead of LANG. LANG, unlike LC_ALL, can be overriden by various

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-04-06 Thread Jakub Wilk
* Giulio Paci giuliop...@gmail.com, 2013-03-27, 12:18: Finally I released (upstream) mitlm 0.4.1 with this new ABI. I have just updated the Debian package files as well: - there are no patches anymore (all have been included upstream) Good. - there is no need to run autotools anymore

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-03-27 Thread Giulio Paci
Il 22/02/2013 20:26, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2013-02-21, 12:11: Any chance upstream makes a release with this new ABI soon? I just asked. Waiting for a reply. Paul and I decided that I will be responsible for the next upstream release, so yes, we can expect

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-02-22 Thread Jakub Wilk
* Giulio Paci giuliop...@gmail.com, 2013-02-21, 12:11: Any chance upstream makes a release with this new ABI soon? I just asked. Waiting for a reply. Paul and I decided that I will be responsible for the next upstream release, so yes, we can expect a release with this new ABI soon, Great.

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-02-21 Thread Giulio Paci
On 21/02/2013 02:26, Giulio Paci wrote: Il 20/02/2013 20:41, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2013-02-13, 02:26: 1009_add_mitlm_namespace.patch. Any chance upstream makes a release with this new ABI soon? I just asked. Waiting for a reply. Paul and I decided that

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-02-20 Thread Jakub Wilk
* Giulio Paci giuliop...@gmail.com, 2013-02-13, 02:26: 1009_add_mitlm_namespace.patch. Any chance upstream makes a release with this new ABI soon? I also introduced patches 1010_fix_segmentation_fault_on_interpolate_ngram.patch and 1011_replace_hashmap_with_unordered_map.patch. It would

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-02-20 Thread Giulio Paci
Il 20/02/2013 20:41, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2013-02-13, 02:26: 1009_add_mitlm_namespace.patch. Any chance upstream makes a release with this new ABI soon? I just asked. Waiting for a reply. I also introduced patches

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-02-12 Thread Giulio Paci
Il 01/02/2013 21:09, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2013-02-01, 00:03: Speaking of which, I had a look at the list of exported symbols, and it's kinda messy... Some symbols have very generic names. Upstream should consider putting them into a namespace. I think

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-02-01 Thread Jakub Wilk
* Giulio Paci giuliop...@gmail.com, 2013-02-01, 00:03: To improve the manpages I improved the command line help messages (1008_improve_command_line_help.patch) Doesn't this patch break ABI? You are right, however upstream never provided shared libraries, we are still API compatible with

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-01-31 Thread Jakub Wilk
* Giulio Paci giuliop...@gmail.com, 2013-01-30, 03:27: To improve the manpages I improved the command line help messages (1008_improve_command_line_help.patch) Doesn't this patch break ABI? Speaking of which, I had a look at the list of exported symbols, and it's kinda messy... Some symbols

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-01-31 Thread Giulio Paci
Il 31/01/2013 20:10, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2013-01-30, 03:27: To improve the manpages I improved the command line help messages (1008_improve_command_line_help.patch) Doesn't this patch break ABI? You are right, however upstream never provided shared

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-01-30 Thread Giulio Paci
Il 30/01/2013 03:27, Giulio Paci ha scritto: Il 28/01/2013 20:57, Jakub Wilk ha scritto: 1007_escape_filename.patch The latter fixes .bz2 handling and should work on Windows as well (although I have not tested it yet on a real Windows system). I have tested the patch on Windows as well. I

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-01-29 Thread Giulio Paci
Il 28/01/2013 20:57, Jakub Wilk ha scritto: Do you think upstream could be persuaded to write a test suite? I think so. The manpages could use some improvements: To improve the manpages I improved the command line help messages (1008_improve_command_line_help.patch) and implemented a script

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-01-28 Thread Jakub Wilk
Do you think upstream could be persuaded to write a test suite? The manpages could use some improvements: - There shouldn't be a colon or an empty line between option names and their descriptions. - There doesn't seem to be any indication if an option takes an argument or not. - What does

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-01-14 Thread Jakub Wilk
* Giulio Paci giuliop...@gmail.com, 2013-01-14, 01:06: The ZFile implementation worries me... Do I read it correctly that filenames are passed to shell without any escaping? Unfortunately you are right. Do you have a quick fix in mind? Escape them? :) It's not difficult if you care only

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-01-14 Thread Giulio Paci
Il 14/01/2013 20:04, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2013-01-14, 01:06: The ZFile implementation worries me... Do I read it correctly that filenames are passed to shell without any escaping? Unfortunately you are right. Do you have a quick fix in mind? Escape

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

2013-01-13 Thread Giulio Paci
* Jakub Wilk jw...@debian.org, 2013-01-10, 22:15: * Giulio Paci giuliop...@gmail.com, 2013-01-08, 23:27: I completed the generic implementation, added an implementation based on __builtin_clzl and implemented a selection mechanism in configure.ac. The priority is: x86 implementation

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2013-01-10 Thread Jakub Wilk
* Giulio Paci giuliop...@gmail.com, 2013-01-08, 23:27: Does debian/patches/compilation_fixes really fix only compilation on Debian systems? I split this patch into several patches. Thanks! I completed the generic implementation, added an implementation based on __builtin_clzl and

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2013-01-08 Thread Giulio Paci
Il 08/01/2013 02:06, Jakub Wilk ha scritto: Does debian/patches/compilation_fixes really fix only compilation on Debian systems? I split this patch into several patches. I see several problems with the __fls function: - You can't use __ in your own identifiers; such names are reserved. The

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2013-01-07 Thread Jakub Wilk
Does debian/patches/compilation_fixes really fix only compilation on Debian systems? I see several problems with the __fls function: - You can't use __ in your own identifiers; such names are reserved. - The implementation uses x86 assembly. - The unsigned long - int typecast looks redundant to

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2013-01-02 Thread Jakub Wilk
* Giulio Paci giuliop...@gmail.com, 2013-01-02, 01:40: README says The vector library is partially derived from the Flexible Library for Efficient Numerical Solutions by Michael Lehn, but this information is not included in the copyright file. I added information in copyright file, but I am not

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2013-01-02 Thread Giulio Paci
Il 02/01/2013 15:00, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2013-01-02, 01:40: README says The vector library is partially derived from the Flexible Library for Efficient Numerical Solutions by Michael Lehn, but this information is not included in the copyright file. I

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2013-01-02 Thread Jakub Wilk
* Giulio Paci giuliop...@gmail.com, 2013-01-02, 01:40: dh_shlibdeps -plibmitlm0 dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libmitlm0/usr/lib/libmitlm.so.0.0.0 was not linked against libquadmath.so.0 (it uses none of the library's symbols) This warning is

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2013-01-02 Thread Giulio Paci
Il 02/01/2013 23:33, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2013-01-02, 01:40: dh_shlibdeps -plibmitlm0 dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libmitlm0/usr/lib/libmitlm.so.0.0.0 was not linked against libquadmath.so.0 (it uses none

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2013-01-01 Thread Giulio Paci
Il 31/12/2012 21:21, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2012-04-07, 13:30: http://mentors.debian.net/debian/pool/main/m/mitlm/mitlm_0.4-1.dsc Moved to git://anonscm.debian.org/collab-maint/mitlm.git README says The vector library is partially derived from the Flexible

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2012-12-31 Thread Jakub Wilk
* Giulio Paci giuliop...@gmail.com, 2012-04-07, 13:30: http://mentors.debian.net/debian/pool/main/m/mitlm/mitlm_0.4-1.dsc README says The vector library is partially derived from the Flexible Library for Efficient Numerical Solutions by Michael Lehn, but this information is not included in

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

2012-04-07 Thread Giulio Paci
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package mitlm * Package name: mitlm Version : 0.4 Upstream Author : Bo-June (Paul) Hsu bo...@mit.edu * URL : http://code.google.com/p/mitlm/ * License : BSD