Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources

2008-08-15 Thread Daniel Baumann
tags 494640 +pending thanks This is fixed now in git. If the settings are left on default, the binary image does not get tainted by live-helper specific files in /etc/apt/apt.conf.d/. If the settings are set to non-default values by the choice of the user, the live-helper specific files in

Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources

2008-08-13 Thread Otavio Salvador
Jeremy [EMAIL PROTECTED] writes: I am just curious as to the idea of a 'tainted image'. It seems to me that it would not allow a user to customize their image. Does everything have to be the default debian setting? I would hope that there is an option to not install recommended packages,

Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources

2008-08-13 Thread Chris Lamb
Hi Jeremy/Otavio, Jeremy [EMAIL PROTECTED] writes: I am just curious as to the idea of a 'tainted image'. It seems to me that it would not allow a user to customize their image. Well, hmm. So to expand on what I mentioned in my previous email, there is a slight distinction in that whilst

Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources

2008-08-13 Thread Otavio Salvador
Chris Lamb [EMAIL PROTECTED] writes: So yes, I think that the binary image should inherit the APT_RECOMMENDS setting. I will commit that later this evening unless Daniel shouts at me otherwise. Ok. I had misunderstood the discussion. I agree with you too. -- O T A V I OS A L V A

Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources

2008-08-12 Thread Jeremy
On Mon, Aug 11, 2008 at 9:03 PM, Chris Lamb [EMAIL PROTECTED] wrote: tags 494640 + pending thanks Jeremy wrote: I don't believe I was missing any script because I first got this problem when running lh_chroot, then lh_binary. However, I was doing many retries (mostly lh_build) on it

Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources

2008-08-12 Thread Daniel Baumann
Chris Lamb wrote: I've committed a change to live-helper in Git which fixes this issue. this fix does actually do more harm than it solves - it injects the apt settings into the binary image, which is not acceptable as it produces tainted images. we need to be very carefull here and pay

Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources

2008-08-11 Thread Chris Lamb
Jeremy Salwen wrote: I found that it was doing an apt-get dist-upgrade which was making it install recommended packages (I believe the default for apt?). This was contrary to the file rootdir/config/common in which I had the line LH_APT_RECOMMENDS=disabled Hm, whilst `lh_chroot_sources`

Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources

2008-08-11 Thread jeremy salwen
Package: live-helper Version: 1.0~a48-1 Severity: normal I have a strange feeling that this might be a 'feature'. When I ran 'lh_chroot_sources install' (with all previous scripts run without errors) or any script which calls it, I found it was installing packages I didn't request. With

Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources

2008-08-11 Thread Jeremy
On Mon, Aug 11, 2008 at 1:04 AM, Chris Lamb [EMAIL PROTECTED] wrote: Jeremy Salwen wrote: I found that it was doing an apt-get dist-upgrade which was making it install recommended packages (I believe the default for apt?). This was contrary to the file rootdir/config/common in which I

Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources

2008-08-11 Thread Chris Lamb
tags 494640 + pending thanks Jeremy wrote: I don't believe I was missing any script because I first got this problem when running lh_chroot, then lh_binary. However, I was doing many retries (mostly lh_build) on it previously, with only a lh_clean --purge in between. First, thank you for