[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721800#comment-13721800 ] ASF subversion and git services commented on DERBY-673: --- Commit

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13719308#comment-13719308 ] Knut Anders Hatlen commented on DERBY-673: -- Thanks, Dag. Patch #3 looks good to

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13719318#comment-13719318 ] ASF subversion and git services commented on DERBY-673: --- Commit

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718115#comment-13718115 ] Dag H. Wanvik commented on DERBY-673: - Thanks, Knut. Yes, it is intentional, if

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718153#comment-13718153 ] Knut Anders Hatlen commented on DERBY-673: -- Maybe something like this would work,

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13716302#comment-13716302 ] Knut Anders Hatlen commented on DERBY-673: -- I see that not all classes that define

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13715038#comment-13715038 ] Dag H. Wanvik commented on DERBY-673: - Thanks, Knut. I agree on the matter of

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713610#comment-13713610 ] Knut Anders Hatlen commented on DERBY-673: -- Thanks for the patches, Dag. I think

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712337#comment-13712337 ] Dag H. Wanvik commented on DERBY-673: - Uploading two alternate patches,

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708011#comment-13708011 ] ASF subversion and git services commented on DERBY-673: --- Commit

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13695409#comment-13695409 ] ASF subversion and git services commented on DERBY-673: --- Commit

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13695442#comment-13695442 ] ASF subversion and git services commented on DERBY-673: --- Commit

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13694549#comment-13694549 ] ASF subversion and git services commented on DERBY-673: --- Commit

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13694553#comment-13694553 ] Dag H. Wanvik commented on DERBY-673: - Thanks, Knut. Uploading version

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13695255#comment-13695255 ] ASF subversion and git services commented on DERBY-673: --- Commit

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13693050#comment-13693050 ] Knut Anders Hatlen commented on DERBY-673: -- The patch looks like a good

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690105#comment-13690105 ] Dag H. Wanvik commented on DERBY-673: - Committed version 3 to trunk as 1495305.

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690166#comment-13690166 ] ASF subversion and git services commented on DERBY-673: --- Commit

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689253#comment-13689253 ] Dag H. Wanvik commented on DERBY-673: - Rick; the C_NodeNames class is gone. Most of the

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687934#comment-13687934 ] Rick Hillegas commented on DERBY-673: - Thanks for this major overhaul, Dag. After this

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687941#comment-13687941 ] Knut Anders Hatlen commented on DERBY-673: -- Thanks for the patch, Dag. I think

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13675542#comment-13675542 ] Dag H. Wanvik commented on DERBY-673: - Uploading a partial proof-of-concept patch for

[jira] [Commented] (DERBY-673) Get rid of the NodeFactory

[ https://issues.apache.org/jira/browse/DERBY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13666116#comment-13666116 ] Knut Anders Hatlen commented on DERBY-673: -- Strongly typed constructors or init()

[jira] Commented: (DERBY-673) Get rid of the NodeFactory

[ http://issues.apache.org/jira/browse/DERBY-673?page=comments#action_12358697 ] Daniel John Debrunner commented on DERBY-673: - Would this change allow some rationalization of the type hierachy for nodes? Every node is a sub-class of

[jira] Commented: (DERBY-673) Get rid of the NodeFactory

[ http://issues.apache.org/jira/browse/DERBY-673?page=comments#action_12358703 ] Rick Hillegas commented on DERBY-673: - This change should not preclude and I expect it would facilitate reorganizations of the type hierarchy for nodes in the abstract

[jira] Commented: (DERBY-673) Get rid of the NodeFactory

[ http://issues.apache.org/jira/browse/DERBY-673?page=comments#action_12358704 ] Daniel John Debrunner commented on DERBY-673: - The rational is that some current nodes are not really QueryTreeNodes, but common data elements for real nodes.

[jira] Commented: (DERBY-673) Get rid of the NodeFactory

[ http://issues.apache.org/jira/browse/DERBY-673?page=comments#action_12358707 ] Rick Hillegas commented on DERBY-673: - TableName doesn't have a useful optimize() or generate() method but it does have a bind() method. It looks like a reasonable AST

[jira] Commented: (DERBY-673) Get rid of the NodeFactory

[ http://issues.apache.org/jira/browse/DERBY-673?page=comments#action_12358738 ] Daniel John Debrunner commented on DERBY-673: - Maybe, but the bind() method doesn't actually bind the node, it just fetches the schema descriptor, which is already