Re: patch to enable the BOOLEAN datatype

2005-12-08 Thread Rick Hillegas
Hi Dan, I did it this way so that JUnit suites and standalone tests can share initialization code for running under the old test harness. There are other solutions to the problem: the shared code could go into a separate helper class or be factored into a superclass of DerbyJUnit. Each of

Re: patch to enable the BOOLEAN datatype

2005-12-07 Thread Daniel John Debrunner
Rick Hillegas wrote: I've clipped to jira 499 a patch enabling the BOOLEAN datatype. In BooleanTest.java, at line 400, and elsewhere you use java.lang.Short as the value to be checked for a SMALLINT type in assertRow. JDBC defines that SMALLINT maps to java.lang.Integer as an object type,

Re: patch to enable the BOOLEAN datatype

2005-12-07 Thread Daniel John Debrunner
Rick Hillegas wrote: I've clipped to jira 499 a patch enabling the BOOLEAN datatype. Could you explain the type hierarchy of the LangSuite and BooleanTest? LangSuite extends DerbyJUnitTest, but it's not a test it's a suite, is this a requirement of Junit? BooleanTest extends LangSuite, but

Re: patch to enable the BOOLEAN datatype

2005-12-07 Thread Rick Hillegas
Hi Dan, Thanks for looking at this patch. I like your suggestion that assertRow could do double duty, checking the primitive and object type of a returned column. I don't think it matters for this particular test case since all that's being checked is the correct casting of a boolean

Re: patch to enable the BOOLEAN datatype

2005-12-07 Thread Rick Hillegas
Hi Dan, I don't have any strong religion about the class hierarchy here. It is conceivable that there might be some special logic, useful only to language tests, which we might want to put in LangSuite. That's really my only reason for making BooleanTest extend LangSuite. However, there is

Re: patch to enable the BOOLEAN datatype

2005-12-07 Thread Daniel John Debrunner
Daniel John Debrunner wrote: LangSuite extends DerbyJUnitTest, but it's not a test it's a suite, is this a requirement of Junit? Any answer to this one? In my mind a suite is a set of tests, not a test so it should not inherit from DerbyJUnitTest. Dan.

patch to enable the BOOLEAN datatype

2005-12-06 Thread Rick Hillegas
I've clipped to jira 499 a patch enabling the BOOLEAN datatype. I still owe this feature's changes to the user docs. In addition to adding the BOOLEAN type, this patch does the following: o Centralizes product identifiers and DRDA datatypes in a single file of constants for use by both the