Re: [libreoffice-design] LibreOffice infobar - text inconsistencies
Hi, Just to note that someone has already fixed those inconsistencies -- thanks! So I don't need to make a patch now. Still, I am interested in doing an Easy Hack of some kind, to learn about (and document) the process... Maybe I'll try the German comments... Mike On 28/07/2017 13:06, Mike Saunders wrote: > Hi, > > Regarding: https://pbs.twimg.com/media/DF0TT5cXsAAh7hx.jpg > > A couple of inconsistencies: > > * The red line has "This Document" whereas the blue one has "This > document" (I think both should "document") > > * The yellow line has "ok" and the green one "Okay". For consistency > with the rest of the app, both should be "OK" > > Minor nit-picking, but if someone has a pointer where these strings are, > I can try to fix them myself (and learn more about LO dev in the process) > -- To unsubscribe e-mail to: design+unsubscr...@global.libreoffice.org Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://listarchives.libreoffice.org/global/design/ All messages sent to this list will be publicly archived and cannot be deleted
Re: [libreoffice-design] LibreOffice infobar - text inconsistencies
Hi Heiko, Thanks for all the pointers. I'm now setting up a fresh VM to go through the process of building LO, noting any steps that are especially difficult or not well documented on the wiki. Then I'll try to update these text strings and let you know how it goes... :-) Mike On 29/07/2017 10:41, Heiko Tietze wrote: > Hi Mike, > > the infobar is defined in sfx2/source/dialog/infobar.cxx (headers in > include/sfx2/infobar.hxx). The constructor is defined as > > SfxInfoBarWindow( vcl::Window* parent, const OUString& sId, > const OUString& sMessage, > InfoBarType infoBarType, > WinBits nMessageStyle); > > meaning you add the infobar text as a parameter, happening in > sfx2/source/doc/objserv.cxx with AppendInfoBar("signature", sMessage, > aInfoBarType) where sMessage comes from sMessage = > SfxResId(STR_SIGNATURE_BROKEN) which is a constant defined in > include/sfx2/strings.hrc - and, to cut the long story short, implemented by > Caolan on the introduction of gettext() with the correct sentence style > capitalization. > > The button is added to the infobar per pInfoBar->addButton(xBtn) having a > text set via xBtn->SetText(SfxResId(STR_SIGNATURE_SHOW)); (all in objserv.cxx > for signatures). The green bar was a temporary implementation by me to show > the green color for the success type but I don't remember any code for a > button, more likely I just overrode another call. But searching for the text > with https://opengrok.libreoffice.org returns no result. > > Hopefully you now start with your first easyhack :-) > > Cheers, > Heiko -- To unsubscribe e-mail to: design+unsubscr...@global.libreoffice.org Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://listarchives.libreoffice.org/global/design/ All messages sent to this list will be publicly archived and cannot be deleted
Re: [libreoffice-design] LibreOffice infobar - text inconsistencies
Hi Mike, the infobar is defined in sfx2/source/dialog/infobar.cxx (headers in include/sfx2/infobar.hxx). The constructor is defined as SfxInfoBarWindow( vcl::Window* parent, const OUString& sId, const OUString& sMessage, InfoBarType infoBarType, WinBits nMessageStyle); meaning you add the infobar text as a parameter, happening in sfx2/source/doc/objserv.cxx with AppendInfoBar("signature", sMessage, aInfoBarType) where sMessage comes from sMessage = SfxResId(STR_SIGNATURE_BROKEN) which is a constant defined in include/sfx2/strings.hrc - and, to cut the long story short, implemented by Caolan on the introduction of gettext() with the correct sentence style capitalization. The button is added to the infobar per pInfoBar->addButton(xBtn) having a text set via xBtn->SetText(SfxResId(STR_SIGNATURE_SHOW)); (all in objserv.cxx for signatures). The green bar was a temporary implementation by me to show the green color for the success type but I don't remember any code for a button, more likely I just overrode another call. But searching for the text with https://opengrok.libreoffice.org returns no result. Hopefully you now start with your first easyhack :-) Cheers, Heiko On 28.07.2017 13:06, Mike Saunders wrote: > Hi, > > Regarding: https://pbs.twimg.com/media/DF0TT5cXsAAh7hx.jpg > > A couple of inconsistencies: > > * The red line has "This Document" whereas the blue one has "This > document" (I think both should "document") > > * The yellow line has "ok" and the green one "Okay". For consistency > with the rest of the app, both should be "OK" > > Minor nit-picking, but if someone has a pointer where these strings are, > I can try to fix them myself (and learn more about LO dev in the process) > -- Dr. Heiko Tietze UX designer Tel. +49 (0)179/1268509 -- To unsubscribe e-mail to: design+unsubscr...@global.libreoffice.org Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://listarchives.libreoffice.org/global/design/ All messages sent to this list will be publicly archived and cannot be deleted