Re: IVYDE-382 proposed patch

2017-07-01 Thread Nicolas Lalevée
Hi Alexander, Yes, it would be really nice if you could create a page documenting the new feature. I have just migrated the documentation of IvyDE to asciidoc, so it will be easier to contribute. I have also squashed and rebased your work on this branch:

Re: IVYDE-382 proposed patch

2017-07-01 Thread alexander . blaas
Good afternoon, sorry for the delay in my reply. The last two weeks I was very busy with exams and work. We are glad that our proposed patch found its way back to the main development path and that perhaps it will be a part of a following release :-) Is there a way we can support you?

Re: IVYDE-382 proposed patch

2017-06-14 Thread Nicolas Lalevée
Hi, For some reason git apply was refusing to process the patch and was just returning an error: corrupt patch at line 1964 So I played with git commands and work with the sources available on github. I have create a branch on the ASF repo, ivyDECredentials, which has one commit which squash

Re: IVYDE-382 proposed patch

2017-06-13 Thread J Pai
Hi Alexander, I actually just realized that your initial mail actually had a patch file attached. I didn’t notice that before and only today noticed it while looking at the mail list archive. So assuming this applies cleanly on latest master branch of IvyDE, I think this should be fine too,

Re: IVYDE-382 proposed patch

2017-05-25 Thread J Pai
Hi Alexander, Thank you for volunteering to provide this feature patch. I had a look a the repo you pointed to and read the README. It does seem to contain a good amount of work in that branch in multiple commits. To make it easier for whoever will decide about merging these to upstream

IVYDE-382 proposed patch

2017-05-25 Thread alexander . blaas
Dear Sir or Madam, as it was suggested in https://issues.apache.org/jira/browse/IVYDE-382?focusedCommentId=16018847=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16018847, we are sending you our proposed patch for https://issues.apache.org/jira/browse/IVYDE-382. The