Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/38
>> requireCommonBaseDir:
>>could we replace firstPath by base==null?
>> line 115: additional comment:
>>'fail fast: ...'
>>line 117: 'fin
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/38
>> Maybe we could extract the method into FileUtil later.
I went ahead and moved it to `FileUtil` since it does make sense for it to
be there.
---
If your project is set up for i
Github user jaikiran closed the pull request at:
https://github.com/apache/ant-ivy/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/38
Closing this PR, because looking at the commits in master branch, it looks
like Jan already pulled in this commit. Thanks @janmaterne
---
If your project is set up for it, you can reply
Github user jaikiran closed the pull request at:
https://github.com/apache/ant-ivy/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant-ivy/pull/46
Fix the build of tutorials
The commit here fixes the tutorials build which currently is running into
build failures.
You can merge this pull request into a Git repository by running:
$ git
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant-ivy/pull/47
Move to asciidoc for documentation
This PR contains multiple commits, which together are a first step towards
moving the current `xooki` backed documentation to `asciidoc`. The commits
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant-ivy/pull/44
IVY-1561 - Enhancement to take into account environment and system
properties while evaluation Maven pom property references
The commit in this PR introduces the enhancement requested in
https
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/45
Thanks for the PR. Merged.
P.S: Someone else will have to close this PR, till I understand how I can
auto-close this or get access to a close button.
---
If your project is set up
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/30
Jenkins seems to have picked up the disabled Matrix job for this run. I'll
wait for that to get sorted out.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/38
Do not merge
Testing Jenkins integration. Do not merge this PR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaikiran/ant dummy
Alternatively
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/38
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user jaikiran reopened a pull request:
https://github.com/apache/ant/pull/38
Do not merge
Testing Jenkins integration. Do not merge this PR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaikiran/ant dummy
Alternatively
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/38
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/39
[1.9.x branch] BZ-58589 Preserve last modified time (if asked for) for
files uploaded by SFTP
The commit here adds support for preserving the last modified time on files
when uploaded via SFTP
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/39
Ignore the Jenkins job message please - I haven't yet got it configured
correctly.
---
-
To unsubscribe, e-mail: dev-unsubscr
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/37
[1.9.x branch] BZ-60644 Fix file corruption during copy task
The commit here includes a fix for the issue reported in
https://bz.apache.org/bugzilla/show_bug.cgi?id=60644. As described in that
issue
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/37#discussion_r141594830
--- Diff: src/main/org/apache/tools/ant/util/ResourceUtils.java ---
@@ -666,6 +666,14 @@ private static void copyWithFilterSets(final Resource
source, final
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/37
Tests against various JDK versions against Windows and Linux went fine
without any regressions. Will go ahead and merge this now
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/39
Merged to both 1.9.x and master branches.
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/59
Thank you for the PR and sorry it took a while to merge this. I have
included the change you suggested in this PR with a minor change and merged it
upstream.
---
If your project is set up
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/59
>> thanks @jaikiran do you have an Estimated Time for next release
containing this bugfix?
@apupier - the plan is to have it soon (no specific date yet). We are
almost at the la
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/60#discussion_r136327295
--- Diff: build-release.xml ---
@@ -179,11 +180,11 @@
-
+
--- End diff
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/53
Thanks! This is now merged to upstream.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/52
[master] Fix BZ-58451 BZ-58833
The commit here fixes the issues reported in:
https://bz.apache.org/bugzilla/show_bug.cgi?id=58833
https://bz.apache.org/bugzilla/show_bug.cgi?id=58451
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/52
Have updated the PR to fix the test case so that it runs the correct
command on Windows, during the tests.
---
-
To unsubscribe, e
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/51
Thanks for reviewing. Merged to master branch. Will backport it to 1.9.x
too.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/51
>> an alternative would be to only wrap the stream inside of zipFile if
mark wasn't supported.
@bodewig, I actually liked your idea. So I did an additional change in this
commit (PR ha
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/48
BZ-61718 Upgrade to 0.1.54 of Jsch library
The commit here upgrades Jsch library dependency to `0.1.54` (which is the
latest released version) as requested in
https://bz.apache.org/bugzilla
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/49
Committed to master branch
https://github.com/apache/ant/commit/cefdbd398d8e310b218f9e2ca6f0b7fb13eddbb9
---
-
To unsubscribe, e
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/49
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155941213
--- Diff: src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java ---
@@ -30,6 +30,8 @@
* a symbolic link based on the absent support for them in Java
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/49
>> Overall I'm in favor of this change and if you want to spend the time on
fixing the bugzilla issue in a Java5 friendly way for 1.9.x that would
certainly be good - bit not something I
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/49
[master branch] - Fix BZ-58683
The commit here fixes the issue reported at
https://bz.apache.org/bugzilla/show_bug.cgi?id=58683.
This commit along with fixing the issue reported in that bug
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155941155
--- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java
---
@@ -500,18 +502,12 @@ private void doLink(String res, String lnk) throws
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155941080
--- Diff: manual/Tasks/symlink.html ---
@@ -26,7 +26,7 @@
Symlink
Description
- Manages symbolic links on Unix based platforms. Can be used
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155941101
--- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java
---
@@ -448,49 +432,67 @@ private void handleError(String msg
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155941095
--- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java
---
@@ -207,26 +198,30 @@ public void recreate() throws BuildException
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/38
retest this please
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/38
this is ok to test
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/38
retest this please
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/51
retest this please
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
GitHub user jaikiran reopened a pull request:
https://github.com/apache/ant/pull/51
[master] Changes for BZ-19516
As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the
change in this PR uses `java.io.BufferedInputStream` which can take an
underlying
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/51
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/38
retest this please
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
GitHub user jaikiran reopened a pull request:
https://github.com/apache/ant/pull/51
[master] Changes for BZ-19516
As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the
change in this PR uses `java.io.BufferedInputStream` which can take an
underlying
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/51
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/38
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/51
[master] Changes for BZ-19516
As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the
change in this PR uses `java.io.BufferedInputStream` which can take an
underlying `InputStream
GitHub user jaikiran reopened a pull request:
https://github.com/apache/ant/pull/38
Do not merge
Testing Jenkins integration. Do not merge this PR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaikiran/ant dummy
Alternatively
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/51
retest this please
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/38
retest this please
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/38
retest this please
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/52
@bodewig, do you think this change is OK? Any thoughts/concerns? I
understand that this is one of the central classes, so don't want to push this
if there's any concerns with this change
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant-antlibs-antunit/pull/1
Avoid potential thread safety issues in LogCapturer
This commit is prompted by the exception I saw in one of the Ant Jenkins
jobs which failed with:
```
/home/jenkins
Github user jaikiran commented on the issue:
https://github.com/apache/ant-antlibs-antunit/pull/1
Thank you. Merged.
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/55
this is ok to test
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/56
this is ok to test
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/58#discussion_r166183671
--- Diff: src/main/org/apache/tools/ant/taskdefs/Parallel.java ---
@@ -377,7 +377,7 @@ public synchronized void run() {
}
// now
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/58#discussion_r166183611
--- Diff: src/main/org/apache/tools/ant/listener/MailLogger.java ---
@@ -102,7 +102,7 @@
private static final String DEFAULT_MIME_TYPE = "text/
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/58
Overall, IMO, this can't be a general find/replace change and instead needs
to be checked for individuals places where the `StringBuffer` is used and
whether the change to `StringBuilder` will impact
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/57
@adamretter The test failure
https://builds.apache.org/job/Ant%20Github-PR-Windows/37/testReport/junit/org.apache.tools.ant.taskdefs.optional.junit/XMLResultAggregatorTest/testFrames/
looks related
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/57
Looks good to me. If @bodewig doesn't have any concerns with this change,
I'll go ahead and merge this, this week
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/66
@javabrett, thank you reporting as well as providing the fix for this. This
is now merged.
---
-
To unsubscribe, e-mail: dev
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/57
@adamretter, this is now merged and we have added your name (Adam Retter)
to our contributors list. If you want us to a use different name or not include
the name at all, please do let us know
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/68
There will be one soon. There's a discussion going on, in the mailing list
to work towards a release soon.
---
-
To unsubscribe
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/65
These changes don't solve the real issue. The details of this issue are
part of the discussion in ant dev mailing list, where I explained what the real
issue is. I do have a completely different
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/62#discussion_r166282397
--- Diff:
src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java ---
@@ -91,6 +91,9 @@ protected ResolvedResource
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/62#discussion_r167136873
--- Diff:
src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java ---
@@ -91,6 +91,9 @@ protected ResolvedResource
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/59
Thanks for the PR @jpountz. Can we add you to our contributors file,
crediting you for this fix? If yes, what would you like your name to be
mentioned
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/61
retest this please
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/60
retest this please
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/61
Thank for you the PR. This is now merged
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/60
JUnit 5 support - A new junitlauncher task
This is the initial working version of a new `junitlauncher` task that
support using JUnit 5 framework for testing, within Ant build files. The commit
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r169624865
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r169624837
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r169626791
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r168983118
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java
---
@@ -0,0 +1,139 @@
+package
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r168983237
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java
---
@@ -0,0 +1,139 @@
+package
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/60
@bodewig, Thank you very much for the review. Based on the review comments,
I have updated the PR with additional separate commits (for easier reference).
I'll be squashing all these commits together
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/62
this is ok to test
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/62
Hi @reudismam, Is there some reference documentation which states that this
construct performs better? My brief check of the JLS just showed a note which
states that some implementations _might_
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r169625878
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r169624475
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/61
this is ok to test
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/52
Thanks Stefan (@bodewig) for the review. The tests (existing and a new one
in this PR) are passing on both *nix and Windows. Given that this change does
address the issues noted in the referenced
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/52
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/52
This is now commit to both master and 1.9.x branches
https://github.com/apache/ant/commit/6c860e0036a8742f4cc35e3e6a8e595e42804c89
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/66
this is ok to test
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/73
retest this please
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/73
Tests have passed https://builds.apache.org/job/Ivy-GithubPR/361/
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/73
>> By the way, latest commits 43ddccb and 5918182 introduced nested
"javaversion" element, which breaks Jenkins CI build; I had to remove this for
both
I just fixed the
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/73
>> Should I reopen PR?
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail:
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/73
retest this please
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/67
Support for fork mode in junitlauncher
The commit here introduces support for launching the JUnit tests, through
`junitlauncher` task, in forked mode.
I decided to keep the fork aspects
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/67
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/67
>> Looks good at first glance, I'll have a more thorough look sometime
before we cut the next release.
Thank you.
>> The new files need to have license headers added.
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/68
bz-62655 throw a BuildException from augment task
Reference https://bz.apache.org/bugzilla/show_bug.cgi?id=62655
The manual of the augment task[1] states that it's supposed to throw
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/64
@jnsnkrllive I've merged this into 1.9.x as well as master branches. Thank
you for the PR. I've also included your name "Karl Jansen" in our contributors
list. If you like to use a different
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/65
I picked the commit which updated just the documentation and merged it to
upstream.
---
-
To unsubscribe, e-mail: dev-unsubscr
101 - 200 of 709 matches
Mail list logo
