dbd p[v]b functions problem

2010-02-04 Thread Bob Rossi
Hi, I've been playing with the dbd_sqlite3_pvbselect function today and found what I believe to be several major issue. Please note, this issue is probably across all database subsystems. The function looks like, static int dbd_sqlite3_pvbselect(apr_pool_t * pool, apr_dbd_t * sql,

Re: dbd p[v]b functions problem

2010-02-04 Thread Bojan Smojver
On Thu, 2010-02-04 at 17:44 -0500, Bob Rossi wrote: Is this a design decision or a flaw? Design decision. Just to be clear, you are getting segfaults when you are NOT passing pointers in, correct? If you are doing that, you are misusing the API and causing the segfaults. -- Bojan

Re: dbd p[v]b functions problem

2010-02-04 Thread Bob Rossi
On Fri, Feb 05, 2010 at 09:51:59AM +1100, Bojan Smojver wrote: On Thu, 2010-02-04 at 17:44 -0500, Bob Rossi wrote: Is this a design decision or a flaw? Design decision. Just to be clear, you are getting segfaults when you are NOT passing pointers in, correct? Correct. If you are

Re: dbd p[v]b functions problem

2010-02-04 Thread Bojan Smojver
On Thu, 2010-02-04 at 18:06 -0500, Bob Rossi wrote: If you are bent on preserving this interface, does a new interface make sense, that allows the user to pass in the parameters, without passing in addresses? Nobody is bent on anything, although there were reasons to do it this way (search

Re: dbd p[v]b functions problem

2010-02-04 Thread Bob Rossi
On Fri, Feb 05, 2010 at 10:09:47AM +1100, Bojan Smojver wrote: On Thu, 2010-02-04 at 18:06 -0500, Bob Rossi wrote: If you are bent on preserving this interface, does a new interface make sense, that allows the user to pass in the parameters, without passing in addresses? Nobody is bent

Re: dbd p[v]b functions problem

2010-02-04 Thread Bojan Smojver
On Thu, 2010-02-04 at 18:14 -0500, Bob Rossi wrote: OK, do you like what I'm suggesting? An interface that takes a va_list, that behaves just like printf... If you like it, what would you like the name of the function to be called? Any pointers? No opinion, to be honest, because I rarely