Re: svn commit: r1236642 - in /apr/apr/trunk: tables/apr_hash.c test/testhash.c

2012-01-28 Thread Branko Čibej
On 28.01.2012 00:54, Bojan Smojver wrote: --- Original message --- +hash = ht-seed ^ ht-hash_func(key, klen); Actually, when I think about this, it will probably be inefective. If two keys produce the same hash, the xor-ed value against the seed will most certainly be the same as

Re: svn commit: r1236642 - in /apr/apr/trunk: tables/apr_hash.c test/testhash.c

2012-01-28 Thread Bojan Smojver
On Sat, 2012-01-28 at 11:37 +0100, Branko Čibej wrote: Seeding the hash function is effectively the same as using the hash function's output to seed the randomizer, right? Yeah, randomiser function would have to be something other than simple xor or similar. The modulo that is used for

Re: svn commit: r1236642 - in /apr/apr/trunk: tables/apr_hash.c test/testhash.c

2012-01-28 Thread Bojan Smojver
--- Original message --- From: Bojan Smojver If you can think of a nice function that does that, Actually, I can think of one - the internal hash function I introduced in the latest commit. We can simply pass the hash done by the regular hash function into it and treat it as a

Re: svn commit: r1236642 - in /apr/apr/trunk: tables/apr_hash.c test/testhash.c

2012-01-28 Thread Bojan Smojver
On Sat, 2012-01-28 at 11:37 +0100, Branko Čibej wrote: rerun the result + seed through the built-in hash function Hopefully r1237078 should do something like that now. I completely missed this part of your reply, to be honest, so I had to do a bit of NIH of my own. Reading things on a tiny

Re: svn commit: r1236642 - in /apr/apr/trunk: tables/apr_hash.c test/testhash.c

2012-01-27 Thread Bojan Smojver
--- Original message --- +hash = ht-seed ^ ht-hash_func(key, klen); Actually, when I think about this, it will probably be inefective. If two keys produce the same hash, the xor-ed value against the seed will most certainly be the same as well. So, this won't actually do anything