Re: max_compaction_threshold removed - bad move

2013-01-09 Thread Brandon Williams
On Wed, Jan 9, 2013 at 9:21 AM, Radim Kolar h...@filez.com wrote: removing max_compaction_threshold in 1.2 was bad move, keeping it low helps compaction throughput because it lowers number of disk seeks. :(

Re: max_compaction_threshold removed - bad move

2013-01-09 Thread Edward Capriolo
:( Seems like a good thing to have, i can figure at least one degenerate scenario where having that helps. The first being a currupt sstable... compaction will never be able to remove it and then each compaction will likely try to comact it again... and fail. On Wed, Jan 9, 2013 at 10:35 AM,

Re: max_compaction_threshold removed - bad move

2013-01-09 Thread Brandon Williams
On Wed, Jan 9, 2013 at 9:40 AM, Edward Capriolo edlinuxg...@gmail.com wrote: :( Seems like a good thing to have, i can figure at least one degenerate scenario where having that helps. The first being a currupt sstable... compaction will never be able to remove it and then each compaction will

Re: max_compaction_threshold removed - bad move

2013-01-09 Thread Michael Kjellman
Yikes. Please would be nice.. Also, Sylvian already said they would update the documentation. As a developer, who hasn't forgotten to update documentation? On 1/9/13 8:07 AM, Radim Kolar h...@filez.com wrote: if this was renamed then update your documentation:

Re: max_compaction_threshold removed - bad move

2013-01-09 Thread Sylvain Lebresne
On Wed, Jan 9, 2013 at 5:04 PM, Edward Capriolo edlinuxg...@gmail.comwrote: Was the change well accounted for in the changes.TXT or the readme.txt? The news file says: CQL3 is now considered final in this release. Compared to the beta version that is part of 1.1, this final version has a few

Re: max_compaction_threshold removed - bad move

2013-01-09 Thread Edward Capriolo
If you want to complain about bad names in the code, start with the class implementing keyspaces being called Table. OMG that is terrible! We should only be wrongfully calling a column family a table :) (In hbase tables are actually a collection of column familes right so that is probably where

Re: max_compaction_threshold removed - bad move

2013-01-09 Thread Sylvain Lebresne
On Wed, Jan 9, 2013 at 5:30 PM, Edward Capriolo edlinuxg...@gmail.comwrote: If you want to complain about bad names in the code, start with the class implementing keyspaces being called Table. OMG that is terrible! I know!!! -- Sylvain