Re: [DISCUSS] Set minimum JDK version to 1.5 for Cocoon 2.1
On 10/10/2016 19:28, Antonio Gallardo wrote: Hi folks, +1 for 1.5. If in the future we have the need to move to a more recent version (ie: because a patch), then we should discuss it. Hi, we *are* discussing exactly that. At the moment we have a couple of patches on hold, for COCOON-2354 and COCOON-2352. Since it seems to me that there is enough consensus to move on, I will open a new issue for setting the compatibility to JDK 1.5 (at least for the moment) so that we can move on and accept the two patches above. Regards. On 07/10/16 03:46, Francesco Chicchiriccò wrote: Hi all, as recently noticed during the (unfortunately rejected) patch for COCOON-2354 [1], it might make sense to upgrade the current minimum JDK requirement for Cocoon 2.1 from 1.4 to 1.5, mainly to ease some upgrades and help Cocoon 2.1 living in the modern world. Besides 3rd part library updates, some work could be needed to upgrade our Java code, so help would be appreciated. WDYT? Regards. [1] https://lists.apache.org/thread.html/c03a2390ddd45b801a25e9946a49276693652870f4f4fbe732d8@%3Cdev.cocoon.apache.org%3E -- Francesco Chicchiriccò Tirasa - Open Source Excellence http://www.tirasa.net/ Member at The Apache Software Foundation Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail http://home.apache.org/~ilgrosso/
[jira] [Commented] (COCOON-2352) XMLEncoder doesn't support Unicode surrogate pairs
[ https://issues.apache.org/jira/browse/COCOON-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564709#comment-15564709 ] Francesco Chicchiriccò commented on COCOON-2352: We have just decided to upgrade to 1.5 compatibility in COCOON-2356, so I am happy to keep your contribution. A subsequent build [1] succeeded, in fact. Can we close this issue, then? [1] https://builds.apache.org/job/Cocoon%202.1.X/112 > XMLEncoder doesn't support Unicode surrogate pairs > -- > > Key: COCOON-2352 > URL: https://issues.apache.org/jira/browse/COCOON-2352 > Project: Cocoon > Issue Type: Bug > Components: * Cocoon Core, Blocks: Serializers >Affects Versions: 2.1.12 >Reporter: Ben Fortuna >Assignee: Francesco Chicchiriccò > Fix For: 2.1.13 > > > Whilst investigating an issue with the Sling project and support for emoji > characters, I've come to notice that the XMLEncoder used by HTMLSerializer > doesn't support Unicode surrogate pairs to represent higher order unicode > characters. > A simple unit test that demonstrates this issue is here: > https://github.com/micronode/whistlepost/blob/master/whistlepost-rewrite-lib/src/test/groovy/org/apache/cocoon/components/serializers/encoding/XMLEncoderTest.groovy > More background info here also: SLING-5973 > This seems to have been identified/addressed in other Apache projects also: > https://issues.apache.org/jira/browse/THRIFT-3403?jql=text%20~%20%22surrogate%20pairs%22 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (COCOON-2356) Set source and target compatibility to JDK 1.5
Francesco Chicchiriccò created COCOON-2356: -- Summary: Set source and target compatibility to JDK 1.5 Key: COCOON-2356 URL: https://issues.apache.org/jira/browse/COCOON-2356 Project: Cocoon Issue Type: Task Components: - Build System: Ant Reporter: Francesco Chicchiriccò Assignee: Francesco Chicchiriccò Fix For: 2.1.13 After discussion [1], we are moving on by setting source and compatibility to JDK 1.5: * in the ANT settings * in the Jenkins job [2] [1] https://lists.apache.org/thread.html/55304b8ded2ff0631455054aa064b4735bc363b67eda391f612a2e04@%3Cdev.cocoon.apache.org%3E [2] https://builds.apache.org/job/Cocoon%202.1.X/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (COCOON-2356) Set source and target compatibility to JDK 1.5
[ https://issues.apache.org/jira/browse/COCOON-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò closed COCOON-2356. -- Resolution: Fixed > Set source and target compatibility to JDK 1.5 > -- > > Key: COCOON-2356 > URL: https://issues.apache.org/jira/browse/COCOON-2356 > Project: Cocoon > Issue Type: Task > Components: - Build System: Ant >Reporter: Francesco Chicchiriccò >Assignee: Francesco Chicchiriccò > Fix For: 2.1.13 > > > After discussion [1], we are moving on by setting source and compatibility to > JDK 1.5: > * in the ANT settings > * in the Jenkins job [2] > [1] > https://lists.apache.org/thread.html/55304b8ded2ff0631455054aa064b4735bc363b67eda391f612a2e04@%3Cdev.cocoon.apache.org%3E > [2] https://builds.apache.org/job/Cocoon%202.1.X/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COCOON-2356) Set source and target compatibility to JDK 1.5
[ https://issues.apache.org/jira/browse/COCOON-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564703#comment-15564703 ] Hudson commented on COCOON-2356: SUCCESS: Integrated in Jenkins build Cocoon 2.1.X #112 (See [https://builds.apache.org/job/Cocoon%202.1.X/112/]) [COCOON-2356] Setting source.vm and target.vm to 1.5 (ilgrosso: [http://svn.apache.org/viewvc/?view=rev=1764200]) * (edit) BRANCH_2_1_X/build.properties > Set source and target compatibility to JDK 1.5 > -- > > Key: COCOON-2356 > URL: https://issues.apache.org/jira/browse/COCOON-2356 > Project: Cocoon > Issue Type: Task > Components: - Build System: Ant >Reporter: Francesco Chicchiriccò >Assignee: Francesco Chicchiriccò > Fix For: 2.1.13 > > > After discussion [1], we are moving on by setting source and compatibility to > JDK 1.5: > * in the ANT settings > * in the Jenkins job [2] > [1] > https://lists.apache.org/thread.html/55304b8ded2ff0631455054aa064b4735bc363b67eda391f612a2e04@%3Cdev.cocoon.apache.org%3E > [2] https://builds.apache.org/job/Cocoon%202.1.X/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COCOON-2354) Update POI 3.0.2 to 3.10-FINAL and fix support Merge tag support.
[ https://issues.apache.org/jira/browse/COCOON-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564752#comment-15564752 ] Hudson commented on COCOON-2354: SUCCESS: Integrated in Jenkins build Cocoon 2.1.X #113 (See [https://builds.apache.org/job/Cocoon%202.1.X/113/]) [COCOON-2354] Applying provided patch - had to rebuild poi from source tag as the JAR from Maven is built for JDK 1.6 (ilgrosso: [http://svn.apache.org/viewvc/?view=rev=1764205]) * (edit) BRANCH_2_1_X/lib/jars.xml * (delete) BRANCH_2_1_X/lib/optional/commons-codec-1.3.jar * (add) BRANCH_2_1_X/lib/optional/commons-codec-1.5.jar * (delete) BRANCH_2_1_X/lib/optional/poi-3.0.2-FINAL-20080204.jar * (add) BRANCH_2_1_X/lib/optional/poi-3.10-FINAL.jar * (edit) BRANCH_2_1_X/src/blocks/poi/java/org/apache/cocoon/components/elementprocessor/impl/poi/hssf/elements/Cell.java * (edit) BRANCH_2_1_X/src/blocks/poi/java/org/apache/cocoon/components/elementprocessor/impl/poi/hssf/elements/EPMerge.java * (edit) BRANCH_2_1_X/src/blocks/poi/java/org/apache/cocoon/components/elementprocessor/impl/poi/hssf/elements/Sheet.java * (edit) BRANCH_2_1_X/src/blocks/poi/java/org/apache/cocoon/components/elementprocessor/impl/poi/hssf/elements/Workbook.java * (edit) BRANCH_2_1_X/src/blocks/poi/samples/content/simple-date-test.xml > Update POI 3.0.2 to 3.10-FINAL and fix support Merge tag support. > - > > Key: COCOON-2354 > URL: https://issues.apache.org/jira/browse/COCOON-2354 > Project: Cocoon > Issue Type: Bug > Components: Blocks: POI >Affects Versions: 2.1.12 >Reporter: Carlos Navarro >Assignee: Francesco Chicchiriccò > Fix For: 2.1.13 > > Attachments: poi_update.patch > > > Update POI 3.0.2 to 3.10-FINAL and fix support Merge tag support. > We need update the POI version lib to implement support to xwpf. > * Change the jar lib lib/optional/poi-3.0.2-FINAL-20080204.jar for a newer > version lib/optional/poi-3.10-FINAL.jar . > source: https://mvnrepository.com/artifact/org.apache.poi/poi/3.10-FINAL > * Change for the EPMerge class: > - Replace Range class(deprecated) with CellRangeAddress. > - Add Overcharge method addMergedRegion to the Sheet class. > - Remove Cell Encoding UTF_16 in class Sheet, Cell and Workbook constructor. > - Adding tets merge cell range in > src/blocks/poi/samples/content/simple-date-test.xml -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (COCOON-2354) Update POI 3.0.2 to 3.10-FINAL and fix support Merge tag support.
[ https://issues.apache.org/jira/browse/COCOON-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò closed COCOON-2354. -- Resolution: Fixed > Update POI 3.0.2 to 3.10-FINAL and fix support Merge tag support. > - > > Key: COCOON-2354 > URL: https://issues.apache.org/jira/browse/COCOON-2354 > Project: Cocoon > Issue Type: Bug > Components: Blocks: POI >Affects Versions: 2.1.12 >Reporter: Carlos Navarro >Assignee: Francesco Chicchiriccò > Fix For: 2.1.13 > > Attachments: poi_update.patch > > > Update POI 3.0.2 to 3.10-FINAL and fix support Merge tag support. > We need update the POI version lib to implement support to xwpf. > * Change the jar lib lib/optional/poi-3.0.2-FINAL-20080204.jar for a newer > version lib/optional/poi-3.10-FINAL.jar . > source: https://mvnrepository.com/artifact/org.apache.poi/poi/3.10-FINAL > * Change for the EPMerge class: > - Replace Range class(deprecated) with CellRangeAddress. > - Add Overcharge method addMergedRegion to the Sheet class. > - Remove Cell Encoding UTF_16 in class Sheet, Cell and Workbook constructor. > - Adding tets merge cell range in > src/blocks/poi/samples/content/simple-date-test.xml -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COCOON-2354) Update POI 3.0.2 to 3.10-FINAL and fix support Merge tag support.
[ https://issues.apache.org/jira/browse/COCOON-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564757#comment-15564757 ] Francesco Chicchiriccò commented on COCOON-2354: With COCOON-2356 we have set the minimum JDK compatibility to 1.5, hence I have gladly taken back your patch. Thanks again! > Update POI 3.0.2 to 3.10-FINAL and fix support Merge tag support. > - > > Key: COCOON-2354 > URL: https://issues.apache.org/jira/browse/COCOON-2354 > Project: Cocoon > Issue Type: Bug > Components: Blocks: POI >Affects Versions: 2.1.12 >Reporter: Carlos Navarro >Assignee: Francesco Chicchiriccò > Fix For: 2.1.13 > > Attachments: poi_update.patch > > > Update POI 3.0.2 to 3.10-FINAL and fix support Merge tag support. > We need update the POI version lib to implement support to xwpf. > * Change the jar lib lib/optional/poi-3.0.2-FINAL-20080204.jar for a newer > version lib/optional/poi-3.10-FINAL.jar . > source: https://mvnrepository.com/artifact/org.apache.poi/poi/3.10-FINAL > * Change for the EPMerge class: > - Replace Range class(deprecated) with CellRangeAddress. > - Add Overcharge method addMergedRegion to the Sheet class. > - Remove Cell Encoding UTF_16 in class Sheet, Cell and Workbook constructor. > - Adding tets merge cell range in > src/blocks/poi/samples/content/simple-date-test.xml -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COCOON-2356) Set source and target compatibility to JDK 1.5
[ https://issues.apache.org/jira/browse/COCOON-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564846#comment-15564846 ] Hudson commented on COCOON-2356: SUCCESS: Integrated in Jenkins build Cocoon 2.1.X #114 (See [https://builds.apache.org/job/Cocoon%202.1.X/114/]) [COCOON-2356] Forgot to update the README.txt (ilgrosso: [http://svn.apache.org/viewvc/?view=rev=1764206]) * (edit) BRANCH_2_1_X/README.txt > Set source and target compatibility to JDK 1.5 > -- > > Key: COCOON-2356 > URL: https://issues.apache.org/jira/browse/COCOON-2356 > Project: Cocoon > Issue Type: Task > Components: - Build System: Ant >Reporter: Francesco Chicchiriccò >Assignee: Francesco Chicchiriccò > Fix For: 2.1.13 > > > After discussion [1], we are moving on by setting source and compatibility to > JDK 1.5: > * in the ANT settings > * in the Jenkins job [2] > [1] > https://lists.apache.org/thread.html/55304b8ded2ff0631455054aa064b4735bc363b67eda391f612a2e04@%3Cdev.cocoon.apache.org%3E > [2] https://builds.apache.org/job/Cocoon%202.1.X/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
