Re: commons-lang pull request: Trunk - ToStringStyle typos and XML implementati...

2013-06-26 Thread Jörg Schaible
Unit tests would be definitely welcome ;-) dlh3 wrote: GitHub user dlh3 opened a pull request: https://github.com/apache/commons-lang/pull/7 Trunk - ToStringStyle typos and XML implementation Fixes a comment typo and adds separator between two subclasses. Brings

Re: [VOTE] Release of Commons Collections 4.0-alpha1 based on RC1

2013-06-26 Thread Thomas Neidhart
On Sun, Jun 23, 2013 at 10:04 PM, Thomas Neidhart thomas.neidh...@gmail.com wrote: Hi, I'd like to call a vote for releasing Commons Collections 4.0-alpha1 based on RC1. The files: The artifacts are deployed to Nexus:

Re: [VOTE] Release of Commons Collections 4.0-alpha1 based on RC1

2013-06-26 Thread Benedikt Ritter
2013/6/26 Thomas Neidhart thomas.neidh...@gmail.com On Sun, Jun 23, 2013 at 10:04 PM, Thomas Neidhart thomas.neidh...@gmail.com wrote: Hi, I'd like to call a vote for releasing Commons Collections 4.0-alpha1 based on RC1. The files: The artifacts are deployed to Nexus:

Re: [VOTE] Release of Commons Collections 4.0-alpha1 based on RC1

2013-06-26 Thread Gary Gregory
I've had no bandwidth for this over the last couple of days. I am hoping I can get to it tonight... Gary On Wed, Jun 26, 2013 at 8:11 AM, Thomas Neidhart thomas.neidh...@gmail.comwrote: On Sun, Jun 23, 2013 at 10:04 PM, Thomas Neidhart thomas.neidh...@gmail.com wrote: Hi, I'd like

Re: [VOTE] Release of Commons Collections 4.0-alpha1 based on RC1

2013-06-26 Thread Luc Maisonobe
Le 23/06/2013 22:04, Thomas Neidhart a écrit : Hi, I'd like to call a vote for releasing Commons Collections 4.0-alpha1 based on RC1. The files: The artifacts are deployed to Nexus:

Re: [VOTE] Release of Commons Collections 4.0-alpha1 based on RC1

2013-06-26 Thread sebb
On 26 June 2013 13:11, Thomas Neidhart thomas.neidh...@gmail.com wrote: On Sun, Jun 23, 2013 at 10:04 PM, Thomas Neidhart thomas.neidh...@gmail.com wrote: Hi, I'd like to call a vote for releasing Commons Collections 4.0-alpha1 based on RC1. The files: The artifacts are deployed to

Re: [VOTE] Release of Commons Collections 4.0-alpha1 based on RC1

2013-06-26 Thread Emmanuel Bourg
Le 26/06/2013 14:11, Thomas Neidhart a écrit : so far there has only been 1 vote (apart from my implicit one) and there are only a few hours to go. The issues related to javadoc are non-blocking if I understand it correctly, but I would even be fine to cut another RC to fix this. Otoh,

Re: [CHAIN] Why does ConextMap extend ConcurrentHashMap instead of delegating to a Map?

2013-06-26 Thread Elijah Zupancic
Hi Benedikt, I made the decision to inherit from ConcurrentHashMap because the original implementation was inheriting from HashMap. I was doing an incremental refactoring approach and there was never a good justification for that design rather I was trying to make evolutionary improvements. Being

Re: [CHAIN] Thoughts about o.a.c.chain2.Chain, o.a.c.chain2.Command and the base classes

2013-06-26 Thread Elijah Zupancic
+1 to everything. With regards to an enum for status, wouldn't it be better to use a class so that consumers could subclass it and add their own states if needed? Thanks, -Elijah On Sat, Jun 22, 2013 at 4:30 AM, Benedikt Ritter benerit...@gmail.comwrote: Am 22.06.2013 um 12:57 schrieb

Re: [VOTE] Release of Commons Collections 4.0-alpha1 based on RC1

2013-06-26 Thread Thomas Neidhart
On 06/26/2013 02:11 PM, Thomas Neidhart wrote: On Sun, Jun 23, 2013 at 10:04 PM, Thomas Neidhart thomas.neidh...@gmail.com mailto:thomas.neidh...@gmail.com wrote: Hi, I'd like to call a vote for releasing Commons Collections 4.0-alpha1 based on RC1. The files: