commons-lang pull request: Adding .gitignore to commons-lang

2013-09-03 Thread mureinik
Github user mureinik closed the pull request at: https://github.com/apache/commons-lang/pull/8 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

commons-lang pull request: Hash code builder

2013-09-03 Thread mureinik
GitHub user mureinik opened a pull request: https://github.com/apache/commons-lang/pull/10 Hash code builder Solution for LANG-804: Redundant check for zero in HashCodeBuilder ctor You can merge this pull request into a Git repository by running: $ git pull

[OGNL] Make use of logging?

2013-09-03 Thread Christian Grobmeier
I found 11 uses of e.printStackTrace and think its pretty bad. Including OgnlException overwrites printStackTrace and writes to System.err for some reason. In addition there are a lot of System.out's, but those are all commented and seem to have served debugging purposes. I believe small libs

[OGNL] checkstyle for maven styled code...

2013-09-03 Thread Christian Grobmeier
I found this in ognl pom: plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-checkstyle-plugin/artifactId version2.7/version configuration configLocationconfig/maven_checks.xml/configLocation