[GitHub] commons-collections pull request #58: Fix Rat check - add missing license he...

2018-11-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/58 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

Re: [logging] java8 default interface methods for lazy log payload object creation

2018-11-13 Thread Matt Sicker
On Tue, 13 Nov 2018 at 15:21, Gary Gregory wrote: > On Tue, Nov 13, 2018 at 2:03 PM Matt Sicker wrote: > > > I thought Commons Logging 1.2 required Java 1.2? Big leap to 8! > > > > The current POM requires Java 6. > I must have confused that with the prior release then which is Java 1.1 I

Re: [logging] java8 default interface methods for lazy log payload object creation

2018-11-13 Thread Gary Gregory
On Tue, Nov 13, 2018 at 2:03 PM Matt Sicker wrote: > I thought Commons Logging 1.2 required Java 1.2? Big leap to 8! > The current POM requires Java 6. Gary > > Same bias here for Log4j2, though adding simple default methods like that > would be neat for any APIs stuck using it (like Spring

Re: [logging] java8 default interface methods for lazy log payload object creation

2018-11-13 Thread Matt Sicker
I thought Commons Logging 1.2 required Java 1.2? Big leap to 8! Same bias here for Log4j2, though adding simple default methods like that would be neat for any APIs stuck using it (like Spring Framework for example). On Tue, 13 Nov 2018 at 14:52, Gary Gregory wrote: > Hi Balazs, > > To me, as

Re: [logging] java8 default interface methods for lazy log payload object creation

2018-11-13 Thread Gary Gregory
Hi Balazs, To me, as a biased contributor to Apache Log4j 2, I think the Log4j API should be new facade to use instead of Commons Logging. That said, please feel free to contribute PRs to Commons Logging for those using that API ;-) https://github.com/apache/commons-logging Gary On Tue, Nov

[logging] java8 default interface methods for lazy log payload object creation

2018-11-13 Thread Balazs Toth
Hi, I am wondering to extend the org.apache.commons.logging.Log interface with default methods. It could simplify the usage, instead of if (log.isDebugEnabled()) { log.debug("something heavy " + here); } could use lambda expression log.debug(() -> "something heavy " + here); to

Re: Release Managers?

2018-11-13 Thread Bruno P. Kinoshita
If anyone would like to take over commons-imaging 1.0-alpha1 release. We had up to RC2 I think, so there should be little left to do. I can volunteer around x-mas or January/19 I think. Bruno From: Gary Gregory To: Commons Developers List Sent: Wednesday, 14 November 2018 8:34 AM

Release Managers?

2018-11-13 Thread Gary Gregory
Hi All: It looks like we have a release manager volunteer for Commons Pool 2.6.1; thank you Mark! I'd also like to see releases for: - Commons Release - Commons Parent - Commons Text, then Commons Configuration after a teak in Config to use a new Text feature. - Commons Pool - Commons

[GitHub] commons-collections pull request #58: Fix Rat check - add missing license he...

2018-11-13 Thread nandorKollar
GitHub user nandorKollar opened a pull request: https://github.com/apache/commons-collections/pull/58 Fix Rat check - add missing license header Fix broken CI - add missing license header for Rat check You can merge this pull request into a Git repository by running: $ git

Re: [VOTE][CANCEL] Release Apache Commons Pool 2.6.1 based on RC1

2018-11-13 Thread Mark Struberg
yes, they are. I create a new test to showcase the problem and only then fix it. All other tests still pass. LieGrue, strub > Am 12.11.2018 um 16:05 schrieb Gary Gregory : > > Hi Mark, > > Too many bits flying around on my end here. Can you check that your changes > are covered by unit tests?