Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-13 Thread James Carman
On Mar 12, 2013, at 12:36 PM, sebb seb...@gmail.com wrote: In which case, vetoing the commit that causes the problem makes more sense, surely? Perhaps we should set up a Sonar rule to catch stuff like this to save you the trouble of trolling the SVN commit log messages. The veto was

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-13 Thread Gary Gregory
Hi All: It seems to me that we are misusing the term veto. A release cannot be vetoes, it can be VOTEd on with a -1, which is not a veto, but is usually interpreted as one, by me, at least, as a courtesy to my fellow PMD member for putting the time in to care. You can -1 a commit which is not

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-13 Thread James Carman
A -1 on a code modification proposal (in this case the code was already changed, but i think it still applies) is called a veto by the ASF. If accompanied by a valid technical justification, it stands (unless the person can be talked out of it). http://www.apache.org/foundation/voting.html On

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-12 Thread James Carman
On Mar 9, 2013, at 7:32 AM, sebb seb...@gmail.com wrote: I would have voted -1 on the RC, because the tag would not agree with the source archive. However, releases cannot be vetoed. - To unsubscribe, e-mail:

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-12 Thread sebb
On 12 March 2013 11:17, James Carman jcar...@carmanconsulting.com wrote: On Mar 9, 2013, at 7:32 AM, sebb seb...@gmail.com wrote: I would have voted -1 on the RC, because the tag would not agree with the source archive. However, releases cannot be vetoed. In which case, vetoing the commit

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-09 Thread sebb
On 9 March 2013 00:39, Ralph Goers ralph.go...@dslextreme.com wrote: I'm not sure I understand what the big deal is. Sebb vetoed a commit and identified exactly what needed to be changed for him to remove the veto. If the requested change is made then all should be fine with the world

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-09 Thread Christian Grobmeier
On Sat, Mar 9, 2013 at 10:00 AM, sebb seb...@gmail.com wrote: On 9 March 2013 00:39, Ralph Goers ralph.go...@dslextreme.com wrote: I'm not sure I understand what the big deal is. Sebb vetoed a commit and identified exactly what needed to be changed for him to remove the veto. If the

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-09 Thread Niall Pemberton
On Sat, Mar 9, 2013 at 9:00 AM, sebb seb...@gmail.com wrote: On 9 March 2013 00:39, Ralph Goers ralph.go...@dslextreme.com wrote: I'm not sure I understand what the big deal is. Sebb vetoed a commit and identified exactly what needed to be changed for him to remove the veto. If the

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-09 Thread sebb
On 9 March 2013 11:56, Niall Pemberton niall.pember...@gmail.com wrote: On Sat, Mar 9, 2013 at 9:00 AM, sebb seb...@gmail.com wrote: On 9 March 2013 00:39, Ralph Goers ralph.go...@dslextreme.com wrote: I'm not sure I understand what the big deal is. Sebb vetoed a commit and identified

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-09 Thread Niall Pemberton
On Sat, Mar 9, 2013 at 12:32 PM, sebb seb...@gmail.com wrote: On 9 March 2013 11:56, Niall Pemberton niall.pember...@gmail.com wrote: On Sat, Mar 9, 2013 at 9:00 AM, sebb seb...@gmail.com wrote: On 9 March 2013 00:39, Ralph Goers ralph.go...@dslextreme.com wrote: I'm not sure I understand what

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-09 Thread Benedikt Ritter
2013/3/9 Christian Grobmeier grobme...@gmail.com On Sat, Mar 9, 2013 at 10:00 AM, sebb seb...@gmail.com wrote: On 9 March 2013 00:39, Ralph Goers ralph.go...@dslextreme.com wrote: I'm not sure I understand what the big deal is. Sebb vetoed a commit and identified exactly what needed to be

[OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-08 Thread Mark Thomas
Niall Pemberton niall.pember...@gmail.com wrote: On Thu, Mar 7, 2013 at 11:54 PM, Mark Thomas ma...@apache.org wrote: snip/ One of the primary responsibilities of a PMC member when voting on a release is verifying what is being voted on against the tag. Different client locales and $Date$

Re: [OT] Verifying releases Was: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-08 Thread Ralph Goers
I'm not sure I understand what the big deal is. Sebb vetoed a commit and identified exactly what needed to be changed for him to remove the veto. If the requested change is made then all should be fine with the world again. Sure, he could have said all the same words without the -1 but then