Re: [TEXT] Remove Commons Lang Dependency?

Pascal Schumacher wrote: > Am 19.12.2016 um 11:25 schrieb Pascal Schumacher: >> Am 18.12.2016 um 23:02 schrieb Jörg Schaible: >>> Actually I don't understand why do you want to remove it. It was made >>> dependent on purpose. The shade plugin - if properly configured - >>> will only >>> include

Re: [TEXT] Remove Commons Lang Dependency?

Am 19.12.2016 um 11:25 schrieb Pascal Schumacher: Am 18.12.2016 um 23:02 schrieb Jörg Schaible: Actually I don't understand why do you want to remove it. It was made dependent on purpose. The shade plugin - if properly configured - will only include StringUtils as a private package in

Re: [TEXT] Remove Commons Lang Dependency?

Am 18.12.2016 um 23:02 schrieb Jörg Schaible: Actually I don't understand why do you want to remove it. It was made dependent on purpose. The shade plugin - if properly configured - will only include StringUtils as a private package in commons-text - so this dependency exists only at build time.

Re: [TEXT] Remove Commons Lang Dependency?

ependencies is a better practice, but I'm ok with including now or down the road. -Rob > Hope that helps > Bruno > > > > > - Original Message - >> From: Pascal Schumacher <pascalschumac...@gmx.net> >> To: Commons Developers List <dev@commons.apach

Re: [TEXT] Remove Commons Lang Dependency?

016 7:06 AM > Subject: [TEXT] Remove Commons Lang Dependency? > > Hello everybody, > > commons-text currently depends on commons-lang. This dependency is > included into the jar via the maven shade plugin. > > Only two methods from lang are really needed: > > St

Re: [TEXT] Remove Commons Lang Dependency?

On 18 December 2016 at 22:02, Jörg Schaible wrote: > Pascal Schumacher wrote: > >> Hello everybody, >> >> commons-text currently depends on commons-lang. This dependency is >> included into the jar via the maven shade plugin. >> >> Only two methods from lang are really

Re: [TEXT] Remove Commons Lang Dependency?

Pascal Schumacher wrote: > Hello everybody, > > commons-text currently depends on commons-lang. This dependency is > included into the jar via the maven shade plugin. > > Only two methods from lang are really needed: > > StringUtils#containsAny > > StringUtils#containsNone > > As

Re: [TEXT] Remove Commons Lang Dependency?

Looks OK. However it might be confusing to have the same methods in both jars, so at least the class needs to be renamed. Probably best to make the methods internal. Otherwise people might expect other related methods to be supported. This would end up with duplication of LANG methods. If it is

Re: [TEXT] Remove Commons Lang Dependency?

That looks good to me. We do similarly in Log4j. Commons classes tend to be written in such a way that you can copy/paste only what you need if you're trying to prevent required dependencies. On 18 December 2016 at 12:06, Pascal Schumacher wrote: > Hello everybody, > >

[TEXT] Remove Commons Lang Dependency?

Hello everybody, commons-text currently depends on commons-lang. This dependency is included into the jar via the maven shade plugin. Only two methods from lang are really needed: StringUtils#containsAny StringUtils#containsNone As dependencies should be minimized I'm not sure if adding a