Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-25 Thread Gary Gregory
On Mon, Jan 25, 2016 at 7:47 AM, Matt Benson wrote: > > On Sun, Jan 24, 2016 at 9:37 PM, Gary Gregory wrote: > > On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory > > wrote: > > > >> Antlib's Clirr report has a lot of errors: > >>

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-25 Thread Matt Benson
On Sun, Jan 24, 2016 at 9:37 PM, Gary Gregory wrote: > On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory > wrote: > >> Antlib's Clirr report has a lot of errors: >>

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-25 Thread sebb
On 25 January 2016 at 15:47, Matt Benson wrote: > On Sun, Jan 24, 2016 at 9:37 PM, Gary Gregory wrote: >> On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory >> wrote: >> >>> Antlib's Clirr report has a lot of errors: >>>

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-25 Thread Romain Manni-Bucau
+1, weaver is for now mainly an internal for other asf projects - which are BTW blocked by this vote - and the binaries are fine. The site can be fixed anyway when pushed to no reason to hold this release. Romain Manni-Bucau @rmannibucau | Blog

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-25 Thread Phil Steitz
On 1/25/16 3:57 PM, Gary Gregory wrote: > But the binaries are not BC. Even if that was a silly mistake, the release > notes must note the break in BC. I may have misunderstood what Matt said, but IIUC there is no actual BC break. Could any applications break as a result of what Clirr is

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-25 Thread Gary Gregory
Did I misread that the 1.1 jar included shaded code from other jars? Gary On Mon, Jan 25, 2016 at 3:02 PM, Phil Steitz wrote: > On 1/25/16 3:57 PM, Gary Gregory wrote: > > But the binaries are not BC. Even if that was a silly mistake, the > release > > notes must note

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-25 Thread Matt Benson
In practice it is most likely that a user of the 1.1 version of the Antlib (firstly, doesn't exist, but if they did) would see no effect because Ant's own classes are loaded in the parent CL of the Antlib's CL, therefore the Ant classes, correctly, would not be used. While the jar is technically

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-25 Thread Gary Gregory
On Mon, Jan 25, 2016 at 3:37 PM, Matt Benson wrote: > In practice it is most likely that a user of the 1.1 version of the > Antlib (firstly, doesn't exist, but if they did) would see no effect > because Ant's own classes are loaded in the parent CL of the Antlib's > CL,

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-25 Thread Gary Gregory
But the binaries are not BC. Even if that was a silly mistake, the release notes must note the break in BC. Gary On Mon, Jan 25, 2016 at 2:24 PM, Romain Manni-Bucau wrote: > +1, weaver is for now mainly an internal for other asf projects - which are > BTW blocked by this

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-24 Thread Gary Gregory
Not a blocker but kind of silly: Unapproved licenses: LICENSE-asm5.0.4.txt This file should be excluded. Gary On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson wrote: > I would like to release the [weaver] component. > > Apache Commons Weaver 1.2 RC2 is available for

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-24 Thread Olivier Lamy
+1 On 22 January 2016 at 05:39, Matt Benson wrote: > I would like to release the [weaver] component. > > Apache Commons Weaver 1.2 RC2 is available for review at: > https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994). > > Maven artifacts are at: >

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-24 Thread Gary Gregory
On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory wrote: > Antlib's Clirr report has a lot of errors: > https://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/clirr-report.html > > This is not documented in the release notes. >

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-24 Thread Gary Gregory
Antlib's Clirr report has a lot of errors: https://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/clirr-report.html This is not documented in the release notes. Gary On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson wrote: > I

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-22 Thread luc
Le 2016-01-22 08:47, Romain Manni-Bucau a écrit : +1, thanks Matt! Romain Manni-Bucau @rmannibucau | Blog | Github | LinkedIn | Tomitriber

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-22 Thread Phil Steitz
Sigs, hashes, release contents look good. ASM attribution is there, I assume in the right places. Jar contents look clean, though I did not run tests against release jars. Tests run clean on Ubuntu Oracle 1.6.0_43 OSX Oracle 1.8.0_45, 1.7.0_71 +1 Phil On 1/21/16 11:39 AM, Matt Benson wrote: >

[VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-21 Thread Matt Benson
I would like to release the [weaver] component. Apache Commons Weaver 1.2 RC2 is available for review at: https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994). Maven artifacts are at: https://repository.apache.org/content/repositories/orgapachecommons-1141 . Tested with Oracle

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

2016-01-21 Thread Romain Manni-Bucau
+1, thanks Matt! Romain Manni-Bucau @rmannibucau | Blog | Github | LinkedIn | Tomitriber 2016-01-21 19:39 GMT+01:00 Matt