Re: [chain][discuss] v2 upgrade - follow-up

2011-09-05 Thread Niall Pemberton
On Mon, Aug 29, 2011 at 9:31 PM, Matt Benson gudnabr...@gmail.com wrote: On Mon, Aug 29, 2011 at 2:53 PM, Simone Tripodi simonetrip...@apache.org wrote: Hi all guys, I just fixed the clirr report generation and deployed the chain2 site on my personal ASF space[1], in order we can discuss the

[chain][discuss] v2 upgrade - follow-up - part2

2011-09-02 Thread Simone Tripodi
Hi again guys, I did a little work on the v2 branch of [chain] to fix checkstyle errors, obviously clirr[1] errors increased but new ones are IMHO trivial, since concern internal data structures already exposed via getters - the o.a.c.chain.impl.ChainBase#commands was exposed at package level just

Re: [chain][discuss] v2 upgrade - follow-up - part2

2011-09-02 Thread Matt Benson
On Fri, Sep 2, 2011 at 2:29 AM, Simone Tripodi simonetrip...@apache.org wrote: Hi again guys, I did a little work on the v2 branch of [chain] to fix checkstyle errors, obviously clirr[1] errors increased but new ones are IMHO trivial, since concern internal data structures already exposed via

Re: [chain][discuss] v2 upgrade - follow-up

2011-08-31 Thread Simone Tripodi
Hi all guys, I noticed that properly setting the 1.5 as target compliance level, there are some @Override annotations that in cases of interfaces methods implementation should be dropped. Do you agree on it? Moreover, I'd like to propose to split the chain component, for v2.0, in a multi-module

Re: [chain][discuss] v2 upgrade - follow-up

2011-08-31 Thread Matt Benson
On Wed, Aug 31, 2011 at 9:45 AM, Simone Tripodi simonetrip...@apache.org wrote: Hi all guys, I noticed that properly setting the 1.5 as target compliance level, there are some @Override annotations that in cases of interfaces methods implementation should be dropped. Do you agree on it?

Re: [chain][discuss] v2 upgrade - follow-up

2011-08-31 Thread Paul Benedict
On Wed, Aug 31, 2011 at 9:45 AM, Simone Tripodi simonetrip...@apache.org wrote: Hi all guys, I noticed that properly setting the 1.5 as target compliance level, there are some @Override annotations that in cases of interfaces methods implementation should be dropped. Do you agree on it? Yes,

Re: [chain][discuss] v2 upgrade - follow-up

2011-08-31 Thread Simone Tripodi
Hi Paul, if I remember correctly, maven should be able to aggregate submodules apidocs, I will ask to mvn ML. Thanks for the feedback and the hint!!! Have a nice day, all the best, Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, Aug 31, 2011 at 5:32 PM, Paul

Re: [chain][discuss] v2 upgrade - follow-up

2011-08-31 Thread Paul Benedict
On Wed, Aug 31, 2011 at 12:02 PM, Simone Tripodi simonetrip...@apache.org wrote: Hi Paul, if I remember correctly, maven should be able to aggregate submodules apidocs, I will ask to mvn ML. Yes, it can. The javadoc plugin has an aggregate option. Paul

Re: [chain][discuss] v2 upgrade - follow-up

2011-08-31 Thread Simone Tripodi
Nice, thanks for the reminder, I'll keep it in mind when splitting the submodules!!! At the same time, everybody: do you agree on replacing package.html with package-info.java? TIA, all the best! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, Aug 31, 2011 at

Re: [chain][discuss] v2 upgrade - follow-up

2011-08-31 Thread Paul Benedict
At the same time, everybody: do you agree on replacing package.html with package-info.java? +1 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [chain][discuss] v2 upgrade - follow-up

2011-08-31 Thread Simone Tripodi
thanks!!! what about dropping deprecated methods? since we are upgrading to major version, they can be dropped... or not? TIA!!! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, Aug 31, 2011 at 9:08 PM, Paul Benedict pbened...@apache.org wrote: At the same time,

Re: [chain][discuss] v2 upgrade - follow-up

2011-08-31 Thread Paul Benedict
Well... I follow this pattern: http://apr.apache.org/versioning.html On Wed, Aug 31, 2011 at 2:12 PM, Simone Tripodi simonetrip...@apache.org wrote: thanks!!! what about dropping deprecated methods? since we are upgrading to major version, they can be dropped... or not? TIA!!! Simo

Re: [chain][discuss] v2 upgrade - follow-up

2011-08-31 Thread Simone Tripodi
you reminded me that commons has as well a guideline[1], I need to read it more carefully! :P [1] http://commons.apache.org/releases/versioning.html http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, Aug 31, 2011 at 9:50 PM, Paul Benedict pbened...@apache.org wrote:

Re: [chain][discuss] v2 upgrade - follow-up

2011-08-30 Thread Simone Tripodi
Hi guys, sorry I'm late but looks like my local timezone sometimes doesn't allow me replying promptly :P @Matt: you are welcome, any time :) Unfortunately I'm not so familiar with [chain] codebase, I cannot be useful ATM :( @Elijah: patches are always welcome ;) For those tests that seems

Re: [chain][discuss] v2 upgrade - follow-up

2011-08-29 Thread Simone Tripodi
Hi all guys, I just fixed the clirr report generation and deployed the chain2 site on my personal ASF space[1], in order we can discuss the patch that Elijah kindly provided. WDYT? It is IMHO acceptable in order to apply the modifications in /trunk. TIA, all the best!!! Simo [1]

Re: [chain][discuss] v2 upgrade - follow-up

2011-08-29 Thread Paul Benedict
I am curious about the change of normal collections to concurrent collections. Is there overhead with the concurrent stuff? Most of my context access is not multithreaded. On Mon, Aug 29, 2011 at 2:53 PM, Simone Tripodi simonetrip...@apache.org wrote: Hi all guys, I just fixed the clirr report

Re: [chain][discuss] v2 upgrade - follow-up

2011-08-29 Thread Matt Benson
On Mon, Aug 29, 2011 at 2:53 PM, Simone Tripodi simonetrip...@apache.org wrote: Hi all guys, I just fixed the clirr report generation and deployed the chain2 site on my personal ASF space[1], in order we can discuss the patch that Elijah kindly provided. WDYT? It is IMHO acceptable in order

Re: [chain][discuss] v2 upgrade - follow-up

2011-08-29 Thread Elijah Zupancic
Hi Simo, Before we look at releasing the changes (after a trunk merge), I think that we will need to update the documentation to include Generics and possibly change the unit tests to use Generics. That said - I'm cautious about changing the unit tests because they are verifying that the API