Hi Elijah,
Bricklaying is indeed harder that it seems, fortunately already
experienced friends of mine are helping me - above all because I have
a huge amount of work :P
I suggest you taking care about checkstyle errors once we have applied
the generics patch - here at commons we tend to avoid
Hi all/Elijah,
sorry for replying so late but during these days I've been working as
bricklayer at home, fixing some stuff :P
About the binary compatibility breakage, I have a (maybe silly,
hopefully not) idea: marking @Deprecated (and justifying why in the
javadoc) the wrong method and adding
Simo,
Bricklaying is one of those things that seem simple, but actually can
be a bit complex. So, I hope you are having fun with your project.
I just ran clirr against the 1.3 version and it showed only additions.
So, from its perspective it is backwards compatible. However, for the
one line
Hi Matt and Simo,
I've attached the patch to the bug and fixed the issues mentioned with faces.
What other steps do I need to do now?
Thanks,
-Elijah
On Mon, Aug 15, 2011 at 6:22 AM, Matt Benson gudnabr...@gmail.com wrote:
Hi, Elijah--
I am neither a develop nor even a user of chain, so my
Be patient, while not being so patient that you allow us to forget it.
Matt
On Wed, Aug 17, 2011 at 12:01 PM, Elijah Zupancic eli...@zupancic.name wrote:
Hi Matt and Simo,
I've attached the patch to the bug and fixed the issues mentioned with faces.
What other steps do I need to do now?
BTW, please don't take the previous response as indicating any
negativity on my part. Feel free to prod us as long as possible, at
reasonable frequency.
Matt
On Wed, Aug 17, 2011 at 12:04 PM, Matt Benson gudnabr...@gmail.com wrote:
Be patient, while not being so patient that you allow us to
Hi Elijah,
looking at the patch, it seems that v2.0 is binary compatible to old
chain, right?
I mean, if in a my hypothetical application I would upgrade to v2
(generics a part) old code should continue working, right?
TIA, and count also on me!
All the best, have a nice day!
Simo
Hi again Elijah,
as a side note, since you already submitted the ICLA - and I hope you
are interested on continuing to submit contributions - I suggest you
to start reading the Apache Committers guide[1] and how the ASF works
doc[2] to get more familiar with the Apache way... hopefully you will
Hi Simo,
Yes, the patch is binary compatible with the old chain with one exception:
org.apache.commons.chain.web.servlet.ServletHeaderValuesMap on line
97. Previously the API was returning SetEntryString,
EnumerationString when by all indications it actually should have
been returning
I may have missed the discussion... but are we releasing a Java 5
genericized version first before major refactoring?
On Tue, Aug 16, 2011 at 3:35 PM, Elijah Zupancic eli...@zupancic.name wrote:
Hi Simo,
Yes, the patch is binary compatible with the old chain with one exception:
Hi Paul,
I haven't heard any discussion about a pending refactor to chain in
the last month (when I proposed the patch). Could you tell me/us more
about any plans for a major refactoring?
Thanks,
-Elijah
On Tue, Aug 16, 2011 at 1:42 PM, Paul Benedict pbened...@apache.org wrote:
I may have
I misunderstood CHAIN-53 then.
On Tue, Aug 16, 2011 at 4:29 PM, Elijah Zupancic eli...@zupancic.name wrote:
Hi Paul,
I haven't heard any discussion about a pending refactor to chain in
the last month (when I proposed the patch). Could you tell me/us more
about any plans for a major
Hi, Elijah--
I am neither a develop nor even a user of chain, so my comments will
be high-level. Firstly, by all means upgrade to whatever JUnit 4
release version you like, e.g. 4.8.2. Next, I personally am a big fan
of Mockito, so no complaints here on that account. I can't guarantee
noone
On Mon, Aug 15, 2011 at 8:22 AM, Matt Benson gudnabr...@gmail.com wrote:
Hi, Elijah--
I am neither a develop nor even a user of chain, so my comments will
[SNIP]
Nay, nor even a develop[er]. :|
Matt
-
To unsubscribe,
Hi Matt,
Thanks for the advice. I've created a JIRA issue for the patch
(https://issues.apache.org/jira/browse/CHAIN-53) and signed and
submitted the CLA.
As for JSF, I believe I made a mistake in changing the API to use the
office jsf API instead of the myfaces API that was previously being
I've just finished my proof of concept for an upgrade to Apache chain.
I would love to get this into a svn branch. I'm not quite sure what
the procedure is to do that, but the code can be found here for
review:
http://elijah.zupancic.name/projects/commons-chain-v2-proof-of-concept.tar.gz
And
16 matches
Mail list logo
