Re: [release-plugin] multimodule sites

2018-08-30 Thread Matt Benson
To answer my own question, we already have JaCoCo reporting configured, so I am going to remove javancss rather than be hobbled in terms of what code we can write. Matt On Thu, Aug 30, 2018, 2:43 PM Matt Benson wrote: > It ended up being quite easy to get the unit test to pass, though the new

Re: [release-plugin] multimodule sites

2018-08-30 Thread Matt Benson
It ended up being quite easy to get the unit test to pass, though the new functionality is no more tested than was the existing username/password functionality. I do find in attempting to generate the site that, despite the plugin's having been set to build with Java 8, it seems that the javancss

Re: [release-plugin] multimodule sites

2018-08-29 Thread Rob Tompkins
> On Aug 29, 2018, at 7:16 PM, Matt Benson wrote: > >> On Wed, Aug 29, 2018, 5:41 PM Rob Tompkins wrote: >> >> >> >>> On Aug 29, 2018, at 4:43 PM, Matt Benson wrote: >>> >>> I have opened and resolved [1]. I classified this as a bug. Should we >>> consider a 1.4.1 release or just leave

Re: [release-plugin] multimodule sites

2018-08-29 Thread Matt Benson
On Wed, Aug 29, 2018, 5:41 PM Rob Tompkins wrote: > > > > On Aug 29, 2018, at 4:43 PM, Matt Benson wrote: > > > > I have opened and resolved [1]. I classified this as a bug. Should we > > consider a 1.4.1 release or just leave the master version at > 1.5-SNAPSHOT? > > I can do either. Seems

Re: [release-plugin] multimodule sites

2018-08-29 Thread Rob Tompkins
> On Aug 29, 2018, at 4:43 PM, Matt Benson wrote: > > I have opened and resolved [1]. I classified this as a bug. Should we > consider a 1.4.1 release or just leave the master version at 1.5-SNAPSHOT? I can do either. Seems like a good move before [parent] v48. Thoughts? -Rob > It appears

[release-plugin] multimodule sites

2018-08-29 Thread Matt Benson
I have opened and resolved [1]. I classified this as a bug. Should we consider a 1.4.1 release or just leave the master version at 1.5-SNAPSHOT? It appears I can do the weaver release using a locally overridden snapshot build of the plugin, so I don't think I'm blocked (or worse, forced to do