Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

@Emmanuel: tomee does not use tomcat-dbcp, it facade any JDBC pool library with its own code so any managed package usage is really legacy since ~10 years. Romain Manni-Bucau @rmannibucau | Blog | Old Blog

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

David wrote something similar on the tomee dev@ list [1]. So perhaps it would be worth to just provide a jakarta capable package? [1] https://lists.apache.org/thread/gkmrdlwo1gpbzogqvrdyq1zqqt6pompc Am Montag, dem 19.06.2023 um 14:09 +0200 schrieb Emmanuel Bourg: > On 26/05/2023 12:20, Romain

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

On 26/05/2023 12:20, Romain Manni-Bucau wrote: TomEE can drop managed package legacy dependency now, was kept while the replacement was in test in 1.x version but makes years it is no more relevant and no more the default (since we switched to tomcat-jdbc). So no big deal if dbcp wants to drop

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Hey Romain, thanks for the info regarding the historic back story ;) So perhaps time to drop it, i will take that on the TomEE list. Gruß Richard Am Freitag, dem 26.05.2023 um 12:20 +0200 schrieb Romain Manni-Bucau: > Hi Richard, > > TomEE can drop managed package legacy dependency now, was

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Hi Richard, TomEE can drop managed package legacy dependency now, was kept while the replacement was in test in 1.x version but makes years it is no more relevant and no more the default (since we switched to tomcat-jdbc). So no big deal if dbcp wants to drop it on TomEE side IMHO. Romain

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

The current TomEE codebase still uses classes from the "managed" package of dbcp2. (Thus, we are shading it for TomEE 9 / 10) We might be able to drop that integration at some point but currently our focus is on getting a EE10 milestone out of the door, so I don't think, that it is a theoretical

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Le 11/05/2023 à 15:56, Richard Zowalla a écrit : Hi, do we have any updates? How can I help to get a dbcp version supporting Jakarta namespace? Emmanuel outlined a possible appraoch. How can we move forward with it? I'm tempted to merge the dual-javax-jakarta branch, but Romain's comment

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Hi, do we have any updates? How can I help to get a dbcp version supporting Jakarta namespace? Emmanuel outlined a possible appraoch. How can we move forward with it? Thanks & Gruß Richard On 2022/12/30 12:52:45 Richard Zowalla wrote: > Thanks a lot, Emmanuel!  > > It looks good to me!

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Great news, Gary! Very much appreciated. Gruß Richard Am Donnerstag, dem 19.01.2023 um 06:11 -0500 schrieb Gary Gregory: > Patience ;-) I am in the middle of releasing Commons Crypto. I can > take a > look this weekend and see what our options are... > > Gary > > On Thu, Jan 19, 2023, 04:42

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Patience ;-) I am in the middle of releasing Commons Crypto. I can take a look this weekend and see what our options are... Gary On Thu, Jan 19, 2023, 04:42 Richard Zowalla wrote: > So what do we need to move forward with this once? :-) > > Gruß > Richard > > Am Sonntag, dem 01.01.2023 um

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

So what do we need to move forward with this once? :-) Gruß Richard Am Sonntag, dem 01.01.2023 um 17:09 +0100 schrieb Jean-Baptiste Onofré: > It looks good to me. > > Thanks, > Regards > JB > > On Sat, Dec 31, 2022 at 12:15 PM Emmanuel Bourg > wrote: > > I've experimented with another

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

It looks good to me. Thanks, Regards JB On Sat, Dec 31, 2022 at 12:15 PM Emmanuel Bourg wrote: > > I've experimented with another approach, a single version > supporting both javax.transaction and jakarta.transaction: > > https://github.com/ebourg/commons-dbcp/tree/dual-javax-jakarta > >

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Sounds good to me. Ultilately this managed package could also disappear I guess since it was mainly for geronimo and tomee which disappeared or dont use it anymore. Le sam. 31 déc. 2022 à 12:25, Richard Zowalla a écrit : > I guess, that it would need some tests to show, that it is working >

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

I guess, that it would need some tests to show, that it is working correctly? Otherwise it would raise similar concerns as for the PR using Maven Shading to achieve the transition. Gruß Richard P.S. Build is currently failing for that one. Am Samstag, dem 31.12.2022 um 12:15 +0100 schrieb

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

I've experimented with another approach, a single version supporting both javax.transaction and jakarta.transaction: https://github.com/ebourg/commons-dbcp/tree/dual-javax-jakarta The only classes using javax.transaction are in the org.apache.commons.dbcp2.managed package. This package is

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Thanks a lot, Emmanuel!  It looks good to me! Gruß Richard Am Donnerstag, dem 29.12.2022 um 22:02 +0100 schrieb Emmanuel Bourg: > Thank you, it works perfectly now. > > I've pushed the changes to: > > https://github.com/ebourg/commons-dbcp/tree/jakarta > > Comments are welcome

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Le jeu. 29 déc. 2022 à 22:02, Emmanuel Bourg a écrit : > Thank you, it works perfectly now. > > I've pushed the changes to: > > https://github.com/ebourg/commons-dbcp/tree/jakarta  > > Comments are welcome before I create a dbcp3 branch on the ASF repository. > > I think the API should

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Thank you, it works perfectly now. I've pushed the changes to: https://github.com/ebourg/commons-dbcp/tree/jakarta Comments are welcome before I create a dbcp3 branch on the ASF repository. I think the API should be kept identical to dbcp2 to ease porting changes and facilitate

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Hi Emmanuel, You have https://repo1.maven.org/maven2/org/apache/geronimo/components/geronimo-transaction/3.1.5/geronimo-transaction-3.1.5-jakarta.jar which is usable if you exclude transitive deps. Romain Manni-Bucau @rmannibucau | Blog

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Thank you for the pointers, the Narayana and JBoss artifacts look good, but I haven't found a replacement for geronimo-transaction. I tried replacing the Geronimo Transaction implementation with the one from Narayana but got 4 test failures. I'll try to process the geronimo-transaction jar at

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

@Gary as mentionned there are matches but also notice several vendors (most) abandonned the game due to the new governance so dont expect as much choices as before. Le mer. 28 déc. 2022 à 07:24, Richard Zowalla a écrit : > There is a Jakarta artifact available for Narayana: narayana-jta-jakarta

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

There is a Jakarta artifact available for Narayana: narayana-jta-jakarta For the SPI: jboss-transaction-spi-jakarta (because JBoss plays the namespace game with their app server ;-) ) Geronimo most likely also provides a Jakarta version or (if it is only API) can be replaced by the Jakarta

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

There is non point in doing this "quickly", if there is no match in the namespace game for the test dependencies, it only goes to prove that the whole ecosystem has not progressed far enough or is mature enough. Gary On Tue, Dec 27, 2022, 16:28 Emmanuel Bourg wrote: > I tried to replace javax

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

@Emmanuel Bourg you can use jakarta artifacts directly for dbcp or tomee ones which provides jakarta namespace. Le mar. 27 déc. 2022 à 22:28, Emmanuel Bourg a écrit : > I tried to replace javax with jakarta in DBCP, the less trivial part is > to find a replacement for the test dependencies: >

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

I tried to replace javax with jakarta in DBCP, the less trivial part is to find a replacement for the test dependencies: - org.apache.geronimo.modules:geronimo-transaction - org.jboss.narayana.jta:narayana-jta - and maybe org.jboss:jboss-transaction-spi Or we disable the transaction tests

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

@Gary: I agree with the plan but as Romain outlined, it requires some details / perspective. Am Montag, dem 19.12.2022 um 21:33 +0100 schrieb Romain Manni-Bucau: > @gary: you likely need to refine your plan to make it a plan and not > a > discussion proposal, ie put some date. If you want to

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

@gary: you likely need to refine your plan to make it a plan and not a discussion proposal, ie put some date. If you want to release dbcp2 this year and move to dbcp3 in january for a 1.0.0 (or whatever version) in early february I guess it works for everyone. If it is about waiting 1-2 months to

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

I feel like we're going around in circles. Do you not agree my the path I previously outlined? Gary On Mon, Dec 19, 2022 at 2:12 PM Richard Zowalla wrote: > > I can only say, that I fully agree with Romain here. > > For example, we are shading dbcp2 with jakarta.* relocations in TomEE 9 >

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

I can only say, that I fully agree with Romain here. For example, we are shading dbcp2 with jakarta.* relocations in TomEE 9 (targeting EE9.1 / jakarta.*). I don't think, that it is a good thing to let the users fork/relocate or abandon dbcp2 in order to be able to use the jakarta.* namespace.

Re: Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Le lun. 19 déc. 2022 à 16:25, Eric Bresie a écrit : > I’ve not used it so not sure but would this help any in migrating the > namespace? > > https://github.com/apache/tomcat-jakartaee-migration It is strictly equivalent to the shade option but requires maven build helper plugin to attach the

Re: Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

I’ve not used it so not sure but would this help any in migrating the namespace? https://github.com/apache/tomcat-jakartaee-migration Eric Bresie ebre...@gmail.com (mailto:ebre...@gmail.com) > On December 17, 2022 at 3:08:47 PM CST, Richard Zowalla (mailto:rich...@zowalla.com)> wrote: > Sure.

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Le dim. 18 déc. 2022 à 12:04, Gary Gregory a écrit : > What's the rush? Commons has never been on the bleeding edge of anything. > Java and EE release rates changed - as well as spring baseline. If commons sticks to the old one it is harder (impossible) to use directly. Today dbcp is either

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

What's the rush? Commons has never been on the bleeding edge of anything. You saw the plan I proposed I presume. Gary On Sun, Dec 18, 2022, 04:38 Romain Manni-Bucau wrote: > Any idea on when it can occurs? We are quite late to the party already and > shade was a good solution to be in without

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Any idea on when it can occurs? We are quite late to the party already and shade was a good solution to be in without additional cost in terms of maintainance for the project so if not the picked option we should target some point not too far in 2023 pby. Le dim. 18 déc. 2022 à 01:44, Gary

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Hi Arun, There's not going to be anything to pick up for a while ;-) Gary On Sat, Dec 17, 2022, 18:06 Arun Avanathan wrote: > Gary - if we have a ticket to upgrade DBCP to java 11, I can take it up. > > > On Dec 17, 2022, at 1:09 PM, Richard Zowalla > wrote: > > > > Sure. Sounds like a plan

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Gary - if we have a ticket to upgrade DBCP to java 11, I can take it up. > On Dec 17, 2022, at 1:09 PM, Richard Zowalla wrote: > > Sure. Sounds like a plan :) > > Am 17. Dezember 2022 22:06:48 MEZ schrieb Gary Gregory > : >> I think we should wait for a little while: I'd want to release

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Sure. Sounds like a plan :) Am 17. Dezember 2022 22:06:48 MEZ schrieb Gary Gregory : >I think we should wait for a little while: I'd want to release current code >from git for Commons Pool, then DBCP (which sits on top of Pool), make sure >all is well, then see about going to DBCP 3, on Java 8

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

I think we should wait for a little while: I'd want to release current code from git for Commons Pool, then DBCP (which sits on top of Pool), make sure all is well, then see about going to DBCP 3, on Java 8 for now but considering Java 11 maybe. Do consider that the Commons community is small and

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

For DBCP, it basically boils down to BasicManagedDataSource.java DataSourceXAConnectionFactory.java LocalXAConnectionFactory.java SynchronizationAdapter.java TransactionContext.java TransactionRegistry.java Looking at these classes, the move to jakarta definitley affects binary compatibility as

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

If not done in new classes (both can live in the same lib technically), sadly yes. Le ven. 16 déc. 2022 à 20:14, Richard Zowalla a écrit : > Thanks for your replies. > > I guess, that switching the namespace leads to binary incompatibility (If > I take the definition from [1]). I cannot drop it

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Thanks for your replies. I guess, that switching the namespace leads to binary incompatibility (If I take the definition from [1]). I cannot drop it in a running JVM / app and expect no issues with it as the related APIs are breaking namespace changes (at least at runtime if they aren't

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

On 16/12/2022 13:24, Gary Gregory wrote: Thank you Richard for starting this thread. My view is simpler perhaps: I would not make this about the javax vs Jakarta namespaces. I don't want to double the numbers of jars we produce from the same branch for affected components as one of the scheme

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

Thank you Richard for starting this thread. My view is simpler perhaps: I would not make this about the javax vs Jakarta namespaces. I don't want to double the numbers of jars we produce from the same branch for affected components as one of the scheme proposed. It feels like a burden to

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

-1 for c and d, +1 for a, guess b can still be an option for ~2 years before switching to a Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github |