Greetings,
I've noticed that some methods on the org.apache.commons.mail.Email
class provide fluent interface (examples include setCc, addBcc,
addReplyTo), and some do not (to name a few: setAuthentication,
setSmtpPort, setMailSession). Is this intentional, or am I allowed to
submit a PR
On Fri, 29 Sept 2023 at 12:13, Filip Strajnar wrote:
>
> Greetings,
>
>
> I've noticed that some methods on the org.apache.commons.mail.Email
> class provide fluent interface (examples include setCc, addBcc,
> addReplyTo), and some do not (to name a few: setAuthentication,
> setSmtpPort,
Personal opinion: it probably wasn't intentional, but please don't do
that. It doesn't help anyone and is needless churn. Fluent methods are
not better than non-fluent ones, and are in fact less semantic and
harder to debug. They prioritize saving code writing over code
maintainability.
Not just
At some point in the future we will have a 2.0 and that's when to revist
this issue. Feel free to create a Jira ticket to request this as a feature
for a future 2.0.
Gary
On Fri, Sep 29, 2023, 7:47 AM Elliotte Rusty Harold
wrote:
> Personal opinion: it probably wasn't intentional, but please
I think the natural next question is whether we can have a major version
change?
Mike
On Fri, Sep 29, 2023 at 6:24 AM sebb wrote:
> On Fri, 29 Sept 2023 at 12:13, Filip Strajnar
> wrote:
> >
> > Greetings,
> >
> >
> > I've noticed that some methods on the org.apache.commons.mail.Email
> >
Hello,
The FAQ link at the bottom of this page is broken:
https://commons.apache.org/proper/commons-logging/guide.html#Frequently_Asked_Questions
The link currently points to:
http://wiki.apache.org/commons/Logging/FrequentlyAskedQuestions
The correct link is:
Hi,
The link was indeed broken, thanks for pointing that out and for the
correction. I've updated it on master (credited you by name in the commit
[1], hope that's OK), and re-published the site.
Cheers,
Bruno
[1]
My +1
Gary
On Wed, Sep 27, 2023 at 7:38 AM Bruno Kinoshita wrote:
>
>[x] +1 Release these artifacts
>
> On Tue, 26 Sept 2023 at 18:39, Gary Gregory wrote:
>
> > We have fixed a few bugs and added some enhancements since Apache
> > Commons IO 2.13.0 was released, so I would like to release
After carefully reviewing the Spotbugs report, I am going to change my vote
to
+1
Most of the complaints are about returning references vs copies of things
in getters. The SA_LOCAL_SELF_COMPARISON complaint looks legit, but
probably harmless because it appears to have been there for a long
This vote thread passes with the following binding votes:
- Rob Tompkins +1
- Phil Steitz +0
- Bruno Kinoshita +1
- Gary Gregory +1
Gary
On Fri, Sep 29, 2023 at 2:52 PM Gary Gregory wrote:
>
> My +1
>
> Gary
>
> On Wed, Sep 27, 2023 at 7:38 AM Bruno Kinoshita
> wrote:
> >
> >[x] +1
This vote has passed with binding +1 votes from
Bruno Kinoshita
Gary Gregory
Rob Tompkins
Phil Steitz
and no other votes.
Thanks to all who reviewed the release candidate.
Phil
On Tue, Sep 26, 2023 at 12:50 PM Phil Steitz wrote:
> We have fixed quite a few bugs and added some significant
11 matches
Mail list logo