Re: Apache janitor ?

2011-06-09 Thread Mark Montague
On June 8, 2011 20:11 , Igor =?utf-8?Q?Gali=C4=87?= i.ga...@brainsware.org wrote: One of the many good suggestions they propose is to have a Patch Manager - someone who makes sure that patches submitted via Bugzilla or directly to the list don't get lost in the noise and that people get some

Re: svn commit: r1132802 - in /httpd/httpd/trunk/docs/manual: mod/mod_setenvif.xml rewrite/access.xml rewrite/intro.xml rewrite/rewritemap.xml ssl/ssl_faq.xml ssl/ssl_howto.xml vhosts/examples.xml

2011-06-09 Thread Ruediger Pluem
On 06/07/2011 12:09 AM, s...@apache.org wrote: Author: sf Date: Mon Jun 6 22:09:22 2011 New Revision: 1132802 URL: http://svn.apache.org/viewvc?rev=1132802view=rev Log: purge some useless uses of '.*' Modified: httpd/httpd/trunk/docs/manual/mod/mod_setenvif.xml

Re: svn commit: r1132802 - in /httpd/httpd/trunk/docs/manual: mod/mod_setenvif.xml rewrite/access.xml rewrite/intro.xml rewrite/rewritemap.xml ssl/ssl_faq.xml ssl/ssl_howto.xml vhosts/examples.xml

2011-06-09 Thread Stefan Fritsch
On Thursday 09 June 2011, Ruediger Pluem wrote: On 06/07/2011 12:09 AM, s...@apache.org wrote: Author: sf Date: Mon Jun 6 22:09:22 2011 New Revision: 1132802 URL: http://svn.apache.org/viewvc?rev=1132802view=rev Log: purge some useless uses of '.*' Modified:

Re: svn commit: r1131467 - in /httpd/httpd/trunk/include: http_protocol.h http_request.h util_cookies.h util_script.h

2011-06-09 Thread Ruediger Pluem
On 06/04/2011 09:00 PM, s...@apache.org wrote: Author: sf Date: Sat Jun 4 19:00:16 2011 New Revision: 1131467 URL: http://svn.apache.org/viewvc?rev=1131467view=rev Log: Add __attribute__((sentinel)) to a few functions that require a terminal NULL argument. Modified:

Re: svn commit: r1133582 - in /httpd/httpd/trunk: CHANGES docs/manual/filter.xml docs/manual/mod/mod_data.xml docs/manual/mod/mod_data.xml.meta docs/manual/new_features_2_4.xml modules/filters/config.

2011-06-09 Thread Ruediger Pluem
On 06/09/2011 12:13 AM, minf...@apache.org wrote: Author: minfrin Date: Wed Jun 8 22:13:21 2011 New Revision: 1133582 URL: http://svn.apache.org/viewvc?rev=1133582view=rev Log: mod_data: Introduce a filter to support RFC2397 data URLs. Added:

Possible uninitialized variable in mod_data.c

2011-06-09 Thread Chris Wilson
Hi Folks, We recently started using Sentry (static analysis tool) to analyze apache httpd on a nightly basis. Sentry found a potential unintialized variable in mod_data.c added in commit 1133582. I'm not sure if this case is actually possible at runtime, but I'll describe it here. Note, you can

Possible unintiialized variable usage in mod_data.c

2011-06-09 Thread Chris Wilson
Hi Folks, We recently started using Sentry (static analysis tool) to analyze apache httpd on a nightly basis. Sentry found a potential unintialized variable in mod_data.c added in commit 1133582. I'm not sure if this case is actually possible at runtime, but I'll describe it here. Note, you can

RE: [PR #51258] new features for mod_substitute

2011-06-09 Thread Yehezkel Horowitz
Hi Everyone I didn't have any reply to the new features I have made to mod_substitute. If any of you use this module, you might find those features helpful. Regards, Yehezkel From: Yehezkel Horowitz [mailto:horow...@checkpoint.com] Sent: Tuesday, May 24, 2011

Re: Possible uninitialized variable in mod_data.c

2011-06-09 Thread Igor Galić
- Original Message - Hi Folks, We recently started using Sentry (static analysis tool) to analyze apache httpd on a nightly basis. Sentry found a potential unintialized variable in mod_data.c added in commit 1133582. I think our human review machine already caught that one

Re: Apache janitor ?

2011-06-09 Thread Igor Galić
- Original Message - On June 8, 2011 20:11 , Igor =?utf-8?Q?Gali=C4=87?= i.ga...@brainsware.org wrote: One of the many good suggestions they propose is to have a Patch Manager - someone who makes sure that patches submitted via Bugzilla or directly to the list don't get lost in

Re: svn commit: r1133582 - in /httpd/httpd/trunk: CHANGES docs/manual/filter.xml docs/manual/mod/mod_data.xml docs/manual/mod/mod_data.xml.meta docs/manual/new_features_2_4.xml modules/filters/config.

2011-06-09 Thread Graham Leggett
On 09 Jun 2011, at 9:16 AM, Ruediger Pluem wrote: +/* make sure we don't read more than 6000 bytes at a time */ +apr_brigade_partition(bb, (APR_BUCKET_BUFF_SIZE / 4 * 3), e); Shouldn't we move this below the the checking for the metadata bucket? Why partitioning again, when

Re: Possible unintiialized variable usage in mod_data.c

2011-06-09 Thread Graham Leggett
On 09 Jun 2011, at 4:06 PM, Chris Wilson wrote: We recently started using Sentry (static analysis tool) to analyze apache httpd on a nightly basis. Sentry found a potential unintialized variable in mod_data.c added in commit 1133582. Indeed it is - not sure why -Wall didn't catch this. Fixed