Re: [VOTE] Release Apache httpd 2.4.25 as GA

2016-12-16 Thread William A Rowe Jr
On Sat, Dec 17, 2016 at 12:51 AM, William A Rowe Jr wrote: > Color me confused, is this w/w-o the hack for APR_HAVE_TIME_T? > Nevermind, that issues is entirely resolved. Thanks for confirmation! > On Sat, Dec 17, 2016 at 12:09 AM, Jan Ehrhardt

Re: [VOTE] Release Apache httpd 2.4.25 as GA

2016-12-16 Thread William A Rowe Jr
Color me confused, is this w/w-o the hack for APR_HAVE_TIME_T? On Sat, Dec 17, 2016 at 12:09 AM, Jan Ehrhardt wrote: > Jim Jagielski in gmane.comp.apache.devel (Fri, 16 Dec 2016 13:29:04 > -0500): > >[x] +1: Good to go > > Running without problems on my dev server now. >

Re: svn commit: r1774650 - /httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak

2016-12-16 Thread William A Rowe Jr
I'm torn whether this is a showstopper or not. In all fairness, feature/enhancement crap modified 2.4.x branch as of; Modified *Tue Dec 13 13:57:02 2016 UTC* (3 days, 16 hours ago) by *jim* So the question is, is it fair to other platform maintainers to deal with enhancements requiring build

Re: [VOTE] Release Apache httpd 2.4.25 as GA

2016-12-16 Thread Jan Ehrhardt
Jim Jagielski in gmane.comp.apache.devel (Fri, 16 Dec 2016 13:29:04 -0500): >[x] +1: Good to go Running without problems on my dev server now. Windows 2008 R2, VC9 x86 and VC11, x64 -- Jan

Re: [VOTE] Release Apache httpd 2.4.25 as GA

2016-12-16 Thread William A Rowe Jr
On Fri, Dec 16, 2016 at 3:01 PM, Rainer Jung wrote: > Am 16.12.2016 um 21:11 schrieb Jacob Champion: > >> On 12/16/2016 10:29 AM, Jim Jagielski wrote: >> >>> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA. >>> >> >> mod_ext_filter tests are failing for

Re: [VOTE] Release Apache httpd 2.4.25 as GA

2016-12-16 Thread Rainer Jung
Am 16.12.2016 um 21:11 schrieb Jacob Champion: On 12/16/2016 10:29 AM, Jim Jagielski wrote: I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA. mod_ext_filter tests are failing for me on Ubuntu 16.04 x64, but I *think* this is due to a bug in the tests as opposed to a regression,

Re: [VOTE] Release Apache httpd 2.4.25 as GA

2016-12-16 Thread Jacob Champion
On 12/16/2016 12:44 PM, William A Rowe Jr wrote: I expect this is a bug in the 2.4.x branch. However, I found the same exceptions in 2.4.23 tag, so this is not a regression, and Joe is still researching what is happening here, so it doesn't seem to be something we would want to hold up a release

Re: [VOTE] Release Apache httpd 2.4.25 as GA

2016-12-16 Thread William A Rowe Jr
On Fri, Dec 16, 2016 at 2:11 PM, Jacob Champion wrote: > On 12/16/2016 10:29 AM, Jim Jagielski wrote: > >> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA. >> > > mod_ext_filter tests are failing for me on Ubuntu 16.04 x64, but I *think* > this is due to a

Re: [VOTE] Release Apache httpd 2.4.25 as GA

2016-12-16 Thread Jacob Champion
On 12/16/2016 10:29 AM, Jim Jagielski wrote: I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA. mod_ext_filter tests are failing for me on Ubuntu 16.04 x64, but I *think* this is due to a bug in the tests as opposed to a regression, related to the conversation in [1]. Does

Re: svn commit: r1774650 - /httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak

2016-12-16 Thread William A Rowe Jr
On Fri, Dec 16, 2016 at 1:41 PM, William A Rowe Jr wrote: > On Fri, Dec 16, 2016 at 1:36 PM, Rainer Jung > wrote: > >> Thanks, didn't notice the mak files, because trunk doesn't have them. >> >> I just noticed that the RSC_PROJ lines in the mak

Re: svn commit: r1774650 - /httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak

2016-12-16 Thread William A Rowe Jr
On Fri, Dec 16, 2016 at 1:36 PM, Rainer Jung wrote: > Thanks, didn't notice the mak files, because trunk doesn't have them. > > I just noticed that the RSC_PROJ lines in the mak files also contain > include directories but not the one for "generators", in nove of the

Re: svn commit: r1774650 - /httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak

2016-12-16 Thread Rainer Jung
Thanks, didn't notice the mak files, because trunk doesn't have them. I just noticed that the RSC_PROJ lines in the mak files also contain include directories but not the one for "generators", in nove of the cache module mak files. I have no idea what RSC_PROJ is used for but it looks

Re: Fixing module-specific, public include/*.h file inclusion on trunk

2016-12-16 Thread William A Rowe Jr
On Fri, Dec 16, 2016 at 12:57 PM, William A Rowe Jr wrote: > So today's primary bogus result is courtesy of is due to leaving > public headers hiding in modules/class/*.h paths for our builds. > > I'd suggest one of two approaches, pick a favorite solution? > > [ ] Have

Fixing module-specific, public include/*.h file inclusion on trunk

2016-12-16 Thread William A Rowe Jr
So today's primary bogus result is courtesy of is due to leaving public headers hiding in modules/class/*.h paths for our builds. I'd suggest one of two approaches, pick a favorite solution? [ ] Have the top level build copy all modules/*/mod_*.h definitions to the build tree include/

Re: svn commit: r1774609 - /httpd/httpd/trunk/modules/cache/mod_socache_memcache.dsp

2016-12-16 Thread William A Rowe Jr
Erm... did you miss the same edit to mod_socache_memcache.mak? (Just catching up on the flurry of traffic, so this is speculation.) Further speculation, are we solid for NetWare now? Any word, Norm? [wrowe@hub cache]$ grep "/generators" * mod_cache_socache.dsp:# ADD CPP /nologo /MD /W3 /O2 /Oy-

[VOTE] Release Apache httpd 2.4.25 as GA

2016-12-16 Thread Jim Jagielski
At long, long last, the pre-release test tarballs for Apache httpd version 2.4.25 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA. [ ] +1: Good to go [ ] +0: meh [ ] -1: Danger Will Robinson. And why.

[REVOKED] Re: [VOTE] Release Apache httpd 2.4.24 as GA

2016-12-16 Thread Jim Jagielski
This call is REVOKED! > On Dec 16, 2016, at 7:06 AM, Jim Jagielski wrote: > > At long, long last, the pre-release test tarballs for Apache httpd > version 2.4.24 can be found at the usual place: > > http://httpd.apache.org/dev/dist/ > > I'm calling a VOTE on releasing

Re: [VOTE] Release Apache httpd 2.4.24 as GA

2016-12-16 Thread Steffen
Building fine and running now with Exported revision 1774631 (with r1706595). Steffen -Original Message- From: Rainer Jung Sent: Friday, December 16, 2016 4:22 PM To: dev@httpd.apache.org Subject: Re: [VOTE] Release Apache httpd 2.4.24 as GA I think the following missing simple

Re: [VOTE] Release Apache httpd 2.4.24 as GA

2016-12-16 Thread Rainer Jung
I think the following missing simple backport from trunk is fixing it: http://svn.apache.org/r1706595 Regards, Rainer Am 16.12.2016 um 15:59 schrieb Steffen: Reverted that change, building and running now. On Friday 16/12/2016 at 15:01, Jim Jagielski wrote: Looks related to:

Re: [VOTE] Release Apache httpd 2.4.24 as GA

2016-12-16 Thread Rainer Jung
OK, but the shorter path is what is in the other Windows build files for modules which already use mod_status.h, so I'd prefer it for consistency. Regards, Rainer Am 16.12.2016 um 16:12 schrieb Steffen: I did already: /I "../../modules/generators" instead of /I "../generators" And that

Re: [VOTE] Release Apache httpd 2.4.24 as GA

2016-12-16 Thread Steffen
I did already: /I "../../modules/generators" instead of /I "../generators" And that works. Cheers, Steffen On Friday 16/12/2016 at 16:02, Rainer Jung wrote: Am 16.12.2016 um 15:13 schrieb Steffen: An other one: mod_socache_memcache.c(38): fatal error C1083: Cannot open include file:

Re: [VOTE] Release Apache httpd 2.4.24 as GA

2016-12-16 Thread Jim Jagielski
Hmmm Weird that using the "official" macro test results in the error... Waiting to hear from other Win people. > On Dec 16, 2016, at 9:59 AM, Steffen wrote: > > Reverted that change, building and running now. > > On Friday 16/12/2016 at 15:01, Jim Jagielski wrote: >>

Re: [VOTE] Release Apache httpd 2.4.24 as GA

2016-12-16 Thread Rainer Jung
Am 16.12.2016 um 15:13 schrieb Steffen: An other one: mod_socache_memcache.c(38): fatal error C1083: Cannot open include file: 'mod_status.h': No such file or directory Build files are not changed to include mod_status.h This specific problem is hopefully fixed by:

Re: [VOTE] Release Apache httpd 2.4.24 as GA

2016-12-16 Thread Steffen

Re: [VOTE] Release Apache httpd 2.4.24 as GA

2016-12-16 Thread Steffen
An other one: mod_socache_memcache.c(38): fatal error C1083: Cannot open include file: 'mod_status.h': No such file or directory Build files are not changed to include mod_status.h On Friday 16/12/2016 at 13:07, Jim Jagielski wrote: At long, long last, the pre-release test tarballs for

Re: [VOTE] Release Apache httpd 2.4.24 as GA

2016-12-16 Thread Jim Jagielski
Looks related to: https://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/include/scoreboard.h?r1=1732275=1772330_format=h Which is weird. > On Dec 16, 2016, at 8:45 AM, Steffen wrote: > > No go on Windows VC14: > > ...\include\scoreboard.h(30): fatal error C1083:

Re: [VOTE] Release Apache httpd 2.4.24 as GA

2016-12-16 Thread Steffen
No go on Windows VC14: ...\include\scoreboard.h(30): fatal error C1083: Cannot open include file: 'sys/time.h': No such file or directory Steffen On Friday 16/12/2016 at 13:07, Jim Jagielski wrote: At long, long last, the pre-release test tarballs for Apache httpd version 2.4.24 can be

[VOTE] Release Apache httpd 2.4.24 as GA

2016-12-16 Thread Jim Jagielski
At long, long last, the pre-release test tarballs for Apache httpd version 2.4.24 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.24 GA. [ ] +1: Good to go [ ] +0: meh [ ] -1: Danger Will Robinson. And why.