Re: Default value of LuaScope in trunk mod_lua

2013-04-29 Thread Brian McCallister
+1 as long as we make it very obvious that is what it is. A risk is that when a developer is hacking, refreshing, hacking, refreshing they *will* always get the same VM, so they will expect that behavior and be surprised when it is used concurrently. On Thu, Apr 25, 2013 at 9:13 AM, Eric Covener

Default value of LuaScope in trunk mod_lua

2013-04-25 Thread Daniel Gruno
Hi dev@ people, I'm thinking of changing the default value of LuaScope in trunk to 'thread', as the current default, 'once', has a significant performance impact (as I explained at ApacheCon). As Lua's garbage collector is quite awesome (it's virtually impossible to leak memory unless you

Re: Default value of LuaScope in trunk mod_lua

2013-04-25 Thread Eric Covener
On Thu, Apr 25, 2013 at 10:24 AM, Daniel Gruno rum...@cord.dk wrote: Hi dev@ people, I'm thinking of changing the default value of LuaScope in trunk to 'thread', as the current default, 'once', has a significant performance impact (as I explained at ApacheCon). As Lua's garbage collector is

Re: Default value of LuaScope in trunk mod_lua

2013-04-25 Thread Daniel Gruno
On 04/25/2013 04:41 PM, Eric Covener wrote: On Thu, Apr 25, 2013 at 10:24 AM, Daniel Gruno rum...@cord.dk wrote: Hi dev@ people, I'm thinking of changing the default value of LuaScope in trunk to 'thread', as the current default, 'once', has a significant performance impact (as I explained

Re: Default value of LuaScope in trunk mod_lua

2013-04-25 Thread Eric Covener
I say go for it, it's an experimental module in 2.4.