Re: clang-analyzer?

2017-01-19 Thread Ruediger Pluem
On 01/19/2017 09:07 PM, William A Rowe Jr wrote: > On Thu, Jan 19, 2017 at 1:30 PM, Ruediger Pluem wrote: >> >> If they are no-ops as you state in 3. how could they introduce regressions? > > They are still a text and code change. Cleaning up a cast, for example may > change

Re: clang-analyzer?

2017-01-19 Thread William A Rowe Jr
On Thu, Jan 19, 2017 at 1:30 PM, Ruediger Pluem wrote: > > If they are no-ops as you state in 3. how could they introduce regressions? They are still a text and code change. Cleaning up a cast, for example may change the alignment differently between various 32 and 64 bit

Re: clang-analyzer?

2017-01-19 Thread Ruediger Pluem
On 01/19/2017 08:16 PM, William A Rowe Jr wrote: > On Mon, Jan 9, 2017 at 3:48 AM, Graham Leggett <minf...@sharp.fm> wrote: >> On 08 Jan 2017, at 4:45 AM, Leif Hedstrom <zw...@apache.org> wrote: >> >>> I ran clang-analyzer against the HTTPD master branch

Re: clang-analyzer?

2017-01-19 Thread William A Rowe Jr
On Mon, Jan 9, 2017 at 3:48 AM, Graham Leggett <minf...@sharp.fm> wrote: > On 08 Jan 2017, at 4:45 AM, Leif Hedstrom <zw...@apache.org> wrote: > >> I ran clang-analyzer against the HTTPD master branch, and it found 126 >> issues. Many of these are benign, but I wa

Re: clang-analyzer?

2017-01-17 Thread Jim Jagielski
> On Jan 9, 2017, at 4:48 AM, Graham Leggett <minf...@sharp.fm> wrote: > > On 08 Jan 2017, at 4:45 AM, Leif Hedstrom <zw...@apache.org> wrote: > >> I ran clang-analyzer against the HTTPD master branch, and it found 126 >> issues. Many of these are benign, bu

Re: clang-analyzer?

2017-01-15 Thread Jacob Champion
On 01/09/2017 01:48 AM, Graham Leggett wrote: The most effective contributions would be patches to fix each one. From experience it is difficult to fix these sort of things without the ability to rerun the analyser to ensure the issue is gone, and every now and again issues uncover things that

Re: clang-analyzer?

2017-01-15 Thread Daniel Ruggeri
On 1/9/2017 3:48 AM, Graham Leggett wrote: > Agreed that getting these things to zero would be a good thing to have. +1 here. The error report by itself is much less useful than an error report accompanied by a patch that addresses the benign things. -- Daniel Ruggeri

Re: clang-analyzer?

2017-01-09 Thread Graham Leggett
On 08 Jan 2017, at 4:45 AM, Leif Hedstrom <zw...@apache.org> wrote: > I ran clang-analyzer against the HTTPD master branch, and it found 126 > issues. Many of these are benign, but I was curious if the community has any > thoughts on this? With another project, I’ve found that k

Re: clang-analyzer?

2017-01-07 Thread William A Rowe Jr
invite reports of actual defects or security issues to be resolved. Cheers, Bill On Jan 7, 2017 8:45 PM, "Leif Hedstrom" <zw...@apache.org> wrote: > Howdy, > > I ran clang-analyzer against the HTTPD master branch, and it found 126 > issues. Many of these a

clang-analyzer?

2017-01-07 Thread Leif Hedstrom
Howdy, I ran clang-analyzer against the HTTPD master branch, and it found 126 issues. Many of these are benign, but I was curious if the community has any thoughts on this? With another project, I’ve found that keep static code analysis to zero issues can really help finding new, serious