Re: patch for handling headers_in and headers_out as tables in mod_lua

2009-03-18 Thread Bertrand Mansion
On Sun, Mar 1, 2009 at 2:37 AM, Brian McCallister bri...@skife.org wrote: On Fri, Feb 27, 2009 at 2:55 AM, Bertrand Mansion bmans...@mamasam.net wrote: And I find it weird that, now, to get 'document root', you have to call r:document_root() instead of r.document_root as it was before.

Re: patch for handling headers_in and headers_out as tables in mod_lua

2009-03-02 Thread Brian Akins
On 2/28/09 8:37 PM, Brian McCallister bri...@skife.org wrote: It could be just:    apr_hash_set(dispatch, document_root, APR_HASH_KEY_STRING,                 makefun(req_content_encoding_field, APL_REQ_FUNTYPE_STRING,                         p)); Also, couldn't we build the dispatch has

Re: patch for handling headers_in and headers_out as tables in mod_lua

2009-03-02 Thread Brian McCallister
-- Please forgive typos, sent from phone. On Mar 2, 2009, at 5:34 AM, Brian Akins br...@akins.org wrote: On 2/28/09 8:37 PM, Brian McCallister bri...@skife.org wrote: It could be just: apr_hash_set(dispatch, document_root, APR_HASH_KEY_STRING,

Re: patch for handling headers_in and headers_out as tables in mod_lua

2009-02-28 Thread Brian McCallister
On Fri, Feb 27, 2009 at 2:55 AM, Bertrand Mansion bmans...@mamasam.net wrote: By the way, for content-type, the dispatch function at the moment is:    if (0 == apr_strnatcmp(content_type, key)) {        const char *value = luaL_checkstring(L, 3);        r-content_type = apr_pstrdup(r-pool,

Re: patch for handling headers_in and headers_out as tables in mod_lua

2009-02-27 Thread Bertrand Mansion
On Thu, Feb 5, 2009 at 11:14 PM, Brian Akins br...@akins.org wrote: On 2/5/09 1:51 PM, Brian McCallister bri...@skife.org wrote: Yep, Paul changed the internal impl to be less gross, but in doing so changed the API, i changed the impl to be not gross and restored old API. Okay I see it now.

Re: patch for handling headers_in and headers_out as tables in mod_lua

2009-02-05 Thread Brian Akins
Is this in trunk? I don't see it, but I've been known to overlook stuff. On 1/26/09 1:45 PM, Brian McCallister bri...@skife.org wrote: For anyone following, it has been applied :-) -- NEW function handle(r) local host = r.headers_in['host'] r:puts(host) -- and can now modify them

Re: patch for handling headers_in and headers_out as tables in mod_lua

2009-02-05 Thread Brian McCallister
On Thu, Feb 5, 2009 at 10:44 AM, Brian Akins br...@akins.org wrote: Is this in trunk? I don't see it, but I've been known to overlook stuff. It is in trunk (httpd trunk) On 1/26/09 1:45 PM, Brian McCallister bri...@skife.org wrote: For anyone following, it has been applied :-) -- NEW

Re: patch for handling headers_in and headers_out as tables in mod_lua

2009-02-05 Thread Brian Akins
On 2/5/09 1:51 PM, Brian McCallister bri...@skife.org wrote: Yep, Paul changed the internal impl to be less gross, but in doing so changed the API, i changed the impl to be not gross and restored old API. Okay I see it now. I may take a crack at a little performance tuning. Setting up the

Re: patch for handling headers_in and headers_out as tables in mod_lua

2009-01-26 Thread Brian McCallister
For anyone following, it has been applied :-) On Thu, Jan 22, 2009 at 4:15 PM, Brian McCallister bri...@skife.org wrote: re-re-nudge :-) On Wed, Jan 14, 2009 at 1:03 PM, Brian McCallister bri...@skife.org wrote: re-nudge :-) On Tue, Jan 13, 2009 at 12:43 AM, Bertrand Mansion

Re: patch for handling headers_in and headers_out as tables in mod_lua

2009-01-22 Thread Brian McCallister
re-re-nudge :-) On Wed, Jan 14, 2009 at 1:03 PM, Brian McCallister bri...@skife.org wrote: re-nudge :-) On Tue, Jan 13, 2009 at 12:43 AM, Bertrand Mansion bmans...@mamasam.net wrote: +1 Le 13 janv. 09 à 05:28, Brian McCallister bri...@skife.org a écrit : Nudge -- if there are no

Re: patch for handling headers_in and headers_out as tables in mod_lua

2009-01-14 Thread Brian McCallister
re-nudge :-) On Tue, Jan 13, 2009 at 12:43 AM, Bertrand Mansion bmans...@mamasam.net wrote: +1 Le 13 janv. 09 à 05:28, Brian McCallister bri...@skife.org a écrit : Nudge -- if there are no objections to the patch, would someone be kind enough to apply it? -Brian On Sun, Jan 11, 2009 at

Re: patch for handling headers_in and headers_out as tables in mod_lua

2009-01-13 Thread Bertrand Mansion
+1 Le 13 janv. 09 à 05:28, Brian McCallister bri...@skife.org a écrit : Nudge -- if there are no objections to the patch, would someone be kind enough to apply it? -Brian On Sun, Jan 11, 2009 at 8:20 PM, Brian McCallister bri...@skife.org wrote: The attached patch changes headers_in

Re: patch for handling headers_in and headers_out as tables in mod_lua

2009-01-12 Thread Brian McCallister
Nudge -- if there are no objections to the patch, would someone be kind enough to apply it? -Brian On Sun, Jan 11, 2009 at 8:20 PM, Brian McCallister bri...@skife.org wrote: The attached patch changes headers_in and headers_out handling in mod_lua as boxed userdata rather than functions.

patch for handling headers_in and headers_out as tables in mod_lua

2009-01-11 Thread Brian McCallister
The attached patch changes headers_in and headers_out handling in mod_lua as boxed userdata rather than functions. Basically we go from: -- OLD function handle(r) local host = r.headers_in(host) r:puts(host) end to -- NEW function handle(r) local host = r.headers_in['host']