Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

On Fri, Oct 12, 2018 at 4:54 PM William A Rowe Jr wrote: > Great, I'll proceed with changing ab.c to remove the hack, since it is > unneeded when ab.c is compiled by the same toolchain as libcrypto.dll, > isn't available in non-openssl distributions, and was deprecated in 1.1.1 > again. > Note,

Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

On Sat, 13 Oct 2018 at 23:37, William A Rowe Jr wrote: > > On Sat, Oct 13, 2018 at 2:06 PM Ivan Zhakov wrote: >> >> On Sat, 13 Oct 2018 at 20:00, Gregg Smith wrote: >>> >>> On 10/13/2018 8:32 AM, William A Rowe Jr wrote: >>> > Sorry, I don't understand. >>> > >>> > Gregg, can you shed some

Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

No, sorry I am still confused on just which we're talking about here, support/main.c or ab.c (which I was thinking) or both? Looking over this thread on and off list seems to be a merge of both. So because of that; -1 to adding to applink to support/main.c. httpd.exe isn't even linked to

Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

On Sat, Oct 13, 2018 at 1:22 PM William A Rowe Jr wrote: > On Sat, Oct 13, 2018 at 12:00 PM Gregg Smith wrote: > >> On 10/13/2018 8:32 AM, William A Rowe Jr wrote: >> > Otherwise, I understand this to be a noop. >> > >> No, it just got moved to the ms folder is all that happened at 1.1.0 and >>

Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

On Sat, Oct 13, 2018 at 2:06 PM Ivan Zhakov wrote: > On Sat, 13 Oct 2018 at 20:00, Gregg Smith wrote: > >> On 10/13/2018 8:32 AM, William A Rowe Jr wrote: >> > Sorry, I don't understand. >> > >> > Gregg, can you shed some insight here? For both, applink.c is helpful if >> > the OpenSSL .dll

Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

On Sat, 13 Oct 2018 at 20:00, Gregg Smith wrote: > On 10/13/2018 8:32 AM, William A Rowe Jr wrote: > > Sorry, I don't understand. > > > > Gregg, can you shed some insight here? For both, applink.c is helpful if > > the OpenSSL .dll files are created with a different VC compiler than > > abs.exe

Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

On Sat, Oct 13, 2018 at 12:00 PM Gregg Smith wrote: > On 10/13/2018 8:32 AM, William A Rowe Jr wrote: > > Sorry, I don't understand. > > > > Gregg, can you shed some insight here? For both, applink.c is helpful if > > the OpenSSL .dll files are created with a different VC compiler than > >

Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

On 10/13/2018 8:32 AM, William A Rowe Jr wrote: Sorry, I don't understand. Gregg, can you shed some insight here? For both, applink.c is helpful if the OpenSSL .dll files are created with a different VC compiler than abs.exe was compiled with. Not true, OSSL 1.0.2 I know from experience if

Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

Sorry, I don't understand. Gregg, can you shed some insight here? For both, applink.c is helpful if the OpenSSL .dll files are created with a different VC compiler than abs.exe was compiled with. And it is only effective if compiled into the .exe, it cannot be found from a .dll or Apache .so

Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

Great, I'll proceed with changing ab.c to remove the hack, since it is unneeded when ab.c is compiled by the same toolchain as libcrypto.dll, isn't available in non-openssl distributions, and was deprecated in 1.1.1 again. Anyone interested can proceed to patch both and provision applink.c when

Re: Fwd: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

... and still hanging. Rather than ApacheLounge and some others needing to patch each time, did we conclude that we should wire in the applink.c stub into Apache.exe as shipped by httpd project? (I've never mixed binaries of different MSVC environments, so myself, I don't care, but it seems to

Re: Fwd: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

So we kind of left this hanging... On Wed, Jun 15, 2016 at 2:35 PM Gregg Smith wrote: > On 6/15/2016 9:20 AM, William A Rowe Jr wrote: > > In building httpd.exe, some users don't build and install openssl. It > isn't > > going > > to be possible to simply #include without some > > conditional

Re: Fwd: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

Good point. On Jun 15, 2016 2:35 PM, "Gregg Smith" wrote: > On 6/15/2016 9:20 AM, William A Rowe Jr wrote: > >> In building httpd.exe, some users don't build and install openssl. It >> isn't >> going >> to be possible to simply #include without some >> conditional >> test.

Re: Fwd: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

On 6/15/2016 9:20 AM, William A Rowe Jr wrote: In building httpd.exe, some users don't build and install openssl. It isn't going to be possible to simply #include without some conditional test. OpenSSL itself is partly the culprit, for not having an APPLINK_REQUIRED style macro conditional. But

Fwd: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c To: dev@httpd.apache.org I do not understand your conclusion. Background you find : https://www.openssl.org/docs/faq.html#PROG2 Also Apachelounge includes applink shim in http.exe with all (VC10/11/14), this is done in coope

Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

On 6/14/2016 6:33 PM, William A Rowe Jr wrote: Gregg, if you would vet the patch as applied to trunk/2.4/2.2, I'd appreciate it. On Jun 14, 2016 3:37 PM, wrote: I built 2.4 and 2.2 in VC14 and tested with VC11 Openssl dlls. Being down a machine (with all VC runtimes from 9-14

Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

Re: svn commit: r1748461 - in /httpd/httpd/branches/2.2.x: ./ CHANGES support/ab.c

Two quick observations... Every time OpenSSL was compiled against a different CRT, whether is was a release build of OpenSSL and a debug build of httpd/ab, or whether OpenSSL was built under Visual Studio 2012 and httpd/ab was built against VS 2015, this issue would occur without this patch.