On Thu, Jan 20, 2022 at 10:33 AM Yann Ylavic wrote:
>
> On Thu, Jan 20, 2022 at 3:53 PM William A Rowe Jr wrote:
> >
> > pcre1 is very dangerous, on stack. pcre2 is highly cautioned against
> > using stack for
> > its arrays, by its author. We should heed the advice.
> Not sure if I can do that
On 19 Jan 2022, at 09:40, Ruediger Pluem wrote:
>> @@ -723,6 +737,57 @@ static int dav_get_overwrite(request_rec
>> return -1;
>> }
>>
>> +static int uripath_is_canonical(const char *uripath)
>
> Isn't this a filesystem path we are talking about in the case?
> How does this function work
As seen in https://bz.apache.org/bugzilla/show_bug.cgi?id=65626 we have done
optimizations in mpm_event during the last year. It is normal that we risk
running into problems with changes in such complicated areas. But it seems
difficult to stabilize the code here.
I think it would be nice to
On 1/20/22 12:09 PM, yla...@apache.org wrote:
> Author: ylavic
> Date: Thu Jan 20 11:09:34 2022
> New Revision: 1897240
>
> URL: http://svn.apache.org/viewvc?rev=1897240=rev
> Log:
> ap_regex: Use Thread Local Storage (if efficient) to avoid allocations.
>
> PCRE2 wants an opaque context by
On Thu, Jan 20, 2022 at 1:53 PM Ruediger Pluem wrote:
>
> On 1/20/22 12:09 PM, yla...@apache.org wrote:
> >
> > #include "httpd.h"
> > +#include "apr_version.h"
>
> Why is this needed?
It's not (anymore), I tested for APR_VERSION_AT_LEAST(1,8,0) previously.
>
> > +#include "apr_portable.h"
>
>
On 1/20/22 2:24 PM, Yann Ylavic wrote:
>
> All good points, thanks Rüdiger, should be fixed in r1897250.
Great. I guess next we need to think what we do for 2.4.x.
Even when 1.8.x is released, we cannot demand it for 2.4.x (for trunk we could).
I guess we have two general choices:
1. We
On Thu, Jan 20, 2022 at 5:09 AM wrote:
>
> Author: ylavic
> Date: Thu Jan 20 11:09:34 2022
> New Revision: 1897240
>
> URL: http://svn.apache.org/viewvc?rev=1897240=rev
> Log:
> ap_regex: Use Thread Local Storage (if efficient) to avoid allocations.
>
> PCRE2 wants an opaque context by providing
On Thu, Jan 20, 2022 at 2:41 PM Ruediger Pluem wrote:
>
> On 1/20/22 2:24 PM, Yann Ylavic wrote:
>
> >
> > All good points, thanks Rüdiger, should be fixed in r1897250.
>
> Great. I guess next we need to think what we do for 2.4.x.
> Even when 1.8.x is released, we cannot demand it for 2.4.x
On Thu, Jan 20, 2022 at 3:53 PM William A Rowe Jr wrote:
>
> pcre1 is very dangerous, on stack. pcre2 is highly cautioned against
> using stack for
> its arrays, by its author. We should heed the advice.
My iterative changes make it possible to use PCRE1 on heap (at least
for the vector we pass
