Geoffrey Young wrote:
hi all...
in TestMM.pm we have this:
test_clean :
...
run_tests : test_clean
...
test :: pure_all run_tests test_clean
in a test suite with *lots* of files, test_clean takes forever. however, I
experience has shown me that test_clean is only really required when
Are you sure that there will be no side effects?
I'm pretty sure. it's not like test_clean won't be called under normal
'make test' circumstances, it's just that now there would be a way around it
if the user thinks it is beneficial.
If yes, then +1
ok, cool. if things blow up then I'll
[EMAIL PROTECTED] wrote:
geoff 2004/09/15 16:55:31
Modified:perl-framework/Apache-Test Changes
perl-framework/Apache-Test/lib/Apache TestMM.pm
Log:
run_tests make target no longer invokes t/TEST -clean, making it
possible to save a few development cycles
Geoffrey Young wrote:
Are you sure that there will be no side effects?
I'm pretty sure. it's not like test_clean won't be called under normal
'make test' circumstances, it's just that now there would be a way around it
if the user thinks it is beneficial.
Oh, now I remember where it was used.
httpd-test/perl-framework STATUS: -*-text-*-
Last modified at [$Date: 2002/03/09 05:22:48 $]
Stuff to do:
* finish the t/TEST exit code issue (ORed with 0x2C if
framework failed)
* change existing tests that frob the DocumentRoot (e.g.,
flood STATUS: -*-text-*-
Last modified at [$Date: 2003/07/01 20:55:12 $]
Release:
1.0: Released July 23, 2002
milestone-03: Tagged January 16, 2002
ASF-transfer: Released July 17, 2001
milestone-02: Tagged August 13,
I had been investigating into ways to make test runs run faster, and I found
that
one of the biggest bottlenecks on my test machine was useless repetitive calls
to apxs. The following patch caches apxs queries.
For instance, timings for mod_perl test run:
+ Before:
Files=218, Tests=2512, 1032
Philippe M. Chiasson wrote:
I had been investigating into ways to make test runs run faster, and I
found that
one of the biggest bottlenecks on my test machine was useless repetitive
calls
to apxs. The following patch caches apxs queries.
For instance, timings for mod_perl test run:
+ Before:
looks good.
Bill Stoddard wrote:
static int remove_url(const char *key)
[...]
-if (obj) {
-obj-cleanup = 1;
+if (!apr_atomic_dec(obj-refcount)) {
+/* For performance, cleanup cache object after releasing the lock */
+cleanup = 1;
this could be:
Bill Stoddard wrote:
+ * memcacache_cache_free is a callback that is only invoked during by a
thread
s/memcacache/memcache/
during ?? by
+ * has been ejected from the cache. decrement the refcount and if the
refcount drop
+ * to 0, cleanup the cache object.
s/drop/drops/
Greg
Bill Stoddard wrote:
-/* If obj-complete is not set, the cache update failed and the
- * object needs to be removed from the cache then cleaned up.
- */
-if (!obj-complete) {
-if (sconf-lock) {
-apr_thread_mutex_lock(sconf-lock);
-}
-/* Remember,
Are there any reasons why that part of decrement_refcount() is not
needed anymore?
@@ -267,31 +271,9 @@ { cache_object_t *obj = (cache_object_t *) arg;- /* If obj-complete is not set, the cache update failed and the- * object needs to be removed from the cache then cleaned up.- */- if
On Wed, Aug 25, 2004 at 02:40:39PM +0200, Graham Leggett wrote:
Justin Erenkrantz wrote:
Ultimately, all that is needed is a call to ap_set_content_type() before
any bytes are written to the client to get AddOutputFilterByType to
work. Perhaps with the recent momentum behind mod_proxy work,
mccreedy 2004/09/15
16:45:18
src/modules/proxy mod_proxy.h Index:
mod_proxy.h
===
RCS file:
/home/cvs/apache-1.3/src/modules/proxy/mod_proxy.h,v
retrieving revision 1.62 retrieving revision
1.63 diff -u -r1.62 -r1.63 ---
Oups!, sorry I was few minutes slower than you Greg.
The overall patch looks good and much cleaner.
I would love to move my office next to both of you...
I will put the new code on my mp box and make sure
It does not break.
Thanks,
JJ [EMAIL PROTECTED] 09/16/04 9:50 AM
Bill Stoddard wrote: -
In most of the Apache 2.0.XX releases, we have been using a CVS snapshot
of APR and APR-Util.
I would like to make it an official policy that for the 2.2 cycle, we
will never use a CVS snapshot of APR.
I believe we should still bundle APR and APR-Util with HTTPd, but we
should only use the
[EMAIL PROTECTED] 09/16/04 9:50 AM
Bill Stoddard wrote:
-/* If obj-complete is not set, the cache update failed and the
- * object needs to be removed from the cache then cleaned up.
- */
-if (!obj-complete) {
-if (sconf-lock) {
-
On Thu, 16 Sep 2004, Paul Querna wrote:
In most of the Apache 2.0.XX releases, we have been using a CVS snapshot
of APR and APR-Util.
I would like to make it an official policy that for the 2.2 cycle, we
will never use a CVS snapshot of APR.
That makes httpd releases (relatively frequent)
Nick Kew wrote:
On Thu, 16 Sep 2004, Paul Querna wrote:
In most of the Apache 2.0.XX releases, we have been using a CVS snapshot
of APR and APR-Util.
I would like to make it an official policy that for the 2.2 cycle, we
will never use a CVS snapshot of APR.
That makes httpd releases (relatively
On Thu, 2004-09-16 at 18:13 +0100, Nick Kew wrote:
On Thu, 16 Sep 2004, Paul Querna wrote:
In most of the Apache 2.0.XX releases, we have been using a CVS snapshot
of APR and APR-Util.
I would like to make it an official policy that for the 2.2 cycle, we
will never use a CVS snapshot
Adds back obj-complete check in decrement_refcount. Makes changes recommended by Greg.
Index: mod_mem_cache.c
===
RCS file: /home/cvs/httpd-2.0/modules/experimental/mod_mem_cache.c,v
retrieving revision 1.88.2.9
diff -u -r1.88.2.9
Paul Querna wrote:
In most of the Apache 2.0.XX releases, we have been using a CVS snapshot
of APR and APR-Util.
I would like to make it an official policy that for the 2.2 cycle, we
will never use a CVS snapshot of APR.
+1.
I believe we should still bundle APR and APR-Util with HTTPd, but we
Jean-Jacques Clar wrote:
To remove the 2 noted possible race situations, in addition to another
possible
one in store_body(),
ooops! I missed that one
we could add the following 2 recursive functions,
that have to be called under the protection of the lock (it is now for
On Thu, Sep 16, 2004 at 07:41:00PM +0200, Graham Leggett wrote:
Paul Querna wrote:
I believe we should still bundle APR and APR-Util with HTTPd, but we
should only use the released versions of each.
This will keep it easy for end users, because APR will still be bundled
in our Source
+1
Tried differentconfigurations in lab and changes are acting as expected.
Thanks to Greg and Bill S. for fixing the problem.
JJ [EMAIL PROTECTED] 09/16/04 11:39 AM
Adds back obj-complete check in decrement_refcount. Makes changes recommended by Greg.
Joe Orton wrote:
+1 to shipping the sources in the tarball. In principle I like the idea
of only shipping apr from a release tag, but it adds a significant
burden if there needs to be an httpd security release for an apr issue.
I think we need to demonstrate that we can ship APR releases more
The Original Proposal was in March of this year:
http://marc.theaimsgroup.com/?t=10791831443r=2w=2
+1 Votes:
Tom May
Justin Erenkrantz
Andr Malo
Erik Abele
Jim Jagielski
Bill Stoddard
Joe Orton
-1 Votes:
Aaron Bannert
Aaron said:
This will, at least for now, raise the bar
From: Paul Querna [EMAIL PROTECTED]
Sent: Friday, September 17, 2004 7:34 AM
Hi,
The Original Proposal was in March of this year:
http://marc.theaimsgroup.com/?t=10791831443r=2w=2
+1 Votes:
Tom May
Justin Erenkrantz
Andr Malo
Erik Abele
Jim Jagielski
Bill Stoddard
28 matches
Mail list logo