Re: svn commit: r1856493 - in /httpd/httpd/trunk: CHANGES modules/cache/cache_storage.c modules/cache/cache_util.c modules/cache/cache_util.h

2019-03-28 Thread Yann Ylavic
On Thu, Mar 28, 2019 at 11:40 PM Yann Ylavic wrote: > > On Thu, Mar 28, 2019 at 10:30 PM Ruediger Pluem wrote: > > > > > > > > On 03/28/2019 10:27 PM, Yann Ylavic wrote: > > > On Thu, Mar 28, 2019 at 10:24 PM Ruediger Pluem wrote: > > >> > > >> On 03/28/2019 05:39 PM, yla...@apache.org wrote: >

Re: svn commit: r1856493 - in /httpd/httpd/trunk: CHANGES modules/cache/cache_storage.c modules/cache/cache_util.c modules/cache/cache_util.h

2019-03-28 Thread Yann Ylavic
On Thu, Mar 28, 2019 at 10:30 PM Ruediger Pluem wrote: > > > > On 03/28/2019 10:27 PM, Yann Ylavic wrote: > > On Thu, Mar 28, 2019 at 10:24 PM Ruediger Pluem wrote: > >> > >> On 03/28/2019 05:39 PM, yla...@apache.org wrote: > >>> > >>> +for (wpos = str; *str; ++str) { > >>> if

Re: svn commit: r1856493 - in /httpd/httpd/trunk: CHANGES modules/cache/cache_storage.c modules/cache/cache_util.c modules/cache/cache_util.h

2019-03-28 Thread Ruediger Pluem
On 03/28/2019 10:27 PM, Yann Ylavic wrote: > On Thu, Mar 28, 2019 at 10:24 PM Ruediger Pluem wrote: >> >> On 03/28/2019 05:39 PM, yla...@apache.org wrote: >>> >>> +for (wpos = str; *str; ++str) { >>> if (!quoted) { >>> -if (**last == '\"' && !ap_strchr_c(sep, '\"')) {

Re: svn commit: r1856493 - in /httpd/httpd/trunk: CHANGES modules/cache/cache_storage.c modules/cache/cache_util.c modules/cache/cache_util.h

2019-03-28 Thread Yann Ylavic
On Thu, Mar 28, 2019 at 10:24 PM Ruediger Pluem wrote: > > On 03/28/2019 05:39 PM, yla...@apache.org wrote: > > > > +for (wpos = str; *str; ++str) { > > if (!quoted) { > > -if (**last == '\"' && !ap_strchr_c(sep, '\"')) { > > +if (*str == '"') { > > Question:

Re: svn commit: r1856493 - in /httpd/httpd/trunk: CHANGES modules/cache/cache_storage.c modules/cache/cache_util.c modules/cache/cache_util.h

2019-03-28 Thread Ruediger Pluem
On 03/28/2019 10:24 PM, Ruediger Pluem wrote: > > > On 03/28/2019 05:39 PM, yla...@apache.org wrote: >> Author: ylavic >> Date: Thu Mar 28 16:39:39 2019 >> New Revision: 1856493 >> >> URL: http://svn.apache.org/viewvc?rev=1856493=rev >> Log: >> mod_cache: Fix parsing of quoted Cache-Control

Re: svn commit: r1856493 - in /httpd/httpd/trunk: CHANGES modules/cache/cache_storage.c modules/cache/cache_util.c modules/cache/cache_util.h

2019-03-28 Thread Ruediger Pluem
On 03/28/2019 05:39 PM, yla...@apache.org wrote: > Author: ylavic > Date: Thu Mar 28 16:39:39 2019 > New Revision: 1856493 > > URL: http://svn.apache.org/viewvc?rev=1856493=rev > Log: > mod_cache: Fix parsing of quoted Cache-Control token arguments. PR 63288. > > Make cache_strqtok() return

Re: [VOTE] Release httpd-2.4.39

2019-03-28 Thread Dennis Clarke
On 3/28/19 11:48 AM, Yann Ylavic wrote: > On Wed, Mar 27, 2019 at 4:10 PM Daniel Ruggeri wrote: >> >> I would like to call a VOTE over the next few days to release this >> candidate tarball as 2.4.39: > > [X] +1: It's not just good, it's good enough! > > All tests pass on Debian(s) 8, 9 and 10

Re: [VOTE] Release httpd-2.4.39

2019-03-28 Thread Yann Ylavic
On Wed, Mar 27, 2019 at 4:10 PM Daniel Ruggeri wrote: > > I would like to call a VOTE over the next few days to release this > candidate tarball as 2.4.39: [X] +1: It's not just good, it's good enough! All tests pass on Debian(s) 8, 9 and 10 w/ openssl(s) 1.0.2, 1.1.0 and 1.1.1. Sigs and

Re: [VOTE] Release httpd-2.4.39

2019-03-28 Thread Jim Jagielski
My own.. Cheers! > On Mar 28, 2019, at 10:00 AM, Plüm, Rüdiger, Vodafone Group > wrote: > > What pcre lib did you use on CentOS5? The one provided by CentOS or your own? > > Regards > > Rüdiger > > > C2 General > Von: Jim Jagielski > Gesendet: Donnerstag, 28. März 2019 14:52 > An:

AW: [VOTE] Release httpd-2.4.39

2019-03-28 Thread Plüm , Rüdiger , Vodafone Group
What pcre lib did you use on CentOS5? The one provided by CentOS or your own? Regards Rüdiger C2 General Von: Jim Jagielski Gesendet: Donnerstag, 28. März 2019 14:52 An: httpd Betreff: Re: [VOTE] Release httpd-2.4.39 Yep, CentOS5. Mostly due to the fact that regressions would likely show

Re: [VOTE] Release httpd-2.4.39

2019-03-28 Thread Jim Jagielski
Yep, CentOS5. Mostly due to the fact that regressions would likely show up more readily on older OSs rather than newer ones. Plus, there's still a crap-ton of systems using CentOS5/RHEL5 > On Mar 28, 2019, at 8:51 AM, Plüm, Rüdiger, Vodafone Group > wrote: > > > > > C2 General > >>

AW: AW: [VOTE] Release httpd-2.4.39

2019-03-28 Thread Plüm , Rüdiger , Vodafone Group
C2 General > -Ursprüngliche Nachricht- > Von: Dennis Clarke > Gesendet: Donnerstag, 28. März 2019 14:23 > An: dev@httpd.apache.org > Betreff: Re: AW: [VOTE] Release httpd-2.4.39 > > On 3/28/19 8:51 AM, Plüm, Rüdiger, Vodafone Group wrote: > > > > > > > >> > >> Tested and passed on

Re: AW: [VOTE] Release httpd-2.4.39

2019-03-28 Thread Dennis Clarke
On 3/28/19 8:51 AM, Plüm, Rüdiger, Vodafone Group wrote: > > > >> >> Tested and passed on the following systems (no regressions): >> >> o macOS 10.14.4, Xcode 10.2 >> o CentOS 5, 64bit > > Really CentOS 5? Just asking because it does not receive further OS updates > and I wouldn't

AW: [VOTE] Release httpd-2.4.39

2019-03-28 Thread Plüm , Rüdiger , Vodafone Group
C2 General > -Ursprüngliche Nachricht- > Von: Jim Jagielski > Gesendet: Donnerstag, 28. März 2019 13:39 > An: httpd > Betreff: Re: [VOTE] Release httpd-2.4.39 > > > > On Mar 27, 2019, at 11:09 AM, Daniel Ruggeri > wrote: > > > > Hi, all; > > Please find below the proposed

Re: [VOTE] Release httpd-2.4.39

2019-03-28 Thread Jim Jagielski
> On Mar 27, 2019, at 11:09 AM, Daniel Ruggeri wrote: > > Hi, all; > Please find below the proposed release tarball and signatures: > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release this candidate > tarball as 2.4.39: > [ ]

Re: [VOTE] Release httpd-2.4.39

2019-03-28 Thread Stefan Eissing
> Am 27.03.2019 um 16:09 schrieb Daniel Ruggeri : > > Hi, all; > Please find below the proposed release tarball and signatures: > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release this candidate > tarball as 2.4.39: > [ ] +1: