Re: Comment system, take two and a half

2012-05-30 Thread Daniel Ruggeri
On 5/29/2012 9:35 AM, Rich Bowen wrote: In my view of this, comments should *not* be considered a permanent part of the document. Either they get incorporated into the document itself, or they get flushed. I really don't want to see comments sticking around forever on a doc. I consider them to

Re: Comment system, take two and a half

2012-05-29 Thread Daniel Gruno
On 05/28/2012 09:38 PM, Gregg Smith wrote: Each branch different, 2.2 2.4 have some big differences between them in various areas. My 2 cents anyway. What I'm perhaps more curious to get sorted out is whether we should consider the trunk and the 2.4 documentation separate entities, or whether

Re: Comment system, take two and a half

2012-05-29 Thread Graham Leggett
On 29 May 2012, at 8:50 AM, Daniel Gruno wrote: Each branch different, 2.2 2.4 have some big differences between them in various areas. My 2 cents anyway. What I'm perhaps more curious to get sorted out is whether we should consider the trunk and the 2.4 documentation separate entities, or

Re: Comment system, take two and a half

2012-05-29 Thread Rich Bowen
On May 29, 2012, at 5:04 AM, Graham Leggett wrote: On 29 May 2012, at 8:50 AM, Daniel Gruno wrote: Each branch different, 2.2 2.4 have some big differences between them in various areas. My 2 cents anyway. What I'm perhaps more curious to get sorted out is whether we should consider the

Re: Comment system, take two and a half

2012-05-28 Thread Gregg Smith
On 5/27/2012 3:20 PM, Daniel Gruno wrote: We could insist that all comments be made in English unless they are related to a specific translations, and as long as we keep the translations up to date with the suggestions and delete comments as they are implemented, there shouldn't be much clutter.

Re: Comment system, take two and a half

2012-05-27 Thread Daniel Gruno
Most of the kinks in the new comment system have now been sorted, as has most of the question on the actual implementation of it. However, a few questions remain, that I'd like some input on if possible: - Should we keep the various translations separate, or should it be one unified commentary?

Re: Comment system, take two

2012-05-23 Thread Tony Stevenson
Daniel Gruno wrote on Wed, May 23, 2012 at 04:47:10AM +0200: On 05/22/2012 11:25 PM, Rainer Jung wrote: I like it. +1 Concerning production readyness, some points come to mind: - Did you pay attention on escaping problematic input? I saw some escaping, but didn't thoroughly test

Re: Comment system, take two

2012-05-23 Thread Daniel Gruno
On 05/23/2012 09:15 AM, Tony Stevenson wrote: I said running php on the main webservers would very likely with a no, I didnt say it would do that. If the service doesnt have to run on the same vhost as the main httpd.a.o site then we could run the service elsewhere in our infrastructure. Sorry,

Re: Comment system, take two

2012-05-22 Thread Rich Bowen
On 2012 5 21 17:04, Daniel Gruno rum...@cord.dk wrote: In light of recent concerns about the Disqus system, I've taken it upon myself to figure out an alternative we can use for adding comments to our pages. And so, through the better half of a day, I worked on creating a new system that is

Re: Comment system, take two

2012-05-22 Thread Rainer Jung
On 21.05.2012 23:04, Daniel Gruno wrote: In light of recent concerns about the Disqus system, I've taken it upon myself to figure out an alternative we can use for adding comments to our pages. And so, through the better half of a day, I worked on creating a new system that is without any evil

Re: Comment system, take two

2012-05-22 Thread Daniel Gruno
On 05/22/2012 11:25 PM, Rainer Jung wrote: I like it. +1 Concerning production readyness, some points come to mind: - Did you pay attention on escaping problematic input? I saw some escaping, but didn't thoroughly test it. We don't want XSS and such. Yes, because the text is inserted using

Comment system, take two

2012-05-21 Thread Daniel Gruno
In light of recent concerns about the Disqus system, I've taken it upon myself to figure out an alternative we can use for adding comments to our pages. And so, through the better half of a day, I worked on creating a new system that is without any evil tracking mechanisms of any sort except for