Re: proposed backport of mod_h2 - v4

Works for me... btw: for things like the below, I actually use git-svn, which, at least to me, provides a workflow which I find easier. > On Sep 8, 2015, at 6:10 AM, Stefan Eissing > wrote: > > >> Am 08.09.2015 um 03:56 schrieb William A Rowe Jr

Re: proposed backport of mod_h2 - v4

> Am 08.09.2015 um 03:56 schrieb William A Rowe Jr : > > On Sep 7, 2015 1:14 PM, "Stefan Eissing" wrote: > > > > Thanks, new branch to bring in protocols and mod_h2 is at > > > > > >

Re: proposed backport of mod_h2 - v4

I did not dare to mention the three letter g* word here... ;-) > Am 08.09.2015 um 13:15 schrieb Jim Jagielski : > > Works for me... > > btw: for things like the below, I actually use git-svn, which, at > least to me, provides a workflow which I find easier. > >> On Sep 8,

Re: proposed backport of mod_h2 - v4

Thanks, new branch to bring in protocols and mod_h2 is at https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.17-protocols-http2 One may get a diff and the list of merged changes with svn diff ^/httpd/httpd/branches/2.4.x ^/httpd/httpd/branches/2.4.17-protocols-http2 Any future

Re: proposed backport of mod_h2 - v4

On Sep 7, 2015 1:14 PM, "Stefan Eissing" wrote: > > Thanks, new branch to bring in protocols and mod_h2 is at > > https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.17-protocols-http2 I am fine with either approach. . not a critique, I think the simplest is

Re: proposed backport of mod_h2 - v4

In core-h2-all-in-one-v4.patch line 8586 +if (!offers || ap_array_contains(offers, *protos)) { the old ap_array_contains is in use On 9/5/2015 12:21 AM, Stefan Eissing wrote: yes, it should. where do you not see it? (i wish we'd use branches instead of this patch file madness) Am

Re: proposed backport of mod_h2 - v4

yes, it should. where do you not see it? (i wish we'd use branches instead of this patch file madness) > Am 05.09.2015 um 06:12 schrieb Gregg Smith : > > Shouldn't this be ap_array_str_contains now in h2_switch.c? > > +while (*protos) { > +/* Add all protocols we

Re: proposed backport of mod_h2 - v4

On 05 Sep 2015, at 9:21 AM, Stefan Eissing wrote: > yes, it should. where do you not see it? > > (i wish we'd use branches instead of this patch file madness) A branch is possible, create one beneath here: http://svn.apache.org/repos/asf/httpd/httpd/branches/

Re: proposed backport of mod_h2 - v4

On Sat, Sep 5, 2015 at 3:21 AM, Stefan Eissing wrote: > (i wish we'd use branches instead of this patch file madness) I think a short-lived feature branch would be acceptable. I'm personally a pretty primitive svn user.

Re: proposed backport of mod_h2 - v4

Shouldn't this be ap_array_str_contains now in h2_switch.c? +while (*protos) { +/* Add all protocols we know (tls or clear) and that + * are part of the offerings (if there have been any). + */ -->+if (!offers || ap_array_contains(offers, *protos)) { +

Re: proposed backport of mod_h2

Hi Stefan, core patch: needs r1694950 and may require a minor mmn bump, at least that is what I took away from the discussion about it over this commit. h2 patch: needs r1700917 Thanks, Gregg On 9/2/2015 7:10 AM, Stefan Eissing wrote: As in r1700829. Regression tests run (after small

proposed backport of mod_h2

As in r1700829. Regression tests run (after small change on apache version check in h2.t) on OS X for me. Cheers, Stefan bytes GmbH Hafenweg 16, 48155 Münster, Germany Phone: +49 251 2807760. Amtsgericht Münster: HRB5782