Re: svn commit: r1828890 - in /httpd/httpd/trunk: ./ docs/log-message-tags/ docs/manual/howto/ docs/manual/mod/ modules/proxy/ modules/proxy/balancers/

On 04/11/2018 02:11 PM, jhri...@apache.org wrote: > Author: jhriggs > Date: Wed Apr 11 12:11:05 2018 > New Revision: 1828890 > > URL: http://svn.apache.org/viewvc?rev=1828890=rev > Log: > mod_proxy_balancer: Add hot spare member type and corresponding flag (R). Hot > spare members are > used

Re: svn commit: r1828890 - in /httpd/httpd/trunk: ./ docs/log-message-tags/ docs/manual/howto/ docs/manual/mod/ modules/proxy/ modules/proxy/balancers/

On 04/11/2018 04:23 PM, Jim Jagielski wrote: > +1 on keeping the patch as is and not breaking it out as a "refactor" plus > a new feature. Definitely for this case. OTOH if practically possible I like to see stuff in separate commits to ease reviewing and later error diagnosis. But as said

Re: Future of hot standby in balancers [was Re: svn commit: r1828890 - in /httpd/httpd/trunk: ./ docs/log-message-tags/ docs/manual/howto/ docs/manual/mod/ modules/proxy/ modules/proxy/balancers/]

It's been awhile but I think hot standbys were added before we came up with the idea of lb sets... And since people were using hot standbys, we didn't want to force them to change their configs. We can drop hot-standbys in trunk/2.5/2.6, but we'll need to keep them in 2.4. > On Apr 11, 2018, at

Re: svn commit: r1828890 - in /httpd/httpd/trunk: ./ docs/log-message-tags/ docs/manual/howto/ docs/manual/mod/ modules/proxy/ modules/proxy/balancers/

I did not advocate refactor for refactoring sake, was just a remark about (possibly) staging "big" changes. Here for instance ap_proxy_balancer_get_best_worker() refactor could have been done on the existing code first, and then the code needed for hot spare members be added to that common

Future of hot standby in balancers [was Re: svn commit: r1828890 - in /httpd/httpd/trunk: ./ docs/log-message-tags/ docs/manual/howto/ docs/manual/mod/ modules/proxy/ modules/proxy/balancers/]

On 11 Apr 2018, at 07:11, jhri...@apache.org wrote: > > Author: jhriggs > Date: Wed Apr 11 12:11:05 2018 > New Revision: 1828890 > > URL: http://svn.apache.org/viewvc?rev=1828890=rev > Log: > mod_proxy_balancer: Add hot spare member type and corresponding flag (R). Hot > spare members are >

Re: svn commit: r1828890 - in /httpd/httpd/trunk: ./ docs/log-message-tags/ docs/manual/howto/ docs/manual/mod/ modules/proxy/ modules/proxy/balancers/

+1 on keeping the patch as is and not breaking it out as a "refactor" plus a new feature. We have seen WAY too many cases where a refactor has caused issues. I'm not saying we shouldn't fix things, but major refactors should, IMO, have a real-world need, and tangible improvement, other than "I

Re: svn commit: r1828890 - in /httpd/httpd/trunk: ./ docs/log-message-tags/ docs/manual/howto/ docs/manual/mod/ modules/proxy/ modules/proxy/balancers/

> On 11 Apr 2018, at 08:28, Yann Ylavic wrote: > > On Wed, Apr 11, 2018 at 2:11 PM, wrote: >> Author: jhriggs >> Date: Wed Apr 11 12:11:05 2018 >> New Revision: 1828890 >> >> URL: http://svn.apache.org/viewvc?rev=1828890=rev >> Log: >>

Re: svn commit: r1828890 - in /httpd/httpd/trunk: ./ docs/log-message-tags/ docs/manual/howto/ docs/manual/mod/ modules/proxy/ modules/proxy/balancers/

On Wed, Apr 11, 2018 at 2:11 PM, wrote: > Author: jhriggs > Date: Wed Apr 11 12:11:05 2018 > New Revision: 1828890 > > URL: http://svn.apache.org/viewvc?rev=1828890=rev > Log: > mod_proxy_balancer: Add hot spare member type and corresponding flag (R). Hot > spare members are