Re: svn commit: r1916243 - /httpd/httpd/trunk/server/mpm/event/event.c

2024-03-12 Thread Yann Ylavic
On Tue, Mar 12, 2024 at 4:08 PM Eric Covener wrote: > > below + POD wakeup > > Did not force the path yet where the listener is started (or fold in > the scoreboard change ) +1, maybe ap_queue_term() rather than ap_queue_interrupt_all().

Re: svn commit: r1916243 - /httpd/httpd/trunk/server/mpm/event/event.c

2024-03-12 Thread Eric Covener
I should add, this against a very divergent $bigco fork so patch may not work well. On Tue, Mar 12, 2024 at 11:07 AM Eric Covener wrote: > > below + POD wakeup > > Did not force the path yet where the listener is started (or fold in > the scoreboard change ) > > On Tue, Mar 12, 2024 at 10:54 AM

Re: svn commit: r1916243 - /httpd/httpd/trunk/server/mpm/event/event.c

2024-03-12 Thread Eric Covener
below + POD wakeup Did not force the path yet where the listener is started (or fold in the scoreboard change ) On Tue, Mar 12, 2024 at 10:54 AM Eric Covener wrote: > > On Tue, Mar 12, 2024 at 10:30 AM Eric Covener wrote: > > > > On Tue, Mar 12, 2024 at 10:19 AM Yann Ylavic wrote: > > > > > >

Re: svn commit: r1916243 - /httpd/httpd/trunk/server/mpm/event/event.c

2024-03-12 Thread Eric Covener
On Tue, Mar 12, 2024 at 10:30 AM Eric Covener wrote: > > On Tue, Mar 12, 2024 at 10:19 AM Yann Ylavic wrote: > > > > On Tue, Mar 12, 2024 at 3:03 PM Eric Covener wrote: > > > > > > On Tue, Mar 12, 2024 at 8:48 AM Yann Ylavic wrote: > > > > > > > > Maybe it could be: > > > > if

Re: svn commit: r1916243 - /httpd/httpd/trunk/server/mpm/event/event.c

2024-03-12 Thread Yann Ylavic
On Tue, Mar 12, 2024 at 3:30 PM Eric Covener wrote: > > On Tue, Mar 12, 2024 at 10:19 AM Yann Ylavic wrote: > > > > On Tue, Mar 12, 2024 at 3:03 PM Eric Covener wrote: > > > > > > On Tue, Mar 12, 2024 at 8:48 AM Yann Ylavic wrote: > > > > > > > > Maybe it could be: > > > > if

Re: svn commit: r1916243 - /httpd/httpd/trunk/server/mpm/event/event.c

2024-03-12 Thread Eric Covener
On Tue, Mar 12, 2024 at 10:19 AM Yann Ylavic wrote: > > On Tue, Mar 12, 2024 at 3:03 PM Eric Covener wrote: > > > > On Tue, Mar 12, 2024 at 8:48 AM Yann Ylavic wrote: > > > > > > Maybe it could be: > > > if (threads_created) { > > > > not listener_started? > > > > threads_started>0 could

Re: svn commit: r1916243 - /httpd/httpd/trunk/server/mpm/event/event.c

2024-03-12 Thread Yann Ylavic
On Tue, Mar 12, 2024 at 3:03 PM Eric Covener wrote: > > On Tue, Mar 12, 2024 at 8:48 AM Yann Ylavic wrote: > > > > Maybe it could be: > > if (threads_created) { > > not listener_started? > > threads_started>0 could just mean we had no scoreboard issues but > pthread_create failed on

Re: svn commit: r1916243 - /httpd/httpd/trunk/server/mpm/event/event.c

2024-03-12 Thread Eric Covener
On Tue, Mar 12, 2024 at 8:48 AM Yann Ylavic wrote: > > On Tue, Mar 12, 2024 at 1:06 PM Eric Covener wrote: > > > > On Mon, Mar 11, 2024 at 8:28 PM wrote: > > > > > > Author: covener > > > Date: Tue Mar 12 00:28:34 2024 > > > New Revision: 1916243 > > > > > > URL:

Re: svn commit: r1916243 - /httpd/httpd/trunk/server/mpm/event/event.c

2024-03-12 Thread Yann Ylavic
On Tue, Mar 12, 2024 at 1:46 PM Yann Ylavic wrote: > > Maybe it could be: We should probably prevent the listener from starting too, like: > if (threads_created) { > resource_shortage = 1; > signal_threads(ST_GRACEFUL); listener_started = 1; /* don't start it if

Re: svn commit: r1916243 - /httpd/httpd/trunk/server/mpm/event/event.c

2024-03-12 Thread Yann Ylavic
On Tue, Mar 12, 2024 at 1:06 PM Eric Covener wrote: > > On Mon, Mar 11, 2024 at 8:28 PM wrote: > > > > Author: covener > > Date: Tue Mar 12 00:28:34 2024 > > New Revision: 1916243 > > > > URL: http://svn.apache.org/viewvc?rev=1916243=rev > > Log: > > use graceful exit if lister started > > > >

Re: svn commit: r1916243 - /httpd/httpd/trunk/server/mpm/event/event.c

2024-03-12 Thread Eric Covener
On Mon, Mar 11, 2024 at 8:28 PM wrote: > > Author: covener > Date: Tue Mar 12 00:28:34 2024 > New Revision: 1916243 > > URL: http://svn.apache.org/viewvc?rev=1916243=rev > Log: > use graceful exit if lister started > > Modified: > httpd/httpd/trunk/server/mpm/event/event.c > > Modified: