Re: using X-Forwarded-Host as r-hostname

2012-05-16 Thread Chris Darroch
Igor Galić wrote: One of the several things I'm uncertain about, though, is how to distinguish the case of just wanting to override, say, the Host header *after* the VirtualHost has been selected (perhaps this is the default case, to work like RemoteIPHeader), from the extra case of using

Re: using X-Forwarded-Host as r-hostname

2012-05-12 Thread Igor Galić
One of the several things I'm uncertain about, though, is how to distinguish the case of just wanting to override, say, the Host header *after* the VirtualHost has been selected (perhaps this is the default case, to work like RemoteIPHeader), from the extra case of using the inserted new

Re: using X-Forwarded-Host as r-hostname

2012-05-11 Thread William A. Rowe Jr.
On 5/3/2012 5:57 PM, Chris Darroch wrote: Hence this patch, which adds a UseCanonicalName XHost option in which X-Forwarded-Host is checked first, and if non-blank, is used in place of Host to determine the server name. (The Host header is left as-is, though.) That describes your use

Re: using X-Forwarded-Host as r-hostname

2012-05-11 Thread William A. Rowe Jr.
On 5/3/2012 6:14 PM, Igor Gali? wrote: - Chris Darroch chr...@pearsoncmg.com wrote: Hence this patch, which adds a UseCanonicalName XHost option in which X-Forwarded-Host is checked first, and if non-blank, is used in place of Host to determine the server name. (The Host header is left

Re: using X-Forwarded-Host as r-hostname

2012-05-11 Thread Chris Darroch
William A. Rowe Jr. wrote: On 5/3/2012 6:14 PM, Igor Gali? wrote: Wouldn't it be more appropriate to hack up^W^Wexpand mod_remoteip? That answer seems sensible to me, too. Thanks, guys, for pointing me at mod_remoteip; I agree it's a more logical place for this kind of thing. The

Re: using X-Forwarded-Host as r-hostname

2012-05-04 Thread Daniel Ruggeri
On 5/3/2012 5:57 PM, Chris Darroch wrote: I promise I won't be offended if anyone says it's a stupid hack and should never be committed, because, well, it is arguably a very stupid hack. Actually, I think one could make the argument that all of the headers set by mod_proxy should be just as

using X-Forwarded-Host as r-hostname

2012-05-03 Thread Chris Darroch
Hi -- It's been a remarkably long time since I had anything useful to commit, and I'm pretty rusty, so I thought I'd throw this out for discussion as a RTC despite the CTR rules on trunk. I promise I won't be offended if anyone says it's a stupid hack and should never be committed, because,

Re: using X-Forwarded-Host as r-hostname

2012-05-03 Thread Igor Gali?
- Chris Darroch chr...@pearsoncmg.com wrote: Hi -- It's been a remarkably long time since I had anything useful to commit, and I'm pretty rusty, so I thought I'd throw this out for discussion as a RTC despite the CTR rules on trunk. I promise I won't be offended if anyone says it's a