[jclouds-java-7-pull-requests
#835](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/835/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/198#issuecomment-27890211
My mistake in https://issues.apache.org/jira/browse/JCLOUDS-331 .
This fix looks good. Should also be backported to 1.6.x (along with
JCLOUDS-331).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/198#issuecomment-27898538
@@ -110,6 +112,41 @@ void testDescribe() {
}
@Test
+ void testFilter() {
[minor] `public void`, as for most tests?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/194/files#r7486520
Some repeated comments:
* use TestNG assertions only, at least in new test code (rather than Java
`assert`s)?
* plenty of cases where assertions in a test are surrounded by `if
(allResults.size() = 1) { ... }`. Are we legitimately expecting no responses
here? If so, at least throw a
You can merge this Pull Request by running:
git pull https://github.com/noorul/jclouds-chef readme
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-chef/pull/37
-- Commit Summary --
* Replace text api with API since it is an acronym.
-- File
Thanks Ignasi for the pointers!
On Wed, Nov 6, 2013 at 12:53 PM, Ignasi ignasi.barr...@gmail.com wrote:
You're right.
Our unit tests test the apis using mocks to aviod sending the requests over
the wire.
Live tests, though, perform real api calls and create real resources (vms,
blobs,
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/540/
[jclouds-labs-pull-requests
#80](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/80/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/32#issuecomment-27941871
