Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

2013-11-18 Thread Andrew Phillips
![image](https://f.cloud.github.com/assets/223702/1563624/c0f9e15c-5063-11e3-80a4-026b087f46d5.png) ![image](https://f.cloud.github.com/assets/223702/1563630/e20243e4-5063-11e3-80ee-059d10df61a1.png)

Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

2013-11-18 Thread ahgittin
thanks @demobox i can clean these up --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/202#issuecomment-28707165

Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

2013-11-15 Thread ahgittin
cool. done in #207. what command were you running when you got the whitespace warnings? happy to clean those up also. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/202#issuecomment-28556865

Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

2013-11-14 Thread ahgittin
@demobox I agree with your comments but as this is a backport of pull requests already merged in 1.7.0 is it better to handle them as a new issue? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/202#issuecomment-28514592

Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

2013-11-14 Thread ahgittin
+ imageNameAlt, new FunctionTemplateBuilderImpl,TemplateBuilderImpl() { + @Override + public TemplateBuilderImpl apply(TemplateBuilderImpl input) { +return input.imageChooser(new FunctionIterable? extends Image, Image() {

Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

2013-11-13 Thread Andrew Phillips
@@ -945,6 +975,15 @@ public TemplateBuilder imageMatches(PredicateImage condition) { * {@inheritDoc} */ @Override + public TemplateBuilderImpl imageChooser(FunctionIterable? extends Image,Image imageChooser) { [minor] Missing space in `,Image` --- Reply to this email

Re: [jclouds] jclouds-331 - imageChooser function backport (#202)

2013-11-13 Thread Andrew Phillips
@@ -111,16 +147,12 @@ public void testLocationPredicateWhenComputeMetadataIsNotLocationBound() { } @SuppressWarnings(unchecked) - @Test - public void testResolveImages() { - - + protected void doTestResolveImages(SupplierSet? extends Image images, Image