Re: [jclouds-labs-google] fix for JCLOUDS-372, changing MINUTES to SECONDS (#14)

2013-11-12 Thread Andrew Phillips
@@ -66,8 +66,11 @@ protected void configure() { } /** -* Provides a cache for tokens. Cache is time based and expires after 59 minutes (the maximum time a token is -* valid is 60 minutes) +* Provides a cache for tokens. Cache is time based and by default expires

Re: [jclouds-labs-google] fix for JCLOUDS-372, changing MINUTES to SECONDS (#14)

2013-11-12 Thread Andrew Phillips
@@ -78,7 +81,7 @@ protected void configure() { // bit before the deadline to make sure there aren't session expiration exceptions sessionIntervalInSeconds = sessionIntervalInSeconds 30 ? sessionIntervalInSeconds - 30 : sessionIntervalInSeconds; - return

[jclouds-labs-google] fix for JCLOUDS-372, changing MINUTES to SECONDS (#14)

2013-11-11 Thread ahgittin
You can merge this Pull Request by running: git pull https://github.com/ahgittin/jclouds-labs-google fix/jclouds-372 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-google/pull/14 -- Commit Summary -- * fix for JCLOUDS-372, changing

Re: [jclouds-labs-google] fix for JCLOUDS-372, changing MINUTES to SECONDS (#14)

2013-11-11 Thread CloudBees pull request builder plugin
[jclouds-labs-google-pull-requests #20](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/20/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/14#issuecomment-28205106

Re: [jclouds-labs-google] fix for JCLOUDS-372, changing MINUTES to SECONDS (#14)

2013-11-11 Thread Ignasi Barrera
Thanks @ahgittin! The fix LGTM. If someone with better knowledge of GCE than me does not say the contrary, I'll merge this PR later today. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/14#issuecomment-28205809

Re: [jclouds-labs-google] fix for JCLOUDS-372, changing MINUTES to SECONDS (#14)

2013-11-11 Thread Richard Downer
+1 for merging: https://developers.google.com/accounts/docs/OAuth2UserAgent#handlingtheresponse states ...Other parameters included in the response include expires_in and token_type. **These parameters describe the lifetime of the token in seconds** --- Reply to this email directly or view it