Re: [jclouds] JCLOUDS-381. Allow explicit naming of nodes via TemplateOptions. (#206)

2013-11-19 Thread Andrew Phillips
One question about `||` vs ``, but that should be easily answered. Otherwise, +1 - looks good to me. Thanks for the adjustments, @abayer! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/206#issuecomment-28865289

Incubator website cleanup?

2013-11-19 Thread Andrew Phillips
Once 1.6.3 is out, do we need to carry out some cleanup of the jclouds incubator site [1]? I haven't read this recent thread yet in full, but it seems to relate to similar issues: http://markmail.org/thread/3y7hmelendts36th ap [1] http://incubator.apache.org/projects/jclouds.html

Re: [jclouds-labs] CloudSigma2 API cleanup (#38)

2013-11-20 Thread Andrew Phillips
+ +Tag editedTag = new Tag.Builder() +.meta(meta) +.name(Edited Tag) +.resources(ImmutableList.of( +new TagResource.Builder() +.uuid(createdDrive.getUuid()) +

Re: [jclouds-labs] CloudSigma2 API cleanup (#38)

2013-11-20 Thread Andrew Phillips
+Tag editedTag = new Tag.Builder() +.meta(meta) +.name(Edited Tag) +.resources(ImmutableList.of( +new TagResource.Builder() +.uuid(createdDrive.getUuid()) +

Re: [jclouds-labs] CloudSigma2 API cleanup (#38)

2013-11-20 Thread Andrew Phillips
@@ -544,7 +543,7 @@ public void testEditProfileInfo() throws Exception { .address(edited address) .bankReference(sigma111) .company(Awesome company) -.country(USA) +.country(ES) :-) --- Reply to this email directly or view it

Re: [jclouds-labs] CloudSigma2 API cleanup (#38)

2013-11-20 Thread Andrew Phillips
+)) +.build(); + +checkTag(editedTag, api.editTag(createdTag.getUuid(), editedTag)); +} + +@Test(dependsOnMethods = {testEditTag}) +public void testDeleteTag() throws Exception{ +api.deleteTag(createdTag.getUuid()); +} + +

Re: [jclouds-labs] CloudSigma2 API cleanup (#38)

2013-11-20 Thread Andrew Phillips
Thanks, @nacx! Just a couple of small comments. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/38#issuecomment-28895596

Re: [jclouds-labs] Fix issue in the cloudsigma2 provider when ip fields are parsed as Strin... (#37)

2013-11-20 Thread Andrew Phillips
@nacx: Should we create a JIRA issue for this, or is this mainly part of work-in-progress..? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/37#issuecomment-28895956

Re: [jclouds-labs] Fix issue in the cloudsigma2 provider when ip fields are parsed as Strin... (#37)

2013-11-20 Thread Andrew Phillips
Anyway, if you prefer a JIRA I'm ok with having it too :) No, in this situation I'm fine without it... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/37#issuecomment-28900278

Re: 1.7.0 scheduling

2013-11-20 Thread Andrew Phillips
Yup, mentioned in the wiki. Doh, sloppy reading, sorry. It didn't render properly for me, I think (see attachment) - should be fixed now [1]? ap [1] https://wiki.apache.org/jclouds/Releasing%20jclouds?action=diffrev1=27rev2=28

Re: [VOTE] Release Apache jclouds-1.6.3-rc1

2013-11-20 Thread Andrew Phillips
http://www.apache.org/dist/jclouds/KEYS Would we need to add your apache.org email address to the key? pub 2048R/730FC232 2013-10-14 uid Andrew Gaul and...@gaul.org sig 3730FC232 2013-10-14 Andrew Gaul and...@gaul.org sig 508D20E9 2013-10-16 Matt

Re: 1.7.0 scheduling

2013-11-20 Thread Andrew Phillips
Should we publish 1.7 alpha/beta artifacts like we did pre-ASF? Ideally we would have done this regularly during the 1.7 development cycle. If we can find a way to do this reasonably quickly (ideally, automatically!) I'm sure that would help. As it is (hope it's been smooth for you, Andrew

Re: 1.7.0 scheduling

2013-11-20 Thread Andrew Phillips
Should we publish 1.7 alpha/beta artifacts like we did pre-ASF? Ideally we would have done this regularly during the 1.7 development cycle. ... Would work for me - they've been stable for ages, see active use and improvements and don't feel significantly less generic that e.g. route53. ap I

Re: [jclouds-labs-google] Fix Live Tests for JCLOUDS-360 which rely on platform-dep nanoseconds (#15)

2013-11-20 Thread Andrew Phillips
@wrigri PS: I'm guessing you've _run_ the live tests with this change, by the way? ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/15#issuecomment-28927776

Re: [DISCUSS] Release Apache jclouds-1.6.3-rc1

2013-11-20 Thread Andrew Phillips
I ran integration tests against Atmos, Amazon EC2, Amazon S3, Azure, and Cloud Files. Azure receives the teacher's apple and Amazon EC2 wins the skunk award: Hm...quite a lot of AWS EC2 failures there compared to last time [1]. Any thoughts on what might be causing this? Have we seen

Re: [jclouds-labs-google] Fix Live Tests for JCLOUDS-360 which rely on platform-dep nanoseconds (#15)

2013-11-20 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;h=cf7adb8). --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/15#issuecomment-28928028

Re: [jclouds-labs-google] Fix Live Tests for JCLOUDS-360 which rely on platform-dep nanoseconds (#15)

2013-11-20 Thread Andrew Phillips
Yes, I ran the live tests with this change Thanks for confirming, @wrigri! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/15#issuecomment-28931890

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

2013-11-20 Thread Andrew Phillips
+/** + * Select internal URL endpoints services + * + * @author Ignacio Mulas + */ +@Singleton +public class InternalURL implements EndpointToSupplierInternalURI { + @Override + public SupplierURI apply(Endpoint input) { + return

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

2013-11-20 Thread Andrew Phillips
Minor note: a couple of the files use two-space and/or tab rather than 3-space indents --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/142#issuecomment-28932369

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

2013-11-20 Thread Andrew Phillips
+ */ +@Test(groups = live, testName = InternalURLLiveTest) +public class InternalURLLiveTest extends BaseNovaApiLiveTest { + + @Singleton + class InternalUrlModule extends AbstractModule { + @Override + protected void configure() { +

Re: [DISCUSS] Release Apache jclouds-1.6.3-rc1

2013-11-20 Thread Andrew Phillips
[1] http://jclouds.apache.org/documentation/releasenotes/1.6.2-tests/ That page does not have results for aws-ec2, only aws-s3. Doh! Indeed. You're right, I don't think we ran the AWS EC2 live tests last time..? The remainder of the comparison looks stable enough ;-) ap

Re: [jclouds-labs] CloudSigma2 API cleanup (#38)

2013-11-21 Thread Andrew Phillips
@@ -138,29 +150,34 @@ public void testDeleteDrives() throws Exception { for (DriveInfo driveInfo : createdDrives) { stringListBuilder.add(driveInfo.getUuid()); } - api.deleteDrives(stringListBuilder.build()); + ImmutableListString uuids =

Re: [jclouds-labs] CloudSigma2 API cleanup (#38)

2013-11-21 Thread Andrew Phillips
rebased and addressed your comments. @nacx: Thanks! I'll keep out of the decision on what to do about _testListSubscriptionsCalculator_ - otherwise, just needs a squash of commits and would then be good to go for me. --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Remove more incubator references (#213)

2013-11-21 Thread Andrew Phillips
Committed to master and 1.6.x. Thanks for catching the additional incubating ones too, @andrewgaul! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/213#issuecomment-29052141

Re: [DISCUSS] Release Apache jclouds-1.6.3-rc1

2013-11-21 Thread Andrew Phillips
My vote is a +1 for the release. I guess that needs to go in the [VOTE] thread too? And we need to move the discussion about the keys *from* the [VOTE] thread to the [DISCUSS] thread ;-) ap

[jclouds] JCLOUDS-386: Removing the remote-resources plugin (#212)

2013-11-21 Thread Andrew Phillips
We only use the shared resources for the Checkstyle config now, and that doesn#39;t need to be quot;mixed inquot; to the project output directory You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds remove-remote-res-plugin Or you can view, comment on it, or

Re: [jclouds-labs-openstack] JCLOUDS-387: Removing DISCLAIMER file now that jclouds has graduated (#55)

2013-11-21 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-openstack.git;h=96c8340) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/55#issuecomment-29021517

Re: [jclouds-cli] JCLOUDS-387: Removing DISCLAIMER file now that jclouds has graduated (#15)

2013-11-21 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-cli.git;h=85568c9) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/15#issuecomment-29024107

Re: [jclouds-karaf] JCLOUDS-387: Removing DISCLAIMER file now that jclouds has graduated (#27)

2013-11-21 Thread Andrew Phillips
Weird failure in placing the comment from the [DEV@cloud build](https://jclouds.ci.cloudbees.com/view/pull%20requests/job/jclouds-karaf-pull-requests/19/consoleFull), but the result looks OK: ``` INFO: Apache jclouds :: Karaf ... SUCCESS [16.448s] Nov 21, 2013 1:33:39 PM

[jclouds-labs-openstack] JCLOUDS-387: Removing DISCLAIMER file now that jclouds has graduated (#55)

2013-11-21 Thread Andrew Phillips
You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-labs-openstack remove-disclaimer Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-openstack/pull/55 -- Commit Summary -- * JCLOUDS-387: Removing

Re: [jclouds-labs] JCLOUDS-387: Removing DISCLAIMER file now that jclouds has graduated (#39)

2013-11-21 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;h=21acd9e) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/39#issuecomment-29021186

Re: [jclouds] JCLOUDS-387: Removing DISCLAIMER file now that jclouds has graduated (#211)

2013-11-21 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=4f95de2) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/211#issuecomment-29020742

Re: [jclouds-cli] JCLOUDS-387: Removing DISCLAIMER file now that jclouds has graduated (#15)

2013-11-21 Thread Andrew Phillips
+1, second commit addresses the first failure. Thanks, @andrewgaul! Just pushed a squashed version. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/15#issuecomment-29022283

Re: [jclouds-chef] JCLOUDS-387: Removing DISCLAIMER file now that jclouds has graduated (#38)

2013-11-21 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-chef.git;h=5cbba5c) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-chef/pull/38#issuecomment-29021736

[jclouds-labs] JCLOUDS-387: Removing DISCLAIMER file now that jclouds has graduated (#39)

2013-11-21 Thread Andrew Phillips
You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-labs remove-disclaimer Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs/pull/39 -- Commit Summary -- * JCLOUDS-387: Removing DISCLAIMER file now that

[jclouds-chef] JCLOUDS-387: Removing DISCLAIMER file now that jclouds has graduated (#38)

2013-11-21 Thread Andrew Phillips
You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-chef remove-disclaimer Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-chef/pull/38 -- Commit Summary -- * JCLOUDS-387: Removing DISCLAIMER file now that

Re: [jclouds] Remove more incubator references (#213)

2013-11-21 Thread Andrew Phillips
Good catches - thanks! +1 - looks good to me. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/213#issuecomment-29009800

Re: [DISCUSS] Release Apache jclouds-1.6.3-rc1

2013-11-21 Thread Andrew Phillips
You can drop that file. Probably should as well. BTW we aren't mentors anymore, jclouds has graduated. :) Is trusted friend of the project and advisor OK? ;-) Thanks for the input, David. My vote would also be to fix and respin... ap

[jclouds-karaf] JCLOUDS-387: Removing DISCLAIMER file now that jclouds has graduated (#27)

2013-11-21 Thread Andrew Phillips
You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-karaf remove-disclaimer Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-karaf/pull/27 -- Commit Summary -- * JCLOUDS-387: Removing DISCLAIMER file now that

Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)

2013-11-21 Thread Andrew Phillips
@zack-shoylev: Reviewing the [output from release:prepare](http://pastie.org/private/uu7wabhqfpdzzplzibgsza), it looks like the additional `version..` property may actually be unnecessary: ``` Dependency 'org.apache.jclouds:jclouds-project' is a snapshot (1.7.0-SNAPSHOT) : Which release version

Re: [jclouds-karaf] JCLOUDS-387: Removing DISCLAIMER file now that jclouds has graduated (#27)

2013-11-21 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;h=34751a9) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/27#issuecomment-29022128

Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints (#142)

2013-11-21 Thread Andrew Phillips
The idea behind this change is to give the jclouds user a way of selecting the internalUrl from the services catalog returned by keystone. Ah, so you would use it as demonstrated in the test: create a module to override the standard EndpointToSupplierURI binding and pass that module to the

[jclouds-cli] JCLOUDS-387: Removing DISCLAIMER file now that jclouds has graduated (#15)

2013-11-21 Thread Andrew Phillips
You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-cli remove-disclaimer Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-cli/pull/15 -- Commit Summary -- * JCLOUDS-387: Removing DISCLAIMER file now that

Re: [DISCUSS] Release Apache jclouds-1.6.3-rc1

2013-11-21 Thread Andrew Phillips
@abayer: are you planning to update the release verification script [1]? The dists location has changed - I'm about to figure out what else I need to tweak in the Windows version ;-) ap [1] http://people.apache.org/~abayer/verify_jclouds_release.sh

Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)

2013-11-21 Thread Andrew Phillips
I would like to keep this consistent though Agree. So let's leave it in for now. But it's good to know the opportunity exists, and what the potential costs are ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-29049258

Re: [jclouds] JCLOUDS-386: Removing the remote-resources plugin (#212)

2013-11-21 Thread Andrew Phillips
@abayer Since, from what I can see, you were the last person to touch the remote-resources config, could you kindly have a look at this when you have a minute? Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/212#issuecomment-29050133

Re: [jclouds-cli] JCLOUDS-104: Cleaning up CLI POMs (#14)

2013-11-21 Thread Andrew Phillips
Squashed. Waiting for a final DEV@cloud build before merging. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/14#issuecomment-29050727

Re: Control network in a node via jclouds

2013-11-22 Thread Andrew Phillips
Hi Reka We would like to control the network interfaces via jclouds when creating a node. We came up with this when trying with openstack Grizzly where we can configure more than one network per project. Is there any way that we can pass network or networks to a node via jclouds? Could you

Re: [jclouds] JCLOUDS-386: Removing the remote-resources plugin (#212)

2013-11-22 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=981db34). Thanks, @abayer! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/212#issuecomment-29119209

Re: Region concept is not there in Openstack-nova API ?

2013-11-22 Thread Andrew Phillips
Noticed $subject. Is it the case? I'm hardly the expert here, and this probably makes more sense to some of the Rackspace folks on the mailing list. But just to clarify: would this be the same type of region as referred to in the Nova command line client docs [1]? --os-region-name

Re: Region concept is not there in Openstack-nova API ?

2013-11-23 Thread Andrew Phillips
Thanks for investigating. AFAIK Openstack has a 3 layer hierarchy : Region -- Zone -- Host 1 : n 1: m OK, now we're leaving the land of my OpenStack expertise. I hope one of the OpenStack gurus on the list (or on IRC?) can shed more light on this

Re: [jclouds-labs] CloudSigma2 API cleanup (#38)

2013-11-24 Thread Andrew Phillips
it requires changes to the api and the domain model, and it is out of scope of this one. Good to merge then? After squashing, yes - looks good to me! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/38#issuecomment-29161175

Re: [jclouds-labs-google] JCLOUDS-381. Allow explicit naming of nodes, decouple group identity fro... (#16)

2013-11-24 Thread Andrew Phillips
@@ -236,6 +236,14 @@ public GoogleComputeEngineTemplateOptions userMetadata(String key, String value) * {@inheritDoc} */ @Override + public GoogleComputeEngineTemplateOptions nodeNames(IterableString nodeNames) { Just doing things the same way for this method call as

Re: [jclouds-labs-openstack] Get a set of messages by id. (#57)

2013-11-24 Thread Andrew Phillips
+import javax.inject.Singleton; + +import static com.google.common.base.Preconditions.checkArgument; +import static com.google.common.base.Preconditions.checkNotNull; + +/** + * @author Everett Toews + */ +@Singleton +public class BindIdsToQueryParam implements Binder { + +

Re: [jclouds-labs-openstack] Get a set of messages by id. (#57)

2013-11-24 Thread Andrew Phillips
UUID clientId = UUID.fromString(3381af92-2b9e-11e3-b191-71861300734c); + messageIds.put(zoneId, new ArrayListString()); `Lists.newArrayList()`? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/57/files#r7881672

Re: [jclouds-labs-openstack] Get a set of messages by id. (#57)

2013-11-24 Thread Andrew Phillips
@@ -136,6 +144,23 @@ public void streamManyPagesOfMessages() throws Exception { } @Test(dependsOnMethods = { streamManyPagesOfMessages }) + public void listMessagesByIds() throws Exception { + for (String zoneId : api.getConfiguredZones()) { + MessageApi

Re: [jclouds-labs-openstack] The list queues methods for the QueueApi. (#56)

2013-11-24 Thread Andrew Phillips
+import java.util.Map; + +import static com.google.common.base.Preconditions.checkNotNull; + +/** + * A queue. + * + * @author Everett Toews + */ +public class Queue { + + private final String name; + private final MapString, String metadata; + + protected Queue(String name,

Re: [jclouds-labs-openstack] Get a set of messages by id. (#57)

2013-11-24 Thread Andrew Phillips
+ + ListMessage messages = messageApi.list(clientId, ids); + + assertEquals(messages.size(), 3); + + for (Message message: messages) { +assertNotNull(message.getId()); +assertNotNull(message.getBody()); +

Re: [jclouds-labs-openstack] The list queues methods for the QueueApi. (#56)

2013-11-24 Thread Andrew Phillips
boolean exists(@PathParam(name) String name); - // TODO stream method! + /** +* List the queues. [minor] Lists...? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/56/files#r7881698

Re: [jclouds-labs-openstack] The list queues methods for the QueueApi. (#56)

2013-11-24 Thread Andrew Phillips
} } @Test(dependsOnMethods = { create }) + public void listOnePageOfQueues() throws Exception { + for (String zoneId : api.getConfiguredZones()) { + QueueApi queueApi = api.getQueueApiForZone(zoneId); + ListQueue queues =

Re: [jclouds-labs-openstack] The list queues methods for the QueueApi. (#56)

2013-11-24 Thread Andrew Phillips
@@ -35,20 +38,96 @@ @Test(groups = live, testName = QueueApiLiveTest, singleThreaded = true) public class QueueApiLiveTest extends BaseMarconiApiLiveTest { + public void listZeroPagesOfQueues() throws Exception { + for (String zoneId : api.getConfiguredZones()) { +

Re: [jclouds-labs-openstack] The list queues methods for the QueueApi. (#56)

2013-11-24 Thread Andrew Phillips
assertTrue(success); } } @Test(dependsOnMethods = { setMetadata }) + public void listManyPagesOfQueuesWithDetails() throws Exception { + for (String zoneId : api.getConfiguredZones()) { + QueueApi queueApi = api.getQueueApiForZone(zoneId); +

Re: [jclouds-labs-openstack] The list queues methods for the QueueApi. (#56)

2013-11-24 Thread Andrew Phillips
+ server.enqueue(new MockResponse().setBody(accessRackspace)); + server.enqueue(new MockResponse().setResponseCode(200).setBody({\queues\: [{\href\: \/v1/queues/jclouds-test-1\, \name\: \jclouds-test-1\}, {\href\: \/v1/queues/jclouds-test-10\, \name\: \jclouds-test-10\}, {\href\:

Re: [jclouds-labs-openstack] The list queues methods for the QueueApi. (#56)

2013-11-24 Thread Andrew Phillips
@@ -122,6 +128,120 @@ public void doesNotExistQueue() throws Exception { } } + public void listZeroPagesOfQueues() throws Exception { + MockWebServer server = mockOpenStackServer(); + server.enqueue(new MockResponse().setBody(accessRackspace)); +

Re: [jclouds-labs-openstack] The list queues methods for the QueueApi. (#56)

2013-11-24 Thread Andrew Phillips
@@ -128,7 +232,7 @@ public void delete() throws Exception { public void doesNotExist() throws Exception { for (String zoneId : api.getConfiguredZones()) { QueueApi queueApi = api.getQueueApiForZone(zoneId); - boolean success = queueApi.exists(jclouds-test); +

Re: [jclouds-labs-openstack] The list queues methods for the QueueApi. (#56)

2013-11-24 Thread Andrew Phillips
A couple of real questions and one (minor) repeated comment about adding messages to `assertNotNull` and `assertTrue/False`? Makes figuring out what has failed in Jenkins etc. much easier... --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] Get a set of messages by id. (#57)

2013-11-24 Thread Andrew Phillips
@Path(/messages) MessageStream stream(@HeaderParam(Client-ID) UUID clientId, -StreamOptions... options); +StreamMessagesOptions... options); + + /** +* List specific messages. Unlike the stream method, a client's own messages

Re: [jclouds-labs-openstack] Get a set of messages by id. (#57)

2013-11-24 Thread Andrew Phillips
@@ -136,6 +144,23 @@ public void streamManyPagesOfMessages() throws Exception { } @Test(dependsOnMethods = { streamManyPagesOfMessages }) + public void listMessagesByIds() throws Exception { + for (String zoneId : api.getConfiguredZones()) { + MessageApi

Re: [jclouds-labs-openstack] Get a set of messages by id. (#57)

2013-11-24 Thread Andrew Phillips
@@ -136,6 +144,23 @@ public void streamManyPagesOfMessages() throws Exception { } @Test(dependsOnMethods = { streamManyPagesOfMessages }) + public void listMessagesByIds() throws Exception { + for (String zoneId : api.getConfiguredZones()) { + MessageApi

Re: [jclouds-labs-openstack] OS Neutron Extension Router (#47)

2013-11-25 Thread Andrew Phillips
@@ -37,10 +37,7 @@ public String getValue() { } public static NetworkType fromValue(String value) { - for (NetworkType networkType : values()) { - if (networkType.getValue().equalsIgnoreCase(value)) -return networkType; - } - return null; +

Re: [jclouds-labs-openstack] OS Neutron Extension Router (#47)

2013-11-25 Thread Andrew Phillips
+ + /** +* Returns the list of all routers currently defined in Neutron for the current tenant. The list provides the unique +* identifier of each router configured for the tenant +* +* @return the list of all router references configured for the tenant. +*/ +

Re: [jclouds-labs-openstack] OS Neutron Extension Router (#47)

2013-11-25 Thread Andrew Phillips
+ + @Override + protected FunctionObject, IterableWithMarkerReferenceWithName markerToNextForArg0(OptionalObject arg0) { + String zone = arg0.isPresent() ? arg0.get().toString() : null; + final RouterApi routerApi = api.getRouterExtensionForZone(zone).get(); +

Re: [jclouds-labs-openstack] OS Neutron Extension Router (#47)

2013-11-25 Thread Andrew Phillips
Thanks for responding to the review comments, @KrisSterckx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/47#issuecomment-29208427

Re: [jclouds] Delete objects in a container efficiently. (#214)

2013-11-25 Thread Andrew Phillips
jclouds-java-7-pull-requests #880 UNSTABLE Haven't looked at the code, just wanted to add that that looks like an [unrelated test

Re: [jclouds-labs-openstack] OS Neutron Extension Router (#47)

2013-11-25 Thread Andrew Phillips
@@ -29,7 +29,7 @@ * @author Nick Livens * @see a href=http://docs.openstack.org/api/openstack-network/2.0/content/Subnets.html;api doc/a */ -public class AllocationPool { +public final class AllocationPool { Ah, yes, I recall. Thanks for the reminder, @KrisSterckx! --- Reply to

Re: [DISCUSS] Release Apache jclouds-1.6.3-rc1

2013-11-25 Thread Andrew Phillips
I started the 1.6.3-rc2 release yesterday but INFRA-7048 blocks me from closing the staging repository: https://issues.apache.org/jira/browse/INFRA-7048 Thanks for the update, Andrew G. Hope this gets fixed soon! ap

Re: [jclouds] JCLOUDS-218. List templates in all known projects for CloudStack. (#215)

2013-11-25 Thread Andrew Phillips
+ * + * @author Andrew Bayer + */ +@Test(groups = live, singleThreaded = true, testName = ProjectApiLiveTest) +public class ProjectApiLiveTest extends BaseCloudStackApiLiveTest { + + @Test + public void testListAccounts() throws Exception { + for (Project project :

Re: [jclouds] JCLOUDS-218. List templates in all known projects for CloudStack. (#215)

2013-11-26 Thread Andrew Phillips
+ * + * @see a + * href=http://download.cloud.com/releases/3.0.6/api_3.0.6/root_admin/listProjects.html; + * / + * @author Andrew Bayer + */ +public class ListProjectsOptions extends AccountInDomainOptions { + + public static final ListProjectsOptions NONE = new

Re: [jclouds] JCLOUDS-218. List templates in all known projects for CloudStack. (#215)

2013-11-26 Thread Andrew Phillips
+ } + } + + private final String id; + private final String account; + private final String displayText; + private final String domain; + private final String domainId; + private final String name; + private final State state; + + @ConstructorProperties({ +

Re: [jclouds] JCLOUDS-218. List templates in all known projects for CloudStack. (#215)

2013-11-26 Thread Andrew Phillips
Waiting for BuildHive, but (pending squash'n'commit) looks good to me! Thanks, @abayer! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/215#issuecomment-29314397

Re: [jclouds] JCLOUDS-218. List templates in all known projects for CloudStack. (#215)

2013-11-26 Thread Andrew Phillips
Squashed, rebased, waiting to see how it does to be safe. All the builders are happy, it seems! ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/215#issuecomment-29315890

Re: [jclouds] Fixes filesystem tests sometimes failing on Windows. (#217)

2013-11-26 Thread Andrew Phillips
@@ -41,7 +44,11 @@ public static void deleteRecursively(File file) throws IOException { } } if (!file.delete()) { - throw new IOException(Could not delete: + file); + // On windows, often the directory does not register as empty right away. +

Re: [jclouds] Fixes filesystem tests sometimes failing on Windows. (#217)

2013-11-26 Thread Andrew Phillips
don't want to slow tests down, they are slow as is. Fair enough! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/217#issuecomment-2931

Re: [jclouds-labs] Cloudsigma2 subscription calc fix (#41)

2013-11-27 Thread Andrew Phillips
+import java.util.Date; + +/** + * @author Vladimir Shevchenko + */ +public class CalcSubscription { + + public static class Builder { + private String amount; + private double discountAmount; + private double discountPercent; + private Date endTime; +

Re: [jclouds-labs] Cloudsigma2 subscription calc fix (#41)

2013-11-27 Thread Andrew Phillips
@@ -944,25 +947,13 @@ IPInfo editIP(@PathParam(uuid) String uuid /** * This is identical to the listSubscriptions(), except that subscriptions are not actually bought. * -* @return list of subscriptions that are not actually bought. +* @return List of subscriptions

Re: [jclouds-labs] Cloudsigma2 subscription calc fix (#41)

2013-11-27 Thread Andrew Phillips
+ this.resource = resource; + return this; + } + + /** + * @param startTime Start time of subscription + * @return Subscription Binder + */ + public Builder startTime(Date startTime) { + this.startTime = startTime; +

Re: [jclouds-labs] Cloudsigma2 subscription calc fix (#41)

2013-11-27 Thread Andrew Phillips
@@ -587,9 +588,29 @@ public void testGetSubscription() throws Exception { } @Test - public void testListSubscriptionsCalculator() throws Exception { - for (Subscription subscription : api.listSubscriptionsCalculator().concat()) { - assertNotNull(subscription); +

Re: [jclouds-labs] Cloudsigma2 subscription calc fix (#41)

2013-11-28 Thread Andrew Phillips
+ */ +package org.jclouds.cloudsigma2.domain; + +import javax.inject.Named; +import java.beans.ConstructorProperties; +import java.util.Date; + +/** + * @author Vladimir Shevchenko + */ +public class CalcSubscription { + + public static class Builder { + private String amount;

Re: [DISCUSS] Release Apache jclouds-1.6.3-rc2

2013-11-28 Thread Andrew Phillips
Would it be possible to cut a new RC for 1.6.3 including this? I'm -0 on this one. Would prefer to get 1.6.3 out of the door, focus on a timely 1.7.0 and then spin a quick(er) 1.6.4 early next year. But I think ultimately this is a decision for the release manager. Over to you, Gaul ;-)

Re: [jclouds-labs] backport of live tests fix for oauth problems re JCLOUDS-360 (#43)

2013-11-28 Thread Andrew Phillips
Second time around looks better. Still waiting on BuildHive, but otherwise +1 from me. Thanks, @ahgittin! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/43#issuecomment-29480601

Re: [VOTE] Release Apache jclouds-1.6.3-rc2

2013-11-28 Thread Andrew Phillips
=== Apache ID: andrewp --- [X] +1 Release. [ ] -1 Don't release (see notes). --- Checklist

Re: Decoupling script builder from jclouds-core.

2013-11-29 Thread Andrew Phillips
Does it make sense to move login statements from script builder to compute? That would eliminate (i). I don't know scriptbuilder too well, but I think if we really want to decouple it we should take *all* hard-coded statements out of it and make the script building engine a separate

Re: [jclouds-labs] Cloudsigma2 subscription calc fix (#41)

2013-11-29 Thread Andrew Phillips
+ @Named(discount_amount) + private final Double discountAmount; + @Named(discount_percent) + private final Double discountPercent; + private final String period; + private final Double price; + private final SubscriptionResource resource; + @Named(start_time) + private

Re: [jclouds-labs] Cloudsigma2 subscription calc fix (#41)

2013-11-29 Thread Andrew Phillips
+ private final Date endTime; + + @ConstructorProperties({ + amount, discount_amount, discount_percent, period, price, resource, start_time, end_time + }) + public CalcSubscription(@Nullable Double amount, @Nullable Double discountAmount, @Nullable Double

Re: [jclouds-labs] Cloudsigma2 subscription calc fix (#41)

2013-11-29 Thread Andrew Phillips
+import java.util.List; + +import static com.google.common.base.Preconditions.checkNotNull; + +/** + * @author Vladimir Shevchenko + */ +public class SubscriptionCalculator { + private final double price; + @Named(objects) + private final ListCalcSubscription subscriptions; + +

Re: [jclouds-labs] Cloudsigma2 subscription calc fix (#41)

2013-11-29 Thread Andrew Phillips
+ CloudSigma2Api api = requestSendsResponse( +postBuilder() +.endpoint(endpoint + subscriptioncalculator/) + .payload(payloadFromResourceWithContentType(/subscriptioncalculator-request.json + , MediaType.APPLICATION_JSON)) +

Re: [jclouds-labs] profitbricks: impl: provider base (#44)

2013-11-29 Thread Andrew Phillips
PS: Is this PR still supposed to be closed? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/44#issuecomment-29524935

Re: [jclouds-labs] profitbricks: impl: provider base (#44)

2013-11-29 Thread Andrew Phillips
Thanks, @sivikt! Just a quick heads-up that we're just wrapping up the 1.6.3 release of jclouds at present, so it might take a little longer to review your PR... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/44#issuecomment-29524922

Re: [jclouds-labs] BlobStore API for Orion based back-ends (#45)

2013-11-30 Thread Andrew Phillips
@timur87: Looks like a real compilation error: ``` [INFO] - [ERROR] COMPILATION ERROR : [INFO] - [ERROR] bootstrap class path not set in conjunction with -source 1.6

Re: [ANNOUNCE] Apache jclouds 1.6.3 released

2013-11-30 Thread Andrew Phillips
Congrats and thanks to Andrew G. for cutting his first release!! ap

<    1   2   3   4   5   6   7   8   9   10   >