Re: Code review. Please approve new branches.

2017-06-04 Thread Michael Osipov
Am 2017-06-03 um 13:53 schrieb Tibor Digana: Hi Michael, I have pushed branch SUREFIRE-1380_2, see [1], and separated the previous ticket SUREFIRE-1380 to two: SUREFIRE-1380 and SUREFIRE-1381. The branch SUREFIRE-1380_2 is for Jira SUREFIRE-1380. [1]:

Re: Code review. Please approve new branches.

2017-06-03 Thread Guillaume Boué
I've ran successfully the ITs on FreeBSD under JDK 7 and 8, so +1 from me. Would it make sense to add an IT for SUREFIRE-1376? Guillaume Le 03/06/2017 à 13:53, Tibor Digana a écrit : Hi Michael, I have pushed branch SUREFIRE-1380_2, see [1], and separated the previous ticket SUREFIRE-1380

Re: Code review. Please approve new branches.

2017-06-03 Thread Tibor Digana
Hi Michael, I have pushed branch SUREFIRE-1380_2, see [1], and separated the previous ticket SUREFIRE-1380 to two: SUREFIRE-1380 and SUREFIRE-1381. The branch SUREFIRE-1380_2 is for Jira SUREFIRE-1380. [1]:

Re: Code review. Please approve new branches.

2017-06-03 Thread Michael Osipov
Am 2017-06-03 um 12:36 schrieb Tibor Digana: Michael, I will split SUREFIRE-1380 in two tickets on tomorrow evening. Another flush is necessary because the method InputStream.read() is called in a loop and the flush should be called after last byte. If another thread marks the stream to be

Re: Code review. Please approve new branches.

2017-06-03 Thread Michael Osipov
Looks good now. Am 2017-06-03 um 12:31 schrieb Tibor Digana: The changes in SUREFIRE-1376 are done. On Sat, Jun 3, 2017 at 11:52 AM, Michael Osipov wrote: Am 2017-06-03 um 10:56 schrieb Tibor Digana: I have added a new branch with small change only, SUREFIRE-1380.

Re: Code review. Please approve new branches.

2017-06-03 Thread Tibor Digana
Michael, I will split SUREFIRE-1380 in two tickets on tomorrow evening. Another flush is necessary because the method InputStream.read() is called in a loop and the flush should be called after last byte. If another thread marks the stream to be closed asynchronously, then the bytes can be lost.

Re: Code review. Please approve new branches.

2017-06-03 Thread Tibor Digana
The changes in SUREFIRE-1376 are done. On Sat, Jun 3, 2017 at 11:52 AM, Michael Osipov wrote: > Am 2017-06-03 um 10:56 schrieb Tibor Digana: > >> I have added a new branch with small change only, SUREFIRE-1380. >> https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git

Re: Code review. Please approve new branches.

2017-06-03 Thread Michael Osipov
Am 2017-06-03 um 10:56 schrieb Tibor Digana: I have added a new branch with small change only, SUREFIRE-1380. https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1380 I am not happy with this: you mix two different taks in one issue, refactoring and

Re: Code review. Please approve new branches.

2017-06-03 Thread Michael Osipov
Am 2017-06-03 um 09:03 schrieb Tibor Digana: Hi all, We have a patch received from users group. I have improved it a bit, added Javadoc and pushed the code to branch [1]. Jira issue related [2]. [1]:

Re: Code review. Please approve new branches.

2017-06-03 Thread Tibor Digana
I have added a new branch with small change only, SUREFIRE-1380. https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1380 On Sat, Jun 3, 2017 at 9:03 AM, Tibor Digana wrote: > Hi all, > > We have a patch received from users

Code review. Please approve new branches.

2017-06-03 Thread Tibor Digana
Hi all, We have a patch received from users group. I have improved it a bit, added Javadoc and pushed the code to branch [1]. Jira issue related [2]. [1]: https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1376 [2]: