Re: Changing Minimum Build Requirements for plugins to JDK11

2023-11-14 Thread Benjamin Marwell
> We (as Maven developers) will have to use Java 11 to build plugins but > not be able to use Java 11 features in the code. > That sounds frustrating to me :) > Or I don't understand the change you are trying to propose? Not at all. This is how I did it at work. This already removes a lot of

Re: Changing Minimum Build Requirements for plugins to JDK11

2023-11-14 Thread Karl Heinz Marbaise
Hi, On 14.11.23 14:16, Hervé Boutemy wrote: no need to change the build prerequisite: just add a profile to activate the release flag on newer JDK: https://issues.apache.org/jira/browse/MPOM-447 Add another profile... it would be better to clean up those things and make clean upgrade

Re: Changing Minimum Build Requirements for plugins to JDK11

2023-11-14 Thread Karl Heinz Marbaise
Hi, On 14.11.23 12:54, Elliotte Rusty Harold wrote: I'm OK with Java 11 required to build Maven in 2023, but I'll play my broken record: it is not yet OK to require Java 11 to run Maven or plugins. There are still a lot of developers out there who are using JDK 8 toolchains. and contrary to

Re: Changing Minimum Build Requirements for plugins to JDK11

2023-11-14 Thread Hervé Boutemy
no need to change the build prerequisite: just add a profile to activate the release flag on newer JDK: https://issues.apache.org/jira/browse/MPOM-447 Regards, Hervé Le lundi 13 novembre 2023, 20:38:00 CET Karl Heinz Marbaise a écrit : > Hi, > > currently we have already the build

Re: Changing Minimum Build Requirements for plugins to JDK11

2023-11-14 Thread Elliotte Rusty Harold
I'm OK with Java 11 required to build Maven in 2023, but I'll play my broken record: it is not yet OK to require Java 11 to run Maven or plugins. There are still a lot of developers out there who are using JDK 8 toolchains. and contrary to common claims, it is still a supported version by many

Re: Changing Minimum Build Requirements for plugins to JDK11

2023-11-14 Thread Jorge Solórzano
+1 (non-binding) Actually, it should not make any difference if one builds a plugin using Java 11 or Java 17 (or even Java 21 with a warning) and targets Java 8 using the "--release 8" option (and that dependencies are compatible), so just for using --release option is actually enough (even if

Re: Changing Minimum Build Requirements for plugins to JDK11

2023-11-14 Thread Olivier Lamy
oh right, sorry I didn't read correctly. Do you want to build with Java 11 as a minimum but limit to the usage of Java 8? What is the point? We (as Maven developers) will have to use Java 11 to build plugins but not be able to use Java 11 features in the code. That sounds frustrating to me :) Or I

Re: Changing Minimum Build Requirements for plugins to JDK11

2023-11-13 Thread Olivier Lamy
Hi Do we have a bytecode enforcer rule but for plugins? That would help users who are eventually stuck with Java 8 and so cannot upgrade plugins going to be 11 required. Cheers Olivier On Tue, 14 Nov 2023 at 5:38 am, Karl Heinz Marbaise wrote: > Hi, > > currently we have already the build

Re: Changing Minimum Build Requirements for plugins to JDK11

2023-11-13 Thread Slawomir Jaranowski
+1 To discuss what versions matrix we want to have in CI builds ... lts + latest-ea? so will be 11, 17, 21, 22 I also build legacy applications with target 8 by jdk 11+ and don't see any issue. pon., 13 lis 2023 o 20:38 Karl Heinz Marbaise napisał(a): > Hi, > > currently we have already the

Re: Changing Minimum Build Requirements for plugins to JDK11

2023-11-13 Thread Sylwester Lachiewicz
+1 Sylwester Ps. Hope to see soon that we drop Java 8 completely pon., 13 lis 2023, 20:38 użytkownik Karl Heinz Marbaise napisał: > Hi, > > currently we have already the build requirements for Maven Core at JDK11+ > > So in consequence I would suggest to lift the minimum requirement for >

Re: Changing Minimum Build Requirements for plugins to JDK11

2023-11-13 Thread Benjamin Marwell
Big +1 I sometimes need to switch back from JDK 21 to 17 or earlier to build some of the plugins. If we start building with 11+, we can detect build errors easier for newer JDKs. The spotless profile might not be the only profile we can remove. One catch, though. Should we not test on JDK8?