Re: [jira] [Commented] (MSHARED-594) NullPointerException is thrown when trying to install a project without POM file

Hi Buillaume, On 08/10/16 22:08, Guillaume Boué wrote: Hi, It is allowed by install:install-file when you set generatePom=false. It would install for example a JAR without any POM. It is true that you won't be able to depend on the artifact as-is... perhaps we should force generatePom=true

Re: svn commit: r1763929 - /maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/internal/DefaultProjectInstaller.java

Hi, IIRC ProjectInstaller has been introduced recently, I can imagine it hasn't been pushed to all plugins which should use it instead of the ArtifactInstaller. While implementing maven-artifact-transfer and using it in several plugins I just hit these edge cases where the local repo is

Re: [jira] [Created] (MINSTALL-128) Replace usage of the deprecated ArtifactFactory

Hi Guillaume, the code duplication was based on the first steps I had done to move the general cases to the shared component...and it's good that you cleaned up the code in maven-install-plugin... Kind regards Karl Heinz On 08/10/16 22:06, Guillaume Boué (JIRA) wrote: Guillaume Boué

[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...

Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/94 @rpatrick00 It looks like "--file" is not recognize but "-file" is recognized. The second issue where I have `/a/b` folders and `b` contains single `pom.xml` and `.mvn` - no multimodule.

Re: Maven 3.4.0 Release

Hi Jason, On 09/10/16 14:10, Jason van Zyl wrote: The preparation of detailed released notes to be reviewed. > The last release was almost a year ago, and an enormous number > of behavioral changes have been made in that time-frame. > There’s zero documentation outlining these changes thus

[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...

Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/94 OK, I found and resolved the problem with the --file arg but am not seeing the other problem you describe (see output below). Maybe my fix for the --file arg resolved that one too? Here

Re: shared: maven-artifact-transfer

Hi Karl Heinz, The VersionRangeResolver is an interface for which Maven has a default implementation. Since maven-transfer-utils depends on Maven 3.0, there's the org.apache.maven.repository.internal.DefaultVersionRangeResolver which implements the Sonatype version of VersionRangeResolver.

[SUREFIRE] Jenkins job for junit5 branch

Hello, I've created a build job for the junit5 branch [1]. It's a copy of the maven-surefire job with the only difference that it does not publish build artifacts to the snapshots repository. It maybe possible to configure this more elegantly by using the Jenkins Pipeline Plugin, but I don't know

[Jigsaw] First working prototype of maven-jlink-plugin / maven-jmod-plugin

Hi, I have created the plugins maven-jlink-plugin / maven-jmod-plugin as a first prototype (Just to see how / and if it works). Also I have created a working example to use them: https://github.com/khmarbaise/jdk9-jlink-jmod-example/tree/master/maven-example This has been tested with JDK

Re: [SUREFIRE] Parameterized Tests for Junit 4 and Junit 5? (Was: [SUREFIRE] JUnit 5 support - how to move things forward?)

Hello Tibor, I think I understand what you're thinking of. I'll give it a try and see if I can come up with something useful :-) Regards, Benedikt Tibor Digana schrieb am Mi., 5. Okt. 2016 um 00:18 Uhr: > Instead of using in Surefire (may affect the > ITs), there

Re: Maven 3.4.0 Release

Did we revert the modelVersion bump? On Sunday 9 October 2016, Karl Heinz Marbaise wrote: > Hi Jason, > > > On 09/10/16 14:10, Jason van Zyl wrote: > >> The preparation of detailed released notes to be reviewed. >> > > The last release was almost a year ago, and an enormous

Re: svn commit: r1763929 - /maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/internal/DefaultProjectInstaller.java

The only quirk is that org.apache.maven.artifact.metadata.ArtifactMetadata is deprecated... so this would add usage of the deprecated interface in RepositoryManager. What is the alternative for this? Le 09/10/2016 à 14:36, Karl Heinz Marbaise a écrit : Hi Buillaume, On 09/10/16 14:28,

Re: svn commit: r1763929 - /maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/internal/DefaultProjectInstaller.java

If the caller needs to force a different local repository than the one in the Maven session, they can already call "repositoryManager.setLocalRepositoryBasedir" on the building request that is passed to ProjectInstaller. This is what the plugins using ArtifactInstaller are already doing, and

Re: [Jigsaw] First working prototype of maven-jlink-plugin / maven-jmod-plugin

Nice, will have a look at it soon. On Sun, 09 Oct 2016 14:17:18 +0200, Karl Heinz Marbaise wrote: Hi, I have created the plugins maven-jlink-plugin / maven-jmod-plugin as a first prototype (Just to see how / and if it works). Also I have created a working example to

Re: svn commit: r1763929 - /maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/internal/DefaultProjectInstaller.java

Hi Guillaume, This is already used in other locations of the maven-artifact-transfer... Maven30ArtifactRepositoryAdapter, Maven31ArtifactRepositoryAdapter, Maven30ArtifactDeployer, Maven31ArtifactDeployer...only to mention a few... org.apache.maven.repository.legacy.metadata.ArtifactMetadata

[GitHub] maven-surefire pull request #127: [SUREFIRE-1293] Simplify org.apache.maven....

Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/127#discussion_r82527079 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java --- @@ -76,7 +76,7 @@ public

Re: Maven 3.4.0 Release

The preparation of detailed released notes to be reviewed. The last release was almost a year ago, and an enormous number of behavioral changes have been made in that time-frame. There’s zero documentation outlining these changes thus far in the site as far as I can tell. That’s the only

[GitHub] maven-surefire issue #124: Fix formatting, convert tabs to spaces

Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/124 @Tibor17 easy fix, how about merging it? ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] maven-surefire pull request #125: Consistently rename JUnit 4.x integration ...

Github user britter commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/125#discussion_r82520806 --- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/JUnit47ConcurrencyIT.java --- @@ -32,14 +32,14 @@ * *

Maven 3.4.0 Release

Hi to all, I would like to know what prevents us currently from releasing Maven 3.4.0 ? Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail:

[GitHub] maven-surefire pull request #126: Make Junit4VersionsIT parameterized

GitHub user britter opened a pull request: https://github.com/apache/maven-surefire/pull/126 Make Junit4VersionsIT parameterized In preparation for introducing more JUnit 5 ITs, make the Junit4VersionsIT parameterized. You can merge this pull request into a Git repository by

Re: svn commit: r1763929 - /maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/internal/DefaultProjectInstaller.java

Hi Buillaume, On 09/10/16 14:28, Guillaume Boué wrote: If the caller needs to force a different local repository than the one in the Maven session, they can already call "repositoryManager.setLocalRepositoryBasedir" on the building request that is passed to ProjectInstaller. This is what the

Re: [SUREFIRE] Parameterized Tests for Junit 4 and Junit 5? (Was: [SUREFIRE] JUnit 5 support - how to move things forward?)

Hello Tibor, I've played around a bit with the idea and I think there is a problem: If you want to compile and run test using JUnit 4 annotations using JUnit 5, you need the vintage enigne in your dependencies. Otherwise you get compile errors, because neither jupiter engine nor jupiter api ship

[GitHub] maven-surefire pull request #127: [SUREFIRE 1293] Simplify org.apache.maven....

GitHub user britter opened a pull request: https://github.com/apache/maven-surefire/pull/127 [SUREFIRE 1293] Simplify org.apache.maven.plugin.surefire.report.TestSetRunListener by using the null object pattern Added null object implementations for fields used by TestSetRunListener

Re: Maven 3.4.0 Release

Am 10/09/16 um 21:44 schrieb Stephen Connolly: > Open issues bound to 3.4.0 > > * Introduction of model version 4.1.0. > https://issues.apache.org/jira/browse/MNG-6082 > > assignee: Christian Schulte (reporter: Christian

Re: Maven 3.4.0 Release

Am 10/09/16 um 14:10 schrieb Jason van Zyl: > The preparation of detailed released notes to be reviewed. The last release > was almost a year ago, and an enormous number of behavioral changes have been > made in that time-frame. There’s zero documentation outlining these changes > thus far in

Re: Maven 3.4.0 Release

I would add MNG-5889 to 3.4 after proper testing. On Sun, Oct 9, 2016 at 8:41 PM, Robert Scholte wrote: > Open issues bound to 3.4.0 > > * Introduction of model version 4.1.0. > https://issues.apache.org/jira/browse/MNG-6082 > assignee: Christian Schulte (reporter:

Re: Maven 3.4.0 Release

Le dimanche 9 octobre 2016 21:11:03 Michael Osipov a écrit : > Am 2016-10-09 um 20:41 schrieb Robert Scholte: > > Open issues bound to 3.4.0 > > > > * Document how to configure Gossip > > > > https://issues.apache.org/jira/browse/MNG-6044 > > assignee: - (reporter: Michael Osipov) > > I am

[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...

Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/94 Pushed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Maven 3.4.0 Release

Am 2016-10-09 um 20:41 schrieb Robert Scholte: Open issues bound to 3.4.0 * Document how to configure Gossip https://issues.apache.org/jira/browse/MNG-6044 assignee: - (reporter: Michael Osipov) I am not able to properly solve this issue because I have no idea about Gossip. This should

Re: Maven 3.4.0 Release

I believe we definitely need RCs in this case. > On Oct 9, 2016, at 1:17 PM, Michael Osipov wrote: > > Am 2016-10-09 um 14:10 schrieb Jason van Zyl: >> The preparation of detailed released notes to be reviewed. The last >> release was almost a year ago, and an enormous

[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...

Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/94 Don't create a new PR. Just amend the last commit `git commit --amend` and push it again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: Maven 3.4.0 Release

Am 2016-10-09 um 14:10 schrieb Jason van Zyl: The preparation of detailed released notes to be reviewed. The last release was almost a year ago, and an enormous number of behavioral changes have been made in that time-frame. There’s zero documentation outlining these changes thus far in the site

Re: Maven 3.4.0 Release

Am 2016-10-09 um 23:51 schrieb Hervé BOUTEMY: Le dimanche 9 octobre 2016 21:11:03 Michael Osipov a écrit : Am 2016-10-09 um 20:41 schrieb Robert Scholte: Open issues bound to 3.4.0 * Document how to configure Gossip https://issues.apache.org/jira/browse/MNG-6044 assignee: - (reporter:

Re: Maven 3.4.0 Release

Open issues bound to 3.4.0 * Introduction of model version 4.1.0. https://issues.apache.org/jira/browse/MNG-6082 assignee: Christian Schulte (reporter: Christian Schulte) * Document how to configure Gossip https://issues.apache.org/jira/browse/MNG-6044 assignee: - (reporter: Michael

Re: Maven 3.4.0 Release

On Sunday 9 October 2016, Robert Scholte wrote: > Open issues bound to 3.4.0 > > * Introduction of model version 4.1.0. > https://issues.apache.org/jira/browse/MNG-6082 > assignee: Christian Schulte (reporter: Christian Schulte) I am -1 on this change as I understand

Re: Maven 3.4.0 Release

Le dimanche 9 octobre 2016 20:41:13 Robert Scholte a écrit : > Open issues bound to 3.4.0 > > * after forked execution success, add an empty line >https://issues.apache.org/jira/browse/MNG-6088 >assignee: Hervé Boutemy (reporter: Hervé Boutemy) I just closed this issue, which I had

Re: Maven 3.4.0 Release

Le dimanche 9 octobre 2016 21:11:03 Michael Osipov a écrit : > > * Document Jansi's native support limitation > > > > https://issues.apache.org/jira/browse/MNG-6045 > > assignee: - (reporter: Michael Osipov) > > Funny thing is that I have reached out to the devs of Jansi to fix some > issues

Re: shared: maven-artifact-transfer

Hi, I'm trying to continue to write tests for the component, but at the momemt it seemed to me that I oversight something...(I'm blockhead at the moment) The pom of the component: https://gist.github.com/khmarbaise/2ed49e791bab6a374b7862691dbfd7b5 and the output if i try to run: mvn

Re: svn commit: r1763929 - /maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/internal/DefaultProjectInstaller.java

Hi, Yes it has been introduced by me...and yes not all plugins are using it cause I would like to have some tests before spreading it to the "world" of plugins.. Kind regards Karl Heinz On 09/10/16 11:07, Robert Scholte wrote: Hi, IIRC ProjectInstaller has been introduced recently, I can