Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77742105
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/log/PluginConsoleLogger.java
---
@@ -0,0 +1,126 @@
+package
Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77741146
--- Diff:
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
---
@@ -34,10 +34,11 @@
import
GitHub user rpatrick00 reopened a pull request:
https://github.com/apache/maven/pull/93
MNG-5889 - adding logic that looks for the file argument and starts tâ¦
â¦he search for the .mvn directory at the location of the specified POM
when present
You can merge this pull request
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/117
@hboutemy I found NPE so that consoleLogger is null. I will fix it and run
the tests again. Some tests were successful.
---
If your project is set up for it, you can reply to this email and
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/118
I did not notice you was @IRC. The build take 40 minutes to complete :) We
have many tests :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/93
Fixing a small problem...will resubmit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rpatrick00 closed the pull request at:
https://github.com/apache/maven/pull/93
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@brianf
In generally this is a good starting point of course.
We should have such ITs which cover the functionality of provider from the
configuration point of view. So as for
GitHub user rpatrick00 opened a pull request:
https://github.com/apache/maven/pull/93
MNG-5889 - adding logic that looks for the file argument and starts tâ¦
â¦he search for the .mvn directory at the location of the specified POM
when present
You can merge this pull request into
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/118#discussion_r77731011
--- Diff:
surefire-integration-tests/src/test/resources/junit5/src/test/java/junit5/JUnit4Test.java
---
@@ -0,0 +1,67 @@
+package junit5;
+
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/118#discussion_r77730855
--- Diff:
surefire-integration-tests/src/test/resources/junit5/src/test/java/junit5/JUnit4Test.java
---
@@ -0,0 +1,67 @@
+package junit5;
+
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/118#discussion_r77729954
--- Diff: surefire-integration-tests/src/test/resources/junit5/pom.xml ---
@@ -0,0 +1,77 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/117
@hboutemy now we can test. All unit tests passed and I picked up first IT
and passed successfully. So I am going to run all ITs. The content of binaries
is expected and I compared it with
I have fixed for Bug HYPERLINK
"https://issues.apache.org/jira/browse/MNG-5889"MNG-5889. How should I submit
the fix?
--
Robert Patrick mailto:robert.patr...@oracle.com"robert.patr...@oracle.com>
VP, OPC Development, Oracle Corporation
7460 Warren Pkwy, Ste. 300 Office:
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/118
Add basic integration test for JUnit 5
This is WIP. My take on adding a first basic integration test for JUnit 5.
If this is going in the right direction we can add more tests.
You can
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77627125
--- Diff:
surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
---
@@ -38,11 +38,16 @@
import
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77626502
--- Diff:
surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java
---
@@ -46,10 +48,8 @@
import static
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77626386
--- Diff:
surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/Level.java
---
@@ -0,0 +1,83 @@
+package
Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77579970
--- Diff:
surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
---
@@ -38,11 +38,16 @@
import
Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77579682
--- Diff:
surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java
---
@@ -46,10 +48,8 @@
import static
Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77579430
--- Diff:
surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/Level.java
---
@@ -0,0 +1,83 @@
+package
21 matches
Mail list logo
