Re: [VOTE] Release Apache Maven 4.0.0-alpha-5

2023-03-19 Thread Petr Široký
+1 (non-binding) Smoke tested on Linux with JDK 19 and 20 (EA build) and looks good. --- Original Message --- On Wednesday, March 15th, 2023 at 18:14, Guillaume Nodet wrote: > > > Hey > > We solved 26 issues: > >

MCOMPILER-391 - request for review (using dependency management for annotationProcessorPaths)

2023-03-18 Thread Petr Široký
Hello everyone, some time ago I started looking into https://issues.apache.org/jira/browse/MCOMPILER-391 - which basically requests that maven-compiler-plugin and its 'annotationProcessorPaths' configuration should follow dependencyManagement (if specified), instead of requiring explicit

Re: [VOTE] Release Apache Maven Surefire/Failsafe Plugin version 3.0.0

2023-03-13 Thread Petr Široký
+1 (non-binding) Tested on several projects on Linux with JDK 19. No issue found. --- Original Message --- On Saturday, March 11th, 2023 at 10:08, Slawomir Jaranowski wrote: > > > Hi, > > We solved 6 issues: >

Re: [VOTE] Release Apache Maven version 3.8.8

2023-03-10 Thread Petr Široký
+1 (non-binding) Tested using several projects on Linux with JDK 17 and 19. No issue found. --- Original Message --- On Wednesday, March 8th, 2023 at 16:12, Michael Osipov wrote: > > > Hi, > > We solved 17 issues: >

Re: [VOTE] Release maven-compiler-plugin 3.11.0

2023-02-15 Thread Petr Široký
; I didn’t check the rest of the source-release.zip vs the tag but this > doesn’t look similar at least for this directory. > I just wonder if there are other differences? > > > > > > On Wed, 15 Feb 2023 at 21:36, Petr Široký petr.sir...@proton.me.invalid wrote: > >

Re: [VOTE] Release maven-compiler-plugin 3.11.0

2023-02-15 Thread Petr Široký
The failed IT is 'src/it/MCOMPILER-517-install-not-recompile', which I am not seeing in the git repo (https://github.com/apache/maven-compiler-plugin/tree/maven-compiler-plugin-3.11.0/src/it). Is it possible you have this IT only locally (and thus not re-formatted yet)? Thanks, Petr ---

Re: [VOTE] Release maven-compiler-plugin 3.11.0

2023-02-14 Thread Petr Široký
+1 (non-binding) Tested on several projects (on Linux and JDK 19.0.2). No issue found. Petr --- Original Message --- On Tuesday, February 14th, 2023 at 09:51, Guillaume Nodet wrote: > > > Hi, > I'd like to release Apache Maven Compiler Plugin 3.11.0 > > 7 issues fixed >

Re: Bug report - maven shade plugin - transitive dependencies of provided dependency included in uber-jar

2023-02-09 Thread Petr Široký
Hello, I took a quick look at the reproducing project you linked (https://github.com/cerveada/shade-plugin-issue) and I think the reason for the behavior you are seeing is the content of section in the bundle/pom.xml: org.apache.spark spark-core_2.12 2.4.8

Re: [VOTE] Release Apache Maven 3.9.0

2023-01-31 Thread Petr Široký
+1 (non-binding) Tested on several projects (both small and big) and found no functional issue. The only thing I noticed is that 3.9.0 is a bit "slower" than 3.8.7. The following numbers are from a very big project - Quarkus, which has ~1k modules (https://github.com/quarkusio/quarkus),

Re: [VOTE] Release Apache Maven Daemon 0.9.0

2023-01-25 Thread Petr Široký
+1 (non-binding) Tested on several projects on Linux with JDK 19. No issue found. The URL https://github.com/apache/maven-mvnd/releases/tag/untagged-7cae83258923acd48d99 is giving me 404 though. --- Original Message --- On Wednesday, January 25th, 2023 at 10:10, Guillaume Nodet

Re: Upcoming Maven Enforcer 3.2.0 release

2023-01-23 Thread Petr Široký
Hello, great stuff! Looking forward to that release. I gave the latest 3.2.0-SNAPSHOT (26697b16) a quick try with Quarkus repo (https://github.com/quarkusio/quarkus), since the project is pretty big (more than 1k sub-modules) and it also uses enforcer quite extensively (multiple executions).

Re: [maven-compiler-plugin] Helping with implementing new features / bug fixes

2023-01-22 Thread Petr Široký
> Simply please create PR with a proposition ... if nobody responds with a > review you can ping on dev list. > > > > > wt., 17 sty 2023 o 23:41 Petr Široký petr.sir...@proton.me.invalid > > napisał(a): > > > Hello everyone, > > > > I recently start

[maven-compiler-plugin] Helping with implementing new features / bug fixes

2023-01-17 Thread Petr Široký
Hello everyone, I recently started contributing with small changes to some of the Maven projects (mainly enforcer and IT repo) and I am now looking where I could help further. One of the areas that caught my eye is the maven-compiler-plugin and specifically the annotationProcessorPaths

Re: [VOTE] Release Maven Surefire version 3.0.0-M8

2023-01-09 Thread Petr Široký
+1 (non-binding). Tested with several projects on Linux. No issue found. --- Original Message --- On Saturday, January 7th, 2023 at 14:07, Michael Osipov wrote: > > > Hi, > > We solved 18 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12351809

Re: [VOTE] Release Apache Maven version 3.8.7

2022-12-29 Thread Petr Široký
+1 (non-binding) Tested with several projects, ranging from small single-module ones to some with hundreds of sub-modules. No issue found. --- Original Message --- On Saturday, December 24th, 2022 at 21:20, Michael Osipov wrote: > > > Hi, > > We solved 19 issues: >

Re: [VOTE] Release Apache Maven 4.0.0-alpha-3

2022-12-14 Thread Petr Široký
Hello everyone, I have tried to build a sample project locally using Maven 4.0.0-alpha-3 and I am seeing one difference / inconsistency with the behavior of empty tag in settings.xml file, when comparing to Maven 3.8.6. My settings.xml file looks like this:

Re: [VOTE] Release Apache Maven 3.5.2

2017-10-20 Thread Petr Široký
+1 (non-binding) Tested with OracleJDK 1.8.0_144 on several large multi-module projects. No issue found. Petr On Fri, Oct 20, 2017 at 9:46 PM Arnaud Héritier wrote: > +1 for me too > Used it with no issue (but my usages are limited) > > On Fri, Oct 20, 2017 at 8:34 PM,

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-14 Thread Petr Široký
ot; is just misuse on our side or if it's something that more plugins may rely on. Petr On Thu, Sep 14, 2017 at 2:42 PM Petr Široký <siroky.p...@gmail.com> wrote: > Argh, I forgot to link the plugin source: > https://github.com/kiegroup/droolsjbpm-integration/tree/7.3.0.Final/kie-mav

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-14 Thread Petr Široký
Argh, I forgot to link the plugin source: https://github.com/kiegroup/droolsjbpm-integration/tree/7.3.0.Final/kie-maven-plugin On Thu, Sep 14, 2017 at 2:41 PM Petr Široký <siroky.p...@gmail.com> wrote: > Hello, > > I am seeing a (probably) similar issue with our custom

Re: [VOTE] Release Apache Maven 3.5.1

2017-09-14 Thread Petr Široký
Hello, I am seeing a (probably) similar issue with our custom plugin. See the reproducer: https://github.com/psiroky/reproducers/tree/mvn351-kie-maven-plugin (works fine with maven 3.5.0, but fails with NPE with the RC of maven 3.5.1). I am not yet sure if the plugin is just doing something

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

2017-09-14 Thread Petr Široký
+1 non-binding. Tested on several projects with thousands of tests (both surefire and failsafe ones). No issue found. Env: Fedora 25 Oracle JDK 8 Maven 3.5.0. Petr On Thu, Sep 14, 2017 at 8:00 AM Tibor Digana wrote: > (again from my Apache mail account) > Pls

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20 - TAKE 3

2017-04-08 Thread Petr Široký
+1 (non-binding) Tested on Fedora 25 + JDK 8u121 + Maven 3.5.0 with several large projects. No issue found. @Tibor, thanks for fixing all the issues I found previously! Petr On Sat, Apr 8, 2017 at 12:53 PM Tibor Digana wrote: > Hi, > > We solved 70 issues: > >

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20 - TAKE 2

2017-04-08 Thread Petr Široký
; tibor.dig...@googlemail.com> > > wrote: > > > > > @Petr > > > Both issues are fixed now. Would you please verify this version from > > > master? I tested on my side. > > > > > > On Fri, Apr 7, 2017 at 3:42 PM, Petr Široký <siroky.p...@

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20 - TAKE 2

2017-04-07 Thread Petr Široký
when JMX observes debug > mode. > See implementation in JUnit sources. The same is there. > Can you open pull request with a fix? > > On Fri, Apr 7, 2017 at 11:06 AM, Petr Široký <siroky.p...@gmail.com> > wrote: > > > Hello, > > > > thanks for the fast

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20 - TAKE 2

2017-04-07 Thread Petr Široký
ith 2.19.1 and the output is correct there -- file:/home/psiroky/tmp/surefire-2.20-debug/target/test-classes/ I believe, technically, the path is still valid, it's just that the tests are not expecting the duplicated slash and string comparison is failing on that. Petr On Fri, Apr 7, 2017 at 11:06 AM P

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20 - TAKE 2

2017-04-07 Thread Petr Široký
Hello, thanks for the fast turnaround. I am afraid I've hit another issue (or maybe misconfiguration?). I was trying to use -Dmaven.surefire.debug in the following project: https://github.com/psiroky/surefire-2.20-debug-reproducer $ mvn clean install -s settings.xml -Dmaven.surefire.debug The

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Petr Široký
gt; This happens but the listener which is expected to listen to BYE_ACK > >>>> from > >>>> Maven process is registered after this sending BYE and not before. > >>>> Therefore this is concurrency issue. > >>>> > >>>> > &

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Petr Široký
orked JVM? > Not sure I understand what this means. How would I dump the native stream? > > On Wed, Apr 5, 2017 at 12:31 PM, Petr Široký <siroky.p...@gmail.com> > wrote: > > > I've just tried on Windwos 2012R2 + Maven 3.2.3 and RHEL 7.3 + Maven > 3.2.5. > > Th

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Petr Široký
I've just tried on Windwos 2012R2 + Maven 3.2.3 and RHEL 7.3 + Maven 3.2.5. The 30s wait is somehow intermittent. I can still reproduce on those platforms, but it takes 10 or 15 tries. On Fedora 25 it happens almost always (but I have seen it pass also there). On Wed, Apr 5, 2017 at 11:50 AM

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20

2017-04-05 Thread Petr Široký
Hello, I've tried with several projects and functionally, everything seems OK. However, I noticed certain slowdown in case multiple forks are beings used to run the tests. After some investigation, it seems one of the forked VMs gets "stuck" for about 30s before it gets shutdown. So every

Re: [VOTE] Release Apache Maven 3.5.0

2017-04-04 Thread Petr Široký
+1 (non-binding) Tested on several big projects, with dozens of different plugins. No issue found. On Tue, Apr 4, 2017 at 12:14 AM Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Hi, > > We solved 86 issues: > >

Re: [VOTE] Release Apache Maven 3.5.0-alpha-1

2017-02-24 Thread Petr Široký
Hello, I've tested the 3.5.0-alpha-1 with several quite large projects (hundreds of modules in total) and everything looks good. +1 non-binding (hopefully I understood correctly I can do that) Petr On Fri, Feb 24, 2017 at 11:13 AM Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: >